Loosen-IT/WP-LIT-MCP
3
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 7 Wiki Activity

feat: Protokoll tab as a core-style list table

Browse Source 
The change summary is the wide primary column (key "title", so it cannot
be hidden) with the tool's human label below and row actions "Revision
ansehen" / "Objekt öffnen". Objects get human names ("Seite: Kontakt",
"Menü: …", "Einstellungen: Titel der Website"; deleted/trashed marked),
primed per page with one query each for posts, menus and users. Times are
relative within 24 h. Non-ok results show a badge and a marked row instead
of an Ergebnis column. Page size and columns via Screen Options; the tool
filter shows labels grouped by integration, dates have visible labels,
and an active filter offers "Filter zurücksetzen" (also in the empty state).

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01At3V6SjwbMe6eMzVGW3Hs7
This commit is contained in:
janniclas.loosen
2026-09-26 19:02:47 +02:00
co-authored by Claude Opus 5.5
parent 22c4cc1264
commit 0f23192873
9 changed files with 1124 additions and 351 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/Unit/Admin/LogListTableTest.php
+176 -153
View File
@@ -6,27 +6,31 @@ namespace LIT\MCP\Tests\Unit\Admin;
use Brain\Monkey\Functions;
use LIT\MCP\Admin\LogListTable;
use LIT\MCP\Admin\LogObjects;
use LIT\MCP\ChangeLog\ChangeLog;
use LIT\MCP\Tests\Unit\TestCase;
use Mockery;
use WP_Post;
use WP_Term;
final class LogListTableTest extends TestCase
{
private const NOW = 1790441353; // 2026-09-26 16:49:13 UTC
protected function setUp(): void
{
parent::setUp();
Functions\stubEscapeFunctions();
Functions\stubTranslationFunctions();
// Harmless defaults so single_row()'s full column pass doesn't blow up in tests
// that only care about a subset of columns; overridden per test where needed.
// Harmless defaults so a full row renders in tests that only care about one column.
Functions\when('get_userdata')->justReturn(false);
Functions\when('post_type_exists')->justReturn(false);
Functions\when('get_post')->justReturn(null);
Functions\when('get_term')->justReturn(null);
Functions\when('current_user_can')->justReturn(false);
Functions\when('get_user_option')->justReturn(false);
Functions\when('get_option')->alias(static fn (string $key) => $key === 'date_format' ? 'j. F Y' : 'H:i');
Functions\when('wp_date')->alias(static fn (string $format, int $ts): string => $format . '@' . $ts);
Functions\when('admin_url')->alias(static fn (string $path = ''): string => 'https://kunde.de/wp-admin/' . $path);
Functions\when('add_query_arg')->alias(static fn (array $args, string $url): string => $url . '?' . http_build_query($args));
}
protected function tearDown(): void
@@ -35,232 +39,251 @@ final class LogListTableTest extends TestCase
parent::tearDown();
}
public function testPrepareItemsQueriesTheCurrentPageAndSetsPagination(): void
/**
* @param array<string, mixed> $filters
* @param array<string, string> $toolLabels
*/
private function table(array $filters = [], array $toolLabels = [], ?LogObjects $objects = null, ?ChangeLog $log = null): LogListTable
{
return new LogListTable(
$log ?? Mockery::mock(ChangeLog::class),
$filters + ['ability' => '', 'user_id' => 0],
null,
$toolLabels,
$objects,
self::NOW
);
}
public function testPrepareItemsUsesThePerPageScreenOptionAndPrimesUsersAndObjectsOnce(): void
{
$_GET['paged'] = '3';
Functions\when('get_user_option')->alias(static fn (string $key) => $key === 'lit_mcp_log_per_page' ? '30' : false);
$rows = [
['id' => '2', 'user_id' => '3', 'object_type' => 'page', 'object_id' => '12'],
['id' => '1', 'user_id' => '3', 'object_type' => 'page', 'object_id' => '13'],
['id' => '0', 'user_id' => '4', 'object_type' => 'option', 'object_id' => 'blogname'],
];
$log = Mockery::mock(ChangeLog::class);
$log->expects('query')
->with(['ability' => 'lit/content-update', 'user_id' => 0], 50, 100)
->andReturn(['rows' => [['id' => '1']], 'total' => 120]);
->with(['ability' => 'lit/content-update', 'user_id' => 0], 30, 60)
->andReturn(['rows' => $rows, 'total' => 120]);
Functions\when('post_type_exists')->justReturn(true);
Functions\expect('cache_users')->once()->with([3, 4]);
Functions\expect('_prime_post_caches')->once()->with([12, 13], false, false);
$table = new LogListTable($log, ['ability' => 'lit/content-update', 'user_id' => 0]);
$table = $this->table(['ability' => 'lit/content-update'], [], new LogObjects(), $log);
$table->prepare_items();
self::assertSame([['id' => '1']], $table->items);
self::assertSame(['total_items' => 120, 'per_page' => 50], $table->pagination_args());
self::assertSame($rows, $table->items);
self::assertSame(['total_items' => 120, 'per_page' => 30], $table->pagination_args());
}
public function testColumnDefaultEscapesUntrustedClientAndSummaryText(): void
public function testPrepareItemsDefaultsToTwentyPerPage(): void
{
$table = new LogListTable(Mockery::mock(ChangeLog::class), ['ability' => '', 'user_id' => 0]);
$log = Mockery::mock(ChangeLog::class);
$log->expects('query')->with(['ability' => '', 'user_id' => 0], 20, 0)->andReturn(['rows' => [], 'total' => 0]);
$item = ['client' => 'Claude <script>alert(1)</script>', 'summary' => '<b>böse</b> Zusammenfassung'];
$table = $this->table([], [], null, $log);
$table->prepare_items();
self::assertStringNotContainsString('<script>', $this->columnDefault($table, $item, 'client'));
self::assertStringContainsString('&lt;script&gt;', $this->columnDefault($table, $item, 'client'));
self::assertStringNotContainsString('<b>', $this->columnDefault($table, $item, 'summary'));
self::assertSame(['total_items' => 0, 'per_page' => 20], $table->pagination_args());
}
public function testColumnDefaultShowsUserDisplayNameOrFallback(): void
public function testColumnsPutTheChangeFirstAsTheUnhideablePrimaryColumn(): void
{
$table = new LogListTable(Mockery::mock(ChangeLog::class), ['ability' => '', 'user_id' => 0]);
Functions\when('get_userdata')->justReturn((object) ['display_name' => 'Jan <b>']);
$table = $this->table();
$withUser = $this->columnDefault($table, ['user_id' => 3], 'user');
self::assertStringContainsString('Jan &lt;b&gt;', $withUser);
self::assertSame(
['title' => 'Änderung', 'object' => 'Objekt', 'user' => 'Wer', 'created_at' => 'Zeit'],
$table->get_columns()
);
// "title" like core's own primary columns: WordPress never offers it for hiding (WP_Screen).
self::assertSame('title', $this->invoke($table, 'get_default_primary_column_name'));
}
public function testColumnDefaultUserFallsBackToIdWhenUserIsGone(): void
public function testChangeColumnShowsTheSummaryAndTheToolsHumanLabel(): void
{
$table = new LogListTable(Mockery::mock(ChangeLog::class), ['ability' => '', 'user_id' => 0]);
Functions\when('get_userdata')->justReturn(false);
$table = $this->table([], ['lit/media-upload-from-url' => 'Datei von URL <importieren>']);
self::assertSame('#7', $this->columnDefault($table, ['user_id' => 7], 'user'));
$html = $this->column($table, ['summary' => 'Datei <b>X</b> importiert', 'ability' => 'lit/media-upload-from-url', 'result' => 'ok'], 'title');
self::assertStringContainsString('Datei &lt;b&gt;X&lt;/b&gt; importiert', $html);
self::assertStringContainsString(
'<span class="lit-mcp-muted" title="lit/media-upload-from-url">Datei von URL &lt;importieren&gt;</span>',
$html
);
self::assertStringNotContainsString('lit-mcp-badge', $html);
}
public function testColumnDefaultLinksTheObjectForAKnownPostType(): void
public function testChangeColumnFallsBackToTheToolNameForAnUnknownTool(): void
{
Functions\when('post_type_exists')->justReturn(true);
Functions\when('get_edit_post_link')->justReturn('https://kunde.de/wp-admin/post.php?post=12&action=edit');
$table = new LogListTable(Mockery::mock(ChangeLog::class), ['ability' => '', 'user_id' => 0]);
$html = $this->column($this->table(), ['summary' => 'x', 'ability' => 'lit/gone<', 'result' => 'ok'], 'title');
$html = $this->columnDefault($table, ['object_type' => 'page', 'object_id' => '12'], 'object');
self::assertStringContainsString('href="https://kunde.de/wp-admin/post.php?post=12&action=edit"', $html);
self::assertStringContainsString('page 12', $html);
self::assertStringContainsString('<span class="lit-mcp-muted">lit/gone&lt;</span>', $html);
}
public function testColumnDefaultShowsPlainLabelWhenGetEditPostLinkRefusesIt(): void
/** @dataProvider notOk */
public function testANotOkResultGetsABadgeAndAMarkedRow(string $result, string $class, string $word): void
{
Functions\when('post_type_exists')->justReturn(true);
Functions\when('get_edit_post_link')->justReturn(null);
$table = new LogListTable(Mockery::mock(ChangeLog::class), ['ability' => '', 'user_id' => 0]);
$table = $this->table();
$html = $this->columnDefault($table, ['object_type' => 'page', 'object_id' => '12'], 'object');
$html = $this->column($table, ['summary' => 'x', 'ability' => 'lit/a', 'result' => $result], 'title');
self::assertStringContainsString('<span class="lit-mcp-badge lit-mcp-badge-' . $class . '">' . $word . '</span>', $html);
self::assertSame('page 12', $html);
}
public function testColumnDefaultLinksAnAttachmentToTheMediaEditScreen(): void
{
Functions\when('post_type_exists')->justReturn(true);
Functions\when('get_post')->justReturn(new WP_Post(['ID' => 5]));
Functions\when('admin_url')->alias(static fn (string $path = ''): string => 'https://kunde.de/wp-admin/' . $path);
$table = new LogListTable(Mockery::mock(ChangeLog::class), ['ability' => '', 'user_id' => 0]);
$html = $this->columnDefault($table, ['object_type' => 'attachment', 'object_id' => '5'], 'object');
self::assertStringContainsString('href="https://kunde.de/wp-admin/upload.php?item=5"', $html);
}
public function testColumnDefaultShowsPlainLabelForADeletedAttachment(): void
{
Functions\when('get_post')->justReturn(null);
$table = new LogListTable(Mockery::mock(ChangeLog::class), ['ability' => '', 'user_id' => 0]);
self::assertSame('attachment 5', $this->columnDefault($table, ['object_type' => 'attachment', 'object_id' => '5'], 'object'));
}
public function testColumnDefaultLinksANavMenuToTheMenusScreen(): void
{
Functions\when('get_term')->justReturn(new WP_Term(['term_id' => 3, 'taxonomy' => 'nav_menu']));
Functions\when('admin_url')->alias(static fn (string $path = ''): string => 'https://kunde.de/wp-admin/' . $path);
$table = new LogListTable(Mockery::mock(ChangeLog::class), ['ability' => '', 'user_id' => 0]);
$html = $this->columnDefault($table, ['object_type' => 'nav_menu', 'object_id' => '3'], 'object');
self::assertStringContainsString('href="https://kunde.de/wp-admin/nav-menus.php?menu=3"', $html);
}
/** @dataProvider unlinkableObjectTypes */
public function testColumnDefaultNeverLinksSettingsOrMenuLocations(string $type, string $id): void
{
Functions\when('post_type_exists')->justReturn(false);
$table = new LogListTable(Mockery::mock(ChangeLog::class), ['ability' => '', 'user_id' => 0]);
self::assertSame(trim($type . ' ' . $id), $this->columnDefault($table, ['object_type' => $type, 'object_id' => $id], 'object'));
ob_start();
$table->single_row(['result' => $result, 'summary' => 'x', 'ability' => 'lit/a']);
self::assertStringStartsWith('<tr class="lit-mcp-row-' . $class . '">', (string) ob_get_clean());
}
/** @return list<list<string>> */
public static function unlinkableObjectTypes(): array
public static function notOk(): array
{
return [
['option', 'blogname,blogdescription'],
['menu_location', 'primary'],
['unknown', '42'],
['partial', 'warning', 'teilweise'],
['failed', 'error', 'fehlgeschlagen'],
['<b>kaputt', 'error', 'unbekannt'],
];
}
public function testRevisionColumnShowsADashWithoutARevision(): void
public function testAnOkRowIsNotMarked(): void
{
$table = new LogListTable(Mockery::mock(ChangeLog::class), ['ability' => '', 'user_id' => 0]);
ob_start();
$this->table()->single_row(['result' => 'ok', 'summary' => 'x', 'ability' => 'lit/a']);
self::assertSame('–', $this->columnDefault($table, ['revision_id' => 0], 'revision'));
self::assertStringStartsWith('<tr>', (string) ob_get_clean());
}
public function testRevisionColumnLinksOnlyWhenTheUserCanEditTheParentPost(): void
public function testRowActionsOfferTheRevisionAndTheObjectOnlyWhereTheyExist(): void
{
$objects = Mockery::mock(LogObjects::class);
$objects->allows('describe')->with('page', '12')->andReturn(['html' => 'Seite: X', 'url' => 'https://kunde.de/wp-admin/post.php?post=12&action=edit']);
$objects->allows('describe')->with('option', 'blogname')->andReturn(['html' => 'Einstellung: Titel', 'url' => '']);
Functions\when('get_post')->justReturn(new WP_Post(['ID' => 811, 'post_type' => 'revision', 'post_parent' => 12]));
Functions\when('current_user_can')->justReturn(true);
Functions\when('admin_url')->alias(static fn (string $path = ''): string => 'https://kunde.de/wp-admin/' . $path);
$table = new LogListTable(Mockery::mock(ChangeLog::class), ['ability' => '', 'user_id' => 0]);
Functions\when('current_user_can')->alias(static fn (string $cap, int $id = 0): bool => $cap === 'edit_post' && $id === 12);
$table = $this->table([], [], $objects);
$html = $this->columnDefault($table, ['revision_id' => 811], 'revision');
$both = $this->rowActions($table, ['object_type' => 'page', 'object_id' => '12', 'revision_id' => '811']);
self::assertStringContainsString('<a href="https://kunde.de/wp-admin/revision.php?revision=811">Revision ansehen</a>', $both);
self::assertStringContainsString('<a href="https://kunde.de/wp-admin/post.php?post=12&action=edit">Objekt öffnen</a>', $both);
self::assertStringContainsString('href="https://kunde.de/wp-admin/revision.php?revision=811"', $html);
$none = $this->rowActions($table, ['object_type' => 'option', 'object_id' => 'blogname', 'revision_id' => null]);
self::assertStringNotContainsString('row-actions', $none);
self::assertStringContainsString('toggle-row', $none, 'the mobile toggle stays');
self::assertSame('', $this->invoke($table, 'handle_row_actions', ['object_type' => 'option'], 'user', 'title'));
}
public function testRevisionColumnHidesTheLinkWithoutEditPermission(): void
public function testRevisionActionNeedsEditRightsOnTheParentPost(): void
{
Functions\when('get_post')->justReturn(new WP_Post(['ID' => 811, 'post_type' => 'revision', 'post_parent' => 12]));
Functions\when('current_user_can')->justReturn(false);
$table = new LogListTable(Mockery::mock(ChangeLog::class), ['ability' => '', 'user_id' => 0]);
self::assertSame('–', $this->columnDefault($table, ['revision_id' => 811], 'revision'));
$html = $this->rowActions($this->table(), ['object_type' => 'x', 'object_id' => '1', 'revision_id' => '811']);
self::assertStringNotContainsString('revision.php', $html);
}
public function testSingleRowHighlightsPartialResults(): void
public function testObjectColumnUsesTheHumanObjectDescription(): void
{
$table = new LogListTable(Mockery::mock(ChangeLog::class), ['ability' => '', 'user_id' => 0]);
$objects = Mockery::mock(LogObjects::class);
$objects->expects('describe')->with('page', '12')->andReturn(['html' => 'Seite: <a href="u">X</a>', 'url' => 'u']);
self::assertSame('Seite: <a href="u">X</a>', $this->column($this->table([], [], $objects), ['object_type' => 'page', 'object_id' => '12'], 'object'));
}
public function testUserColumnShowsTheNameAndTheShortenedClientWithFullNameAsTitle(): void
{
Functions\when('get_userdata')->justReturn((object) ['display_name' => 'Jan <b>']);
$client = 'lit-mcp-integration-test-client-<script>';
$html = $this->column($this->table(), ['user_id' => 3, 'client' => $client], 'user');
self::assertStringStartsWith('Jan &lt;b&gt;<br>', $html);
self::assertStringContainsString('title="lit-mcp-integration-test-client-&lt;script&gt;"', $html);
self::assertStringContainsString('>lit-mcp-integration-t…</span>', $html);
self::assertStringNotContainsString('<script>', $html);
}
public function testUserColumnFallsBackToTheIdAndOmitsAnEmptyClient(): void
{
self::assertSame('#7', $this->column($this->table(), ['user_id' => 7, 'client' => ''], 'user'));
self::assertSame(
'#7<br><span class="lit-mcp-muted" title="Claude">Claude</span>',
$this->column($this->table(), ['user_id' => 7, 'client' => 'Claude'], 'user')
);
}
public function testTimeIsRelativeWithinADay(): void
{
Functions\when('human_time_diff')->alias(static fn (int $from, int $to): string => (($to - $from) / 60) . ' Minuten');
$html = $this->column($this->table(), ['created_at' => '2026-09-26 16:44:13'], 'created_at');
self::assertStringContainsString('>vor 5 Minuten</time>', $html);
self::assertStringContainsString('datetime="2026-09-26T16:44:13+00:00"', $html);
self::assertStringContainsString('title="j. F Y@' . (self::NOW - 300) . ' H:i@' . (self::NOW - 300) . ' (UTC: 2026-09-26 16:44:13)"', $html);
}
public function testOlderTimesShowTheSiteDateAndTime(): void
{
$ts = gmmktime(10, 39, 13, 9, 24, 2026);
$html = $this->column($this->table(), ['created_at' => '2026-09-24 10:39:13'], 'created_at');
self::assertStringContainsString('>j. F Y@' . $ts . ' um H:i@' . $ts . '</time>', $html);
self::assertSame('–', $this->column($this->table(), ['created_at' => 'kaputt'], 'created_at'));
}
public function testEmptyStateWithoutFilters(): void
{
ob_start();
$table->single_row(['result' => 'partial']);
$partial = (string) ob_get_clean();
$this->table()->no_items();
self::assertSame('Noch keine Änderungen protokolliert.', (string) ob_get_clean());
}
public function testEmptyStateWithFiltersOffersTheReset(): void
{
ob_start();
$table->single_row(['result' => 'ok']);
$ok = (string) ob_get_clean();
$this->table(['result' => 'partial'])->no_items();
self::assertStringContainsString('<tr class="lit-mcp-partial">', $partial);
self::assertSame('<tr>', substr($ok, 0, 4));
self::assertSame(
'Keine Einträge für diese Filter. <a href="https://kunde.de/wp-admin/options-general.php?page=lit-mcp&tab=protokoll">Filter zurücksetzen</a>',
(string) ob_get_clean()
);
}
public function testTimeColumnShowsSiteTimeInWordPressFormatWithUtcAsTitle(): void
{
Functions\when('get_option')->alias(static fn (string $key) => $key === 'date_format' ? 'd.m.Y' : 'H:i');
Functions\when('wp_date')->alias(static fn (string $format, int $ts): string => $format . '@' . $ts);
$table = new LogListTable(Mockery::mock(ChangeLog::class), ['ability' => '', 'user_id' => 0]);
self::assertSame('Zeit', $table->get_columns()['created_at']);
$html = $this->column($table, ['created_at' => '2026-09-26 10:39:13'], 'created_at');
self::assertStringContainsString('d.m.Y H:i@' . gmmktime(10, 39, 13, 9, 26, 2026), $html);
self::assertStringContainsString('title="UTC: 2026-09-26 10:39:13"', $html);
self::assertSame('–', $this->column($table, ['created_at' => 'kaputt'], 'created_at'));
}
/** @dataProvider results */
public function testResultColumnShowsIconAndWord(string $result, string $icon, string $word): void
{
$table = new LogListTable(Mockery::mock(ChangeLog::class), ['ability' => '', 'user_id' => 0]);
$html = $this->column($table, ['result' => $result], 'result');
self::assertStringContainsString('dashicons-' . $icon, $html);
self::assertStringContainsString($word, $html);
self::assertStringNotContainsString('error', $html);
}
/** @return list<list<string>> */
public static function results(): array
{
return [
['ok', 'yes-alt', 'erfolgreich'],
['partial', 'warning', 'teilweise'],
['error<b>', 'dismiss', 'unbekannt'],
];
}
public function testToolColumnIsMutedTextAndTopNavRendersTheGivenFilters(): void
public function testTopNavRendersTheGivenFilters(): void
{
$table = new LogListTable(Mockery::mock(ChangeLog::class), ['ability' => '', 'user_id' => 0], static function (): void {
echo '<select name="ability"></select>';
});
self::assertSame(
'<span class="lit-mcp-tool-name">lit/x&lt;</span>',
$this->column($table, ['ability' => 'lit/x<'], 'ability')
);
ob_start();
$table->display();
self::assertStringContainsString('<div class="alignleft actions"><select name="ability"></select></div>', (string) ob_get_clean());
}
/** @param array<string, mixed> $item */
private function rowActions(LogListTable $table, array $item): string
{
return (string) $this->invoke($table, 'handle_row_actions', $item, 'title', 'title');
}
private function invoke(LogListTable $table, string $method, mixed ...$args): mixed
{
return (new \ReflectionMethod($table, $method))->invoke($table, ...$args);
}
/** @param array<string, mixed> $item */
private function column(LogListTable $table, array $item, string $column): string
{
$method = 'column_' . $column;
if (method_exists($table, $method)) {
return (string) (new \ReflectionMethod($table, $method))->invoke($table, $item);
return (string) $this->invoke($table, $method, $item);
}
return $this->columnDefault($table, $item, $column);
}
/** @param array<string, mixed> $item */
private function columnDefault(LogListTable $table, array $item, string $column): string
{
return (string) (new \ReflectionMethod($table, 'column_default'))->invoke($table, $item, $column);
return (string) $this->invoke($table, 'column_default', $item, $column);
}
}