Loosen-IT/WP-LIT-MCP
3
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 7 Wiki Activity

refactor: one VariableRef per composition, design lookups in DesignSystem (H3)

Browse Source 
- DiviComposition::references() builds the one VariableRef with the entry's
  live map (S22/S31) and passes it to AttrWriter; Placeholders only needs the
  design system now, Placeholders::references() is gone (no reach-through).
- DesignSystem::colorIdFor()/variableFor() replace the dead colorId()/variable()
  and carry Placeholders' lookup incl. the S13a ambiguity check (byLabel moved,
  messages unchanged); isColorVariable() decides color vs content for {{var:}}.
- DesignSystem::colorReferenceIds() (VariableRef color names) and
  contentVariableIds() (DynamicContentRules design names) replace the two
  inline computations; same lists, same order.
Tests: fixtures/tests get the VariableRef from ComposeFixture::references() or
build it with the map; DesignSystemTest uses the new lookups (+2 tests).

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01At3V6SjwbMe6eMzVGW3Hs7
This commit is contained in:
janniclas.loosen
2026-09-26 18:07:56 +02:00
co-authored by Claude Opus 5.5
parent 874a92c6be
commit 203d14a2f9
12 changed files with 184 additions and 118 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/Unit/Integrations/Divi/Design/DesignSystemTest.php
+44 -6
View File
@@ -4,6 +4,7 @@ declare(strict_types=1);
namespace LIT\MCP\Tests\Unit\Integrations\Divi\Design;
use InvalidArgumentException;
use LIT\MCP\Integrations\Divi\Design\DesignSystem;
use LIT\MCP\Tests\Support\DiviFixtures;
use PHPUnit\Framework\TestCase;
@@ -34,16 +35,53 @@ final class DesignSystemTest extends TestCase
self::assertSame(['p-1' => 'Standard', 'p-2' => 'CTA primär', 'g-1' => 'Fließtext groß'], $design->presetNames());
}
/** The name lists VariableRef/DynamicContentRules check references against (H3: one place). */
public function testReferenceNameLists(): void
{
$design = new DesignSystem(
[['id' => 'gcid-a', 'label' => 'A', 'value' => '#000']],
[
['id' => 'gvid-c', 'type' => 'colors', 'label' => 'C', 'value' => '#fff'],
['id' => 'gvid-t', 'type' => 'strings', 'label' => 'T', 'value' => 'x'],
],
[],
['heading' => '', 'body' => ''],
[]
);
self::assertSame(['gcid-a', 'gvid-c'], $design->colorReferenceIds());
self::assertSame(['--et_global_heading_font', '--et_global_body_font', 'gvid-t'], $design->contentVariableIds());
self::assertTrue($design->isColorVariable('gvid-c'));
self::assertFalse($design->isColorVariable('gvid-t'));
self::assertFalse($design->isColorVariable('gcid-a'));
}
public function testLabelLookupsRefuseAmbiguousLabels(): void
{
$design = new DesignSystem(
[['id' => 'gcid-a', 'label' => 'Blau', 'value' => '#00f'], ['id' => 'gcid-b', 'label' => 'blau', 'value' => '#00e']],
[],
[],
['heading' => '', 'body' => ''],
[]
);
self::assertSame('gcid-b', $design->colorIdFor('gcid-b'));
$this->expectException(InvalidArgumentException::class);
$this->expectExceptionMessage('Name der globale Farbe "Blau" ist mehrdeutig; bitte die ID angeben: gcid-a, gcid-b.');
$design->colorIdFor('Blau');
}
public function testLooksUpByAliasLabelOrId(): void
{
$design = DiviFixtures::designSystem();
self::assertSame('gcid-primary-color', $design->colorId('primary'));
self::assertSame('gcid-a1b2', $design->colorId('nachtblau'));
self::assertSame('gcid-a1b2', $design->colorId('gcid-a1b2'));
self::assertNull($design->colorId('secondary'));
self::assertNull($design->colorId('Alt'));
self::assertSame('gvid-s1', $design->variable('telefon')['id'] ?? null);
self::assertSame('gcid-primary-color', $design->colorIdFor('primary'));
self::assertSame('gcid-a1b2', $design->colorIdFor('nachtblau'));
self::assertSame('gcid-a1b2', $design->colorIdFor('gcid-a1b2'));
self::assertNull($design->colorIdFor('secondary'));
self::assertNull($design->colorIdFor('Alt'));
self::assertSame('gvid-s1', $design->variableFor('telefon'));
self::assertSame('p-2', $design->modulePresetId('divi/button', 'cta PRIMÄR'));
self::assertNull($design->modulePresetId('divi/text', 'Standard'));
self::assertSame(['Standard', 'CTA primär'], $design->modulePresetNames('divi/button'));