Loosen-IT/WP-LIT-MCP
3
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 7 Wiki Activity

feat: deferred 1a items - menu_rev lock, lit_mcp_guides filter, warnings, schedule guard precision

Browse Source 
Task 14 (rulings P17/P18, Q10):
- lit/menu-get returns menu_rev (Rev::ofMenu over id, parent, position,
  title, url, object, object_id); lit/menu-set-items requires it, refuses
  a stale one with rev_mismatch (hint: lit/menu-get) and returns the new
  menu_rev. Errors::revMismatch takes an optional message/hint.
- GuideRepository: filter lit_mcp_guides adds/overrides topics; invalid
  topic names and non-string content are ignored, files stay the default.
- lit/post-trash names front page, posts page and linking menus in the
  confirmation and as warnings; lit/menu-assign-location needs confirm
  to remove an assigned menu and names it; lit/post-schedule warns that
  a private entry becomes public; Divi hints no longer point to
  non-existing lit-divi-* tools.
- PostGuard::missedSchedule: 60 s publish window, zero GMT date falls
  back to get_gmt_from_date(post_date); post-schedule refuses dates
  within that window.
- write_failed after a clean rollback that keeps a revision/backup says
  "Die Aenderung wurde nicht gespeichert (... bleibt erhalten)" via the
  new state parameter (Errors::writeFailed / WriteFailed rolledBackState).
- wp-basis-smoke: menu_rev flow, unassign confirm, trash/menu and
  private-schedule warnings.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01At3V6SjwbMe6eMzVGW3Hs7
This commit is contained in:
janniclas.loosen
2026-09-26 04:33:15 +02:00
co-authored by Claude Opus 5.5
parent 7035448f7d
commit 251934ce53
32 changed files with 700 additions and 98 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/Unit/Integrations/WordPress/Menus/MenuAssignLocationAbilityTest.php
+46 -4
View File
@@ -18,7 +18,11 @@ final class MenuAssignLocationAbilityTest extends TestCase
Functions\when('get_registered_nav_menus')->justReturn(['primary-menu' => 'Hauptmenü']);
Functions\when('get_nav_menu_locations')->justReturn(['primary-menu' => 3]);
Functions\when('wp_get_nav_menu_object')->alias(
static fn (int $id) => $id === 8 ? (object) ['term_id' => 8, 'name' => 'Neu'] : false
static fn (int $id) => match ($id) {
8 => (object) ['term_id' => 8, 'name' => 'Neu'],
3 => (object) ['term_id' => 3, 'name' => 'Hauptmenü'],
default => false,
}
);
}
@@ -42,7 +46,21 @@ final class MenuAssignLocationAbilityTest extends TestCase
self::assertSame(6, $result['log_id']);
}
public function testZeroRemovesTheAssignment(): void
public function testRemovingAnAssignmentNeedsConfirmation(): void
{
Functions\expect('set_theme_mod')->never();
$result = (new MenuAssignLocationAbility(Mockery::mock(ChangeLog::class)))
->execute(['location' => 'primary-menu', 'menu_id' => 0]);
self::assertSame('lit_confirm_required', $result->get_error_code());
self::assertStringContainsString(
'"Hauptmenü" (ID 3)',
json_decode($result->get_error_message(), true)['message']
);
}
public function testZeroRemovesTheAssignmentAndNamesTheRemovedMenu(): void
{
Functions\expect('set_theme_mod')->once()->with('nav_menu_locations', []);
$log = Mockery::mock(ChangeLog::class);
@@ -51,16 +69,40 @@ final class MenuAssignLocationAbilityTest extends TestCase
'lit/menu-assign-location',
'menu_location',
'primary-menu',
'Zuweisung der Position primary-menu entfernt'
'Menü "Hauptmenü" (ID 3) von der Position primary-menu entfernt'
)
->andReturn(7);
$result = (new MenuAssignLocationAbility($log))->execute(['location' => 'primary-menu', 'menu_id' => 0]);
$result = (new MenuAssignLocationAbility($log))
->execute(['location' => 'primary-menu', 'menu_id' => 0, 'confirm' => true]);
self::assertSame('unassigned', $result['changed'][0]['action']);
self::assertSame(3, $result['previous_menu_id']);
self::assertStringContainsString('"Hauptmenü" (ID 3)', $result['summary']);
self::assertSame(7, $result['log_id']);
}
public function testRemovingFromAnEmptyLocationNeedsNoConfirmation(): void
{
Functions\when('get_nav_menu_locations')->justReturn([]);
Functions\expect('set_theme_mod')->once()->with('nav_menu_locations', []);
$log = Mockery::mock(ChangeLog::class);
$log->allows('record')->andReturn(8);
$result = (new MenuAssignLocationAbility($log))->execute(['location' => 'primary-menu', 'menu_id' => 0]);
self::assertTrue($result['ok']);
self::assertNull($result['previous_menu_id']);
}
public function testDescribesTheConfirmationForRemoval(): void
{
$ability = new MenuAssignLocationAbility(Mockery::mock(ChangeLog::class));
self::assertArrayHasKey('confirm', $ability->inputSchema()['properties']);
self::assertStringContainsString('confirm: true', $ability->description());
}
public function testUnknownMenuIsNotFound(): void
{
Functions\expect('set_theme_mod')->never();
tests/Unit/Integrations/WordPress/Menus/MenuReadAbilitiesTest.php
+3
View File
@@ -5,6 +5,7 @@ declare(strict_types=1);
namespace LIT\MCP\Tests\Unit\Integrations\WordPress\Menus;
use Brain\Monkey\Functions;
use LIT\MCP\Abilities\Rev;
use LIT\MCP\Integrations\WordPress\Menus\MenuGetAbility;
use LIT\MCP\Integrations\WordPress\Menus\MenuListAbility;
use LIT\MCP\Tests\Unit\TestCase;
@@ -48,6 +49,8 @@ final class MenuReadAbilitiesTest extends TestCase
self::assertSame('Hauptmenü', $result['name']);
self::assertSame('Start', $result['items'][0]['title']);
self::assertSame(Rev::ofMenu([self::item(10, 0, 'Start')]), $result['menu_rev']);
self::assertContains('menu_rev', $ability->outputSchema()['required']);
self::assertSame('lit_not_found', $ability->execute(['menu_id' => 9])->get_error_code());
}
tests/Unit/Integrations/WordPress/Menus/MenuSetItemsAbilityTest.php
+54 -15
View File
@@ -5,6 +5,7 @@ declare(strict_types=1);
namespace LIT\MCP\Tests\Unit\Integrations\WordPress\Menus;
use Brain\Monkey\Functions;
use LIT\MCP\Abilities\Rev;
use LIT\MCP\Abilities\WriteFailed;
use LIT\MCP\ChangeLog\ChangeLog;
use LIT\MCP\Integrations\WordPress\Menus\MenuOperations;
@@ -26,14 +27,52 @@ final class MenuSetItemsAbilityTest extends TestCase
Functions\when('wp_get_nav_menu_items')->justReturn([self::item(10, 0, 'Home', 'custom', '/')]);
}
/** The menu_rev of the items wp_get_nav_menu_items() currently returns (what lit/menu-get would show). */
private static function rev(): string
{
return Rev::ofMenu(wp_get_nav_menu_items(3));
}
public function testAStaleOrMissingMenuRevIsRefusedAndNothingIsWritten(): void
{
$writer = Mockery::mock(MenuWriter::class);
$writer->expects('apply')->never();
$ability = new MenuSetItemsAbility($writer, new MenuOperations(), Mockery::mock(ChangeLog::class));
$stale = $ability->execute(['menu_id' => 3, 'menu_rev' => 'abcdefabcdef', 'items' => [['id' => 10]]]);
$missing = $ability->execute(['menu_id' => 3, 'items' => [['id' => 10]]]);
self::assertSame('lit_rev_mismatch', $stale->get_error_code());
self::assertStringContainsString('lit/menu-get', $stale->get_error_data()['hint']);
self::assertStringContainsString('Menü', $stale->get_error_message());
self::assertSame('lit_rev_mismatch', $missing->get_error_code());
self::assertContains('menu_rev', $ability->inputSchema()['required']);
self::assertStringContainsString('menu_rev', $ability->description());
}
public function testTheResultCarriesTheNewMenuRev(): void
{
$writer = Mockery::mock(MenuWriter::class);
$writer->allows('plan')->andReturn(['errors' => [], 'removals' => [], 'warnings' => []]);
$writer->allows('apply')->andReturn(['created' => 0, 'updated' => 1, 'removed' => 0]);
$log = Mockery::mock(ChangeLog::class);
$log->allows('record')->andReturn(30);
$result = (new MenuSetItemsAbility($writer, new MenuOperations(), $log))->execute(
['menu_id' => 3, 'menu_rev' => self::rev(), 'items' => [['id' => 10]]]
);
self::assertSame(self::rev(), $result['menu_rev']);
}
public function testItemsAndOperationsAreMutuallyExclusive(): void
{
$ability = new MenuSetItemsAbility(new MenuWriter(), new MenuOperations(), Mockery::mock(ChangeLog::class));
self::assertSame('lit_validation_failed', $ability->execute(['menu_id' => 3])->get_error_code());
self::assertSame('lit_validation_failed', $ability->execute(['menu_id' => 3, 'menu_rev' => self::rev()])->get_error_code());
self::assertSame(
'lit_validation_failed',
$ability->execute(['menu_id' => 3, 'items' => [], 'operations' => [['op' => 'remove', 'id' => 10]]])
$ability->execute(['menu_id' => 3, 'menu_rev' => self::rev(), 'items' => [], 'operations' => [['op' => 'remove', 'id' => 10]]])
->get_error_code()
);
}
@@ -52,7 +91,7 @@ final class MenuSetItemsAbilityTest extends TestCase
Functions\expect('wp_delete_post')->never();
$ability = new MenuSetItemsAbility(new MenuWriter(), new MenuOperations(), Mockery::mock(ChangeLog::class));
$result = $ability->execute(['menu_id' => 3, 'items' => []]);
$result = $ability->execute(['menu_id' => 3, 'menu_rev' => self::rev(), 'items' => []]);
self::assertSame('lit_confirm_required', $result->get_error_code());
self::assertSame([['id' => 10, 'title' => 'Home']], $result->get_error_data()['removals']);
@@ -66,7 +105,7 @@ final class MenuSetItemsAbilityTest extends TestCase
$ability = new MenuSetItemsAbility(new MenuWriter(), new MenuOperations(), Mockery::mock(ChangeLog::class));
$result = $ability->execute([
'menu_id' => 3,
'menu_id' => 3, 'menu_rev' => self::rev(),
'confirm' => true,
'items' => [['id' => 10], ['type' => 'custom', 'url' => 'javascript:alert(1)', 'title' => 'X']],
]);
@@ -81,7 +120,7 @@ final class MenuSetItemsAbilityTest extends TestCase
$writer->expects('apply')->never();
$ability = new MenuSetItemsAbility($writer, new MenuOperations(), Mockery::mock(ChangeLog::class));
$result = $ability->execute(['menu_id' => 3, 'operations' => [['op' => 'move', 'id' => 99]]]);
$result = $ability->execute(['menu_id' => 3, 'menu_rev' => self::rev(), 'operations' => [['op' => 'move', 'id' => 99]]]);
self::assertSame('lit_validation_failed', $result->get_error_code());
}
@@ -95,7 +134,7 @@ final class MenuSetItemsAbilityTest extends TestCase
$log->expects('record')->with('lit/menu-set-items', 'nav_menu', '3', Mockery::type('string'))->andReturn(21);
$result = (new MenuSetItemsAbility($writer, new MenuOperations(), $log))->execute([
'menu_id' => 3,
'menu_id' => 3, 'menu_rev' => self::rev(),
'operations' => [['op' => 'add', 'item' => ['type' => 'custom', 'url' => '/blog', 'title' => 'Blog']]],
]);
@@ -116,7 +155,7 @@ final class MenuSetItemsAbilityTest extends TestCase
$log->allows('record')->andReturn(22);
$result = (new MenuSetItemsAbility($writer, new MenuOperations(), $log))->execute(
['menu_id' => 3, 'items' => [], 'confirm' => true]
['menu_id' => 3, 'menu_rev' => self::rev(), 'items' => [], 'confirm' => true]
);
self::assertSame(10, $result['previous_items'][0]['id']);
@@ -134,7 +173,7 @@ final class MenuSetItemsAbilityTest extends TestCase
$log->expects('record')->never();
$result = (new MenuSetItemsAbility(new MenuWriter(), new MenuOperations(), $log))->execute(
['menu_id' => 3, 'items' => MenuTree::build($items)]
['menu_id' => 3, 'menu_rev' => self::rev(), 'items' => MenuTree::build($items)]
);
self::assertSame('Menü "Hauptmenü": keine Änderung.', $result['summary']);
@@ -151,7 +190,7 @@ final class MenuSetItemsAbilityTest extends TestCase
$ability = new MenuSetItemsAbility($writer, new MenuOperations(), Mockery::mock(ChangeLog::class));
$result = $ability->execute(
['menu_id' => 3, 'items' => [['type' => 'post', 'object_id' => 7]], 'allow_unpublished' => true]
['menu_id' => 3, 'menu_rev' => self::rev(), 'items' => [['type' => 'post', 'object_id' => 7]], 'allow_unpublished' => true]
);
self::assertSame('lit_validation_failed', $result->get_error_code());
@@ -169,7 +208,7 @@ final class MenuSetItemsAbilityTest extends TestCase
$log = Mockery::mock(ChangeLog::class);
$log->allows('record')->andReturn(24);
$ability = new MenuSetItemsAbility(new MenuWriter(), new MenuOperations(), $log);
$input = ['menu_id' => 3, 'operations' => [['op' => 'add', 'item' => ['type' => 'post', 'object_id' => 7]]]];
$input = ['menu_id' => 3, 'menu_rev' => self::rev(), 'operations' => [['op' => 'add', 'item' => ['type' => 'post', 'object_id' => 7]]]];
$refused = $ability->execute($input);
$allowed = $ability->execute($input + ['allow_unpublished' => true]);
@@ -190,7 +229,7 @@ final class MenuSetItemsAbilityTest extends TestCase
$ability = new MenuSetItemsAbility(new MenuWriter(), new MenuOperations(), Mockery::mock(ChangeLog::class));
$result = $ability->execute([
'menu_id' => 3,
'menu_id' => 3, 'menu_rev' => self::rev(),
'allow_unpublished' => true,
'operations' => [['op' => 'add', 'item' => ['type' => 'post', 'object_id' => 7]]],
]);
@@ -209,7 +248,7 @@ final class MenuSetItemsAbilityTest extends TestCase
$ability = new MenuSetItemsAbility($writer, new MenuOperations(), $log);
$this->expectException(WriteFailed::class);
$ability->execute(['menu_id' => 3, 'items' => [['id' => 10]]]);
$ability->execute(['menu_id' => 3, 'menu_rev' => self::rev(), 'items' => [['id' => 10]]]);
}
public function testAPartialWriteIsLoggedAsPartial(): void
@@ -222,7 +261,7 @@ final class MenuSetItemsAbilityTest extends TestCase
$ability = new MenuSetItemsAbility($writer, new MenuOperations(), $log);
$this->expectException(WriteFailed::class);
$ability->execute(['menu_id' => 3, 'items' => [['id' => 10]]]);
$ability->execute(['menu_id' => 3, 'menu_rev' => self::rev(), 'items' => [['id' => 10]]]);
}
public function testAChangeLogFailureIsOnlyAWarning(): void
@@ -237,7 +276,7 @@ final class MenuSetItemsAbilityTest extends TestCase
try {
$result = (new MenuSetItemsAbility($writer, new MenuOperations(), $log))->execute(
['menu_id' => 3, 'items' => [['id' => 10]]]
['menu_id' => 3, 'menu_rev' => self::rev(), 'items' => [['id' => 10]]]
);
} finally {
ini_set('error_log', (string) $errorLog);
@@ -253,7 +292,7 @@ final class MenuSetItemsAbilityTest extends TestCase
Functions\when('current_user_can')->justReturn(false);
$ability = new MenuSetItemsAbility(new MenuWriter(), new MenuOperations(), Mockery::mock(ChangeLog::class));
self::assertSame('lit_forbidden', $ability->permission(['menu_id' => 3])->get_error_code());
self::assertSame('lit_forbidden', $ability->permission(['menu_id' => 3, 'menu_rev' => self::rev()])->get_error_code());
}
public function testIsDestructiveAndDescribesWhenConfirmIsNeeded(): void