feat: deferred 1a items - menu_rev lock, lit_mcp_guides filter, warnings, schedule guard precision

Task 14 (rulings P17/P18, Q10):
- lit/menu-get returns menu_rev (Rev::ofMenu over id, parent, position,
  title, url, object, object_id); lit/menu-set-items requires it, refuses
  a stale one with rev_mismatch (hint: lit/menu-get) and returns the new
  menu_rev. Errors::revMismatch takes an optional message/hint.
- GuideRepository: filter lit_mcp_guides adds/overrides topics; invalid
  topic names and non-string content are ignored, files stay the default.
- lit/post-trash names front page, posts page and linking menus in the
  confirmation and as warnings; lit/menu-assign-location needs confirm
  to remove an assigned menu and names it; lit/post-schedule warns that
  a private entry becomes public; Divi hints no longer point to
  non-existing lit-divi-* tools.
- PostGuard::missedSchedule: 60 s publish window, zero GMT date falls
  back to get_gmt_from_date(post_date); post-schedule refuses dates
  within that window.
- write_failed after a clean rollback that keeps a revision/backup says
  "Die Aenderung wurde nicht gespeichert (... bleibt erhalten)" via the
  new state parameter (Errors::writeFailed / WriteFailed rolledBackState).
- wp-basis-smoke: menu_rev flow, unassign confirm, trash/menu and
  private-schedule warnings.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01At3V6SjwbMe6eMzVGW3Hs7
This commit is contained in:
2026-09-26 04:33:15 +02:00
co-authored by Claude Opus 5.5
parent 7035448f7d
commit 251934ce53
32 changed files with 700 additions and 98 deletions
@@ -231,6 +231,9 @@ final class PostReplaceWithCopyAbilityTest extends TestCase
self::assertTrue($e->rolledBack);
self::assertSame('lit_write_failed', $e->toError()->get_error_code());
self::assertSame(88, $e->toError()->get_error_data()['backup_id']);
$message = $e->toError()->get_error_message();
self::assertStringNotContainsString('Nichts wurde gespeichert', $message);
self::assertStringContainsString('Die Änderung wurde nicht gespeichert (Sicherung 88', $message);
}
}
@@ -54,6 +54,33 @@ final class PostScheduleAbilityTest extends TestCase
self::assertStringContainsString('2099-06-01 09:30', $result['summary']);
}
public function testWarnsThatAPrivatePostBecomesPublic(): void
{
Functions\when('get_post')->justReturn(new WP_Post(['ID' => 5, 'post_type' => 'post', 'post_title' => 'Intern', 'post_status' => 'private']));
Functions\when('wp_update_post')->justReturn(5);
Functions\when('get_post_status')->justReturn('future');
$log = Mockery::mock(ChangeLog::class);
$log->allows('record')->andReturn(4);
$result = $this->ability($log)->execute(['post_id' => 5, 'date' => '2099-06-01 09:30']);
self::assertCount(1, $result['warnings']);
self::assertStringContainsString('öffentlich', $result['warnings'][0]);
self::assertStringContainsString('2099-06-01 09:30', $result['warnings'][0]);
}
public function testADraftGetsNoPrivacyWarning(): void
{
Functions\when('wp_update_post')->justReturn(5);
Functions\when('get_post_status')->justReturn('future');
$log = Mockery::mock(ChangeLog::class);
$log->allows('record')->andReturn(4);
$result = $this->ability($log)->execute(['post_id' => 5, 'date' => '2099-06-01 09:30']);
self::assertSame([], $result['warnings']);
}
public function testAHookThrowingDuringTheWriteIsAPartialWrite(): void
{
Functions\when('wp_update_post')->alias(static function (): void {
@@ -95,4 +122,18 @@ final class PostScheduleAbilityTest extends TestCase
self::assertStringContainsString('Zukunft', $past->get_error_message());
self::assertSame('lit_validation_failed', $impossible->get_error_code());
}
public function testADateWithinTheNextMinuteIsRejectedBecauseWordPressWouldPublishAtOnce(): void
{
Functions\expect('wp_update_post')->never();
// The start of the next minute: always in the future, but at most 60 seconds away.
$soon = (new \DateTimeImmutable('@' . (intdiv(time(), 60) * 60 + 60)))
->setTimezone(new DateTimeZone('Europe/Berlin'));
Functions\when('get_post_status')->justReturn('future');
$result = $this->ability(Mockery::mock(ChangeLog::class))
->execute(['post_id' => 5, 'date' => $soon->format('Y-m-d H:i')]);
self::assertSame('lit_validation_failed', $result->get_error_code());
}
}
@@ -16,6 +16,19 @@ use WP_Post;
final class PostTrashAbilityTest extends TestCase
{
protected function setUp(): void
{
parent::setUp();
$this->options([]);
Functions\when('wp_get_associated_nav_menu_items')->justReturn([]);
}
/** @param array<string, mixed> $options */
private function options(array $options): void
{
Functions\when('get_option')->alias(static fn (string $name, mixed $default = false) => $options[$name] ?? $default);
}
private function ability(ChangeLog $log): PostTrashAbility
{
Functions\when('get_post')->justReturn(new WP_Post(['ID' => 5, 'post_type' => 'page', 'post_title' => 'Alt', 'post_status' => 'publish']));
@@ -93,6 +106,51 @@ final class PostTrashAbilityTest extends TestCase
self::assertStringContainsString('bereits im Papierkorb', $result['summary']);
}
public function testWarnsWhenTrashingTheFrontPageOrThePostsPage(): void
{
$this->options(['show_on_front' => 'page', 'page_on_front' => '5', 'page_for_posts' => '9']);
Functions\when('wp_trash_post')->justReturn(new WP_Post(['ID' => 5]));
$log = Mockery::mock(ChangeLog::class);
$log->allows('record')->andReturn(3);
$ability = $this->ability($log);
$confirm = $ability->execute(['post_id' => 5]);
$result = $ability->execute(['post_id' => 5, 'confirm' => true]);
self::assertStringContainsString('Startseite', $confirm->get_error_message());
self::assertCount(1, $result['warnings']);
self::assertStringContainsString('Startseite', $result['warnings'][0]);
self::assertTrue($result['ok']);
$this->options(['show_on_front' => 'page', 'page_on_front' => '9', 'page_for_posts' => '5']);
self::assertStringContainsString('Beitragsseite', $ability->execute(['post_id' => 5, 'confirm' => true])['warnings'][0]);
$this->options(['show_on_front' => 'posts', 'page_on_front' => '5']);
self::assertSame([], $ability->execute(['post_id' => 5, 'confirm' => true])['warnings']);
}
public function testWarnsAndNamesTheMenusThatLinkThePost(): void
{
Functions\when('wp_get_associated_nav_menu_items')->alias(
static fn (int $id, string $type): array => $id === 5 && $type === 'post_type' ? [40, 41] : []
);
Functions\when('wp_get_object_terms')->alias(
static fn (array $ids, string $taxonomy, array $args): array =>
$ids === [40, 41] && $taxonomy === 'nav_menu' && $args === ['fields' => 'names']
? ['Hauptmenü', 'Footer', 'Hauptmenü']
: []
);
Functions\when('wp_trash_post')->justReturn(new WP_Post(['ID' => 5]));
$log = Mockery::mock(ChangeLog::class);
$log->allows('record')->andReturn(3);
$result = $this->ability($log)->execute(['post_id' => 5, 'confirm' => true]);
self::assertCount(1, $result['warnings']);
self::assertStringContainsString('"Hauptmenü", "Footer"', $result['warnings'][0]);
self::assertSame(1, substr_count($result['warnings'][0], 'Hauptmenü'));
}
public function testIsDestructiveAndIndirect(): void
{
$ability = $this->ability(Mockery::mock(ChangeLog::class));