Loosen-IT/WP-LIT-MCP
3
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 7 Wiki Activity

fix: status tools report a hook throwing during the write as partial_write

Browse Source 
publish/unpublish/schedule/trash run their WordPress call through StatusWrite:
a throwing hook becomes WriteFailed (rollback incomplete, with post_id) and is
logged with result partial instead of surfacing as internal_error.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01At3V6SjwbMe6eMzVGW3Hs7
This commit is contained in:
janniclas.loosen
2026-09-26 01:23:09 +02:00
co-authored by Claude Opus 5.5
parent e57b53d0e5
commit 563d9e8d15
9 changed files with 165 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/Unit/Integrations/WordPress/Status/PostPublishAbilityTest.php
+22
View File
@@ -5,11 +5,13 @@ declare(strict_types=1);
namespace LIT\MCP\Tests\Unit\Integrations\WordPress\Status;
use Brain\Monkey\Functions;
use LIT\MCP\Abilities\WriteFailed;
use LIT\MCP\ChangeLog\ChangeLog;
use LIT\MCP\Integrations\WordPress\Schema\ContentSchema;
use LIT\MCP\Integrations\WordPress\Status\PostPublishAbility;
use LIT\MCP\Tests\Unit\TestCase;
use Mockery;
use RuntimeException;
use WP_Post;
final class PostPublishAbilityTest extends TestCase
@@ -74,6 +76,26 @@ final class PostPublishAbilityTest extends TestCase
self::assertStringContainsString('bereits veröffentlicht', $result['summary']);
}
public function testAHookThrowingDuringTheWriteIsAPartialWrite(): void
{
$this->stubPost(['post_status' => 'draft', 'post_date_gmt' => '0000-00-00 00:00:00']);
Functions\when('wp_update_post')->alias(static function (): void {
throw new RuntimeException('save_post-Hook kaputt');
});
$log = Mockery::mock(ChangeLog::class);
$log->expects('recordPartial')->with('lit/post-publish', 'page', '5', Mockery::type('string'));
try {
$this->ability($log)->execute(['post_id' => 5]);
self::fail('WriteFailed expected');
} catch (WriteFailed $e) {
self::assertFalse($e->rolledBack);
self::assertSame(5, $e->postId);
self::assertStringContainsString('save_post-Hook kaputt', $e->getMessage());
self::assertSame('lit_partial_write', $e->toError()->get_error_code());
}
}
public function testATrashedPostIsRefused(): void
{
$this->stubPost(['post_status' => 'trash']);
tests/Unit/Integrations/WordPress/Status/PostScheduleAbilityTest.php
+21
View File
@@ -6,11 +6,13 @@ namespace LIT\MCP\Tests\Unit\Integrations\WordPress\Status;
use Brain\Monkey\Functions;
use DateTimeZone;
use LIT\MCP\Abilities\WriteFailed;
use LIT\MCP\ChangeLog\ChangeLog;
use LIT\MCP\Integrations\WordPress\Schema\ContentSchema;
use LIT\MCP\Integrations\WordPress\Status\PostScheduleAbility;
use LIT\MCP\Tests\Unit\TestCase;
use Mockery;
use RuntimeException;
use WP_Post;
final class PostScheduleAbilityTest extends TestCase
@@ -52,6 +54,25 @@ final class PostScheduleAbilityTest extends TestCase
self::assertStringContainsString('2099-06-01 09:30', $result['summary']);
}
public function testAHookThrowingDuringTheWriteIsAPartialWrite(): void
{
Functions\when('wp_update_post')->alias(static function (): void {
throw new RuntimeException('save_post-Hook kaputt');
});
$log = Mockery::mock(ChangeLog::class);
$log->expects('recordPartial')->with('lit/post-schedule', 'post', '5', Mockery::type('string'));
try {
$this->ability($log)->execute(['post_id' => 5, 'date' => '2099-06-01 09:30']);
self::fail('WriteFailed expected');
} catch (WriteFailed $e) {
self::assertFalse($e->rolledBack);
self::assertSame(5, $e->postId);
self::assertStringContainsString('save_post-Hook kaputt', $e->getMessage());
self::assertSame('lit_partial_write', $e->toError()->get_error_code());
}
}
public function testATrashedPostIsRefused(): void
{
Functions\when('get_post')->justReturn(new WP_Post(['ID' => 5, 'post_type' => 'post', 'post_status' => 'trash']));
tests/Unit/Integrations/WordPress/Status/PostTrashAbilityTest.php
+21
View File
@@ -5,11 +5,13 @@ declare(strict_types=1);
namespace LIT\MCP\Tests\Unit\Integrations\WordPress\Status;
use Brain\Monkey\Functions;
use LIT\MCP\Abilities\WriteFailed;
use LIT\MCP\ChangeLog\ChangeLog;
use LIT\MCP\Integrations\WordPress\Schema\ContentSchema;
use LIT\MCP\Integrations\WordPress\Status\PostTrashAbility;
use LIT\MCP\Tests\Unit\TestCase;
use Mockery;
use RuntimeException;
use WP_Post;
final class PostTrashAbilityTest extends TestCase
@@ -60,6 +62,25 @@ final class PostTrashAbilityTest extends TestCase
self::assertSame('lit_unsupported', $result->get_error_code());
}
public function testAHookThrowingDuringTheWriteIsAPartialWrite(): void
{
Functions\when('wp_trash_post')->alias(static function (): void {
throw new RuntimeException('save_post-Hook kaputt');
});
$log = Mockery::mock(ChangeLog::class);
$log->expects('recordPartial')->with('lit/post-trash', 'page', '5', Mockery::type('string'));
try {
$this->ability($log)->execute(['post_id' => 5, 'confirm' => true]);
self::fail('WriteFailed expected');
} catch (WriteFailed $e) {
self::assertFalse($e->rolledBack);
self::assertSame(5, $e->postId);
self::assertStringContainsString('save_post-Hook kaputt', $e->getMessage());
self::assertSame('lit_partial_write', $e->toError()->get_error_code());
}
}
public function testAnAlreadyTrashedPostIsANoOp(): void
{
$ability = $this->ability(Mockery::mock(ChangeLog::class));
tests/Unit/Integrations/WordPress/Status/PostUnpublishAbilityTest.php
+21
View File
@@ -5,11 +5,13 @@ declare(strict_types=1);
namespace LIT\MCP\Tests\Unit\Integrations\WordPress\Status;
use Brain\Monkey\Functions;
use LIT\MCP\Abilities\WriteFailed;
use LIT\MCP\ChangeLog\ChangeLog;
use LIT\MCP\Integrations\WordPress\Schema\ContentSchema;
use LIT\MCP\Integrations\WordPress\Status\PostUnpublishAbility;
use LIT\MCP\Tests\Unit\TestCase;
use Mockery;
use RuntimeException;
use WP_Post;
final class PostUnpublishAbilityTest extends TestCase
@@ -37,6 +39,25 @@ final class PostUnpublishAbilityTest extends TestCase
self::assertSame('unpublished', $result['changed'][0]['action']);
}
public function testAHookThrowingDuringTheWriteIsAPartialWrite(): void
{
Functions\when('wp_update_post')->alias(static function (): void {
throw new RuntimeException('save_post-Hook kaputt');
});
$log = Mockery::mock(ChangeLog::class);
$log->expects('recordPartial')->with('lit/post-unpublish', 'page', '5', Mockery::type('string'));
try {
$this->ability($log, 'publish')->execute(['post_id' => 5]);
self::fail('WriteFailed expected');
} catch (WriteFailed $e) {
self::assertFalse($e->rolledBack);
self::assertSame(5, $e->postId);
self::assertStringContainsString('save_post-Hook kaputt', $e->getMessage());
self::assertSame('lit_partial_write', $e->toError()->get_error_code());
}
}
public function testATrashedPostIsRefusedInsteadOfBecomingADraft(): void
{
Functions\expect('wp_update_post')->never();