test: AssertsToolErrors helper for tool error assertions (T3)

tests/Support/AssertsToolErrors (used by TestCase): assertToolError($result, code)
checks the WP_Error code lit_<code> and the code of the client JSON and returns the
payload; clientError() decodes the payload; errorFields() returns the fields and
asserts they exist. Replaces the private clientError() decoders of
DiviWriteAbilitiesTest/DiviReplaceTextAbilityTest, 216 single-line
assertSame('lit_…', …->get_error_code()) assertions, 24 get_error_data()['fields']
digs and two json_decode(message) reads. ErrorsTest keeps json_decode: it tests
the format itself. Tests 1404 -> 1409 (AssertsToolErrorsTest); no test has fewer
assertions.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This commit is contained in:
2026-09-26 17:55:35 +02:00
co-authored by Claude Opus 5.5
parent 72eeaa46ad
commit 60290c85a5
50 changed files with 337 additions and 256 deletions
+4 -4
View File
@@ -18,7 +18,7 @@ final class WriteFailedTest extends TestCase
self::assertTrue($failure->rolledBack);
self::assertSame($cause, $failure->getPrevious());
self::assertStringContainsString('meta kaputt', $failure->getMessage());
self::assertSame('lit_write_failed', $failure->toError()->get_error_code());
self::assertToolError($failure->toError(), 'write_failed');
}
public function testRolledBackHintReplacesTheDefaultHintOfWriteFailedOnly(): void
@@ -35,7 +35,7 @@ final class WriteFailedTest extends TestCase
{
$error = WriteFailed::partial('Felder konnten nicht gespeichert werden.', postId: 5, revisionId: 811)->toError();
self::assertSame('lit_partial_write', $error->get_error_code());
self::assertToolError($error, 'partial_write');
self::assertSame(5, $error->get_error_data()['post_id']);
self::assertSame(811, $error->get_error_data()['revision_id']);
}
@@ -49,7 +49,7 @@ final class WriteFailedTest extends TestCase
details: ['menu_id' => 3]
)->toError();
self::assertSame('lit_partial_write', $error->get_error_code());
self::assertToolError($error, 'partial_write');
self::assertStringContainsString('Das Menü ist teilweise geändert.', $error->get_error_message());
self::assertStringNotContainsString('Entwurf', $error->get_error_message());
self::assertSame('Mit lit/menu-get prüfen.', $error->get_error_data()['hint']);
@@ -71,7 +71,7 @@ final class WriteFailedTest extends TestCase
{
$error = WriteFailed::rolledBack('Nicht übernommen.', details: ['backup_id' => 88])->toError();
self::assertSame('lit_write_failed', $error->get_error_code());
self::assertToolError($error, 'write_failed');
self::assertSame(88, $error->get_error_data()['backup_id']);
self::assertStringContainsString('"backup_id":88', $error->get_error_message());
}