Loosen-IT/WP-LIT-MCP
3
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 7 Wiki Activity

test: AssertsToolErrors helper for tool error assertions (T3)

Browse Source 
tests/Support/AssertsToolErrors (used by TestCase): assertToolError($result, code)
checks the WP_Error code lit_<code> and the code of the client JSON and returns the
payload; clientError() decodes the payload; errorFields() returns the fields and
asserts they exist. Replaces the private clientError() decoders of
DiviWriteAbilitiesTest/DiviReplaceTextAbilityTest, 216 single-line
assertSame('lit_…', …->get_error_code()) assertions, 24 get_error_data()['fields']
digs and two json_decode(message) reads. ErrorsTest keeps json_decode: it tests
the format itself. Tests 1404 -> 1409 (AssertsToolErrorsTest); no test has fewer
assertions.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This commit is contained in:
janniclas.loosen
2026-09-26 17:55:35 +02:00
co-authored by Claude Opus 5.5
parent 72eeaa46ad
commit 60290c85a5
50 changed files with 337 additions and 256 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/Unit/Integrations/Media/MediaDeleteAbilityTest.php
+10 -10
View File
@@ -41,7 +41,7 @@ final class MediaDeleteAbilityTest extends TestCase
$result = $this->ability(self::USAGE, FakeChangeLog::forbidden())->execute(['id' => 33]);
self::assertSame('lit_confirm_required', $result->get_error_code());
self::assertToolError($result, 'confirm_required');
self::assertStringContainsString('endgültig', $result->get_error_message());
self::assertStringContainsString('1 Stelle', $result->get_error_message());
self::assertSame(self::USAGE, $result->get_error_data()['usages']);
@@ -51,7 +51,7 @@ final class MediaDeleteAbilityTest extends TestCase
{
$result = $this->ability([], FakeChangeLog::forbidden(), true)->execute(['id' => 33, 'confirm' => false]);
self::assertSame('lit_confirm_required', $result->get_error_code());
self::assertToolError($result, 'confirm_required');
self::assertStringContainsString('Papierkorb', $result->get_error_message());
}
@@ -61,7 +61,7 @@ final class MediaDeleteAbilityTest extends TestCase
$result = $this->ability(self::USAGE, FakeChangeLog::forbidden())->execute(['id' => 33, 'confirm' => true]);
self::assertSame('lit_in_use', $result->get_error_code());
self::assertToolError($result, 'in_use');
self::assertSame(self::USAGE, $result->get_error_data()['usages']);
}
@@ -71,7 +71,7 @@ final class MediaDeleteAbilityTest extends TestCase
$result = $this->ability(self::POSSIBLE, FakeChangeLog::forbidden())->execute(['id' => 33, 'confirm' => true]);
self::assertSame('lit_in_use', $result->get_error_code());
self::assertToolError($result, 'in_use');
}
public function testForceDeletesUsedMedia(): void
@@ -115,7 +115,7 @@ final class MediaDeleteAbilityTest extends TestCase
$result = $this->ability([], FakeChangeLog::forbidden())->execute(['id' => 33, 'confirm' => true]);
self::assertSame('lit_write_failed', $result->get_error_code());
self::assertToolError($result, 'write_failed');
}
public function testRefusedDeleteThatRemovedDataIsAPartialWrite(): void
@@ -133,7 +133,7 @@ final class MediaDeleteAbilityTest extends TestCase
$result = $this->ability([], $log)->execute(['id' => 33, 'confirm' => true]);
self::assertSame('lit_partial_write', $result->get_error_code());
self::assertToolError($result, 'partial_write');
self::assertSame(33, $result->get_error_data()['attachment_id']);
$log->assertPartials(['ability' => 'lit/media-delete', 'object_type' => 'attachment', 'object_id' => '33']);
}
@@ -162,7 +162,7 @@ final class MediaDeleteAbilityTest extends TestCase
unlink($file);
}
self::assertSame('lit_in_use', $result->get_error_code());
self::assertToolError($result, 'in_use');
self::assertSame(MediaUsageFinder::FAILED_TITLE, $result->get_error_data()['usages'][0]['title']);
}
@@ -193,8 +193,8 @@ final class MediaDeleteAbilityTest extends TestCase
$ability = $this->ability([], FakeChangeLog::forbidden());
self::assertSame('lit_validation_failed', $ability->permission(['id' => 33])->get_error_code());
self::assertSame('lit_validation_failed', $ability->execute(['id' => 33, 'confirm' => true])->get_error_code());
self::assertToolError($ability->permission(['id' => 33]), 'validation_failed');
self::assertToolError($ability->execute(['id' => 33, 'confirm' => true]), 'validation_failed');
}
public function testChecksDeletePostOnTheAttachment(): void
@@ -203,7 +203,7 @@ final class MediaDeleteAbilityTest extends TestCase
$result = $this->ability([], FakeChangeLog::forbidden())->permission(['id' => 33]);
self::assertSame('lit_forbidden', $result->get_error_code());
self::assertToolError($result, 'forbidden');
}
public function testIsDestructiveAndDescribesWhatTheUsageCheckMisses(): void
tests/Unit/Integrations/Media/MediaDownloadAbilityTest.php
+4 -4
View File
@@ -59,7 +59,7 @@ final class MediaDownloadAbilityTest extends TestCase
$result = (new MediaDownloadAbility(new Limits()))->execute(['id' => 40]);
self::assertSame('lit_unsupported', $result->get_error_code());
self::assertToolError($result, 'unsupported');
}
public function testDownloadsAreCappedAtTenMegabytesEvenWithAHigherUploadLimit(): void
@@ -69,7 +69,7 @@ final class MediaDownloadAbilityTest extends TestCase
$result = (new MediaDownloadAbility(new Limits()))->execute(['id' => 40]);
self::assertSame('lit_unsupported', $result->get_error_code());
self::assertToolError($result, 'unsupported');
self::assertStringContainsString('Limit 10 MB', $result->get_error_message());
self::assertStringContainsString('URL', (string) $result->get_error_data()['hint']);
}
@@ -81,7 +81,7 @@ final class MediaDownloadAbilityTest extends TestCase
$result = (new MediaDownloadAbility(new Limits()))->execute(['id' => 40, 'size' => 'huge']);
self::assertSame('lit_not_found', $result->get_error_code());
self::assertToolError($result, 'not_found');
self::assertNull((new MediaDownloadAbility(new Limits()))->outputSchema());
}
@@ -92,6 +92,6 @@ final class MediaDownloadAbilityTest extends TestCase
$result = (new MediaDownloadAbility(new Limits()))->execute(['id' => 40]);
self::assertSame('lit_not_found', $result->get_error_code());
self::assertToolError($result, 'not_found');
}
}
tests/Unit/Integrations/Media/MediaGetAbilityTest.php
+1 -1
View File
@@ -45,7 +45,7 @@ final class MediaGetAbilityTest extends TestCase
Functions\when('get_post')->justReturn(new WP_Post(['ID' => 5, 'post_type' => 'page']));
$ability = new MediaGetAbility(Mockery::mock(MediaPresenter::class), Mockery::mock(MediaUsageFinder::class));
self::assertSame('lit_not_found', $ability->permission(['id' => 5])->get_error_code());
self::assertToolError($ability->permission(['id' => 5]), 'not_found');
}
public function testIsIndirectAndReadonly(): void
tests/Unit/Integrations/Media/MediaGuardTest.php
+6 -6
View File
@@ -13,17 +13,17 @@ final class MediaGuardTest extends TestCase
{
public function testInvalidIdIsAValidationError(): void
{
self::assertSame('lit_validation_failed', MediaGuard::attachment('abc')->get_error_code());
self::assertSame('lit_validation_failed', MediaGuard::attachment(0)->get_error_code());
self::assertToolError(MediaGuard::attachment('abc'), 'validation_failed');
self::assertToolError(MediaGuard::attachment(0), 'validation_failed');
}
public function testMissingOrNonAttachmentIsNotFound(): void
{
Functions\when('get_post')->justReturn(null);
self::assertSame('lit_not_found', MediaGuard::attachment(33)->get_error_code());
self::assertToolError(MediaGuard::attachment(33), 'not_found');
Functions\when('get_post')->justReturn(new WP_Post(['ID' => 33, 'post_type' => 'page']));
self::assertSame('lit_not_found', MediaGuard::attachment(33)->get_error_code());
self::assertToolError(MediaGuard::attachment(33), 'not_found');
}
public function testChecksTheRequestedCapabilityOnTheAttachment(): void
@@ -32,7 +32,7 @@ final class MediaGuardTest extends TestCase
Functions\when('get_post')->justReturn($attachment);
Functions\expect('current_user_can')->once()->with('delete_post', 33)->andReturn(false);
self::assertSame('lit_forbidden', MediaGuard::attachment('33', 'delete_post')->get_error_code());
self::assertToolError(MediaGuard::attachment('33', 'delete_post'), 'forbidden');
}
public function testRefusesTrashedAttachmentsUnlessAllowed(): void
@@ -42,7 +42,7 @@ final class MediaGuardTest extends TestCase
Functions\when('current_user_can')->justReturn(true);
$error = MediaGuard::attachment(33);
self::assertSame('lit_validation_failed', $error->get_error_code());
self::assertToolError($error, 'validation_failed');
self::assertStringContainsString('Papierkorb', $error->get_error_message());
self::assertSame($attachment, MediaGuard::attachment(33, 'read_post', true));
}
tests/Unit/Integrations/Media/MediaImporterTest.php
+17 -17
View File
@@ -136,7 +136,7 @@ final class MediaImporterTest extends TestCase
{
$result = $this->importer()->fromBase64(str_repeat('A', 2 * 1024 * 1024), 'big.png', []);
self::assertSame('lit_validation_failed', $result->get_error_code());
self::assertToolError($result, 'validation_failed');
self::assertStringContainsString('Limit 1 MB', $result->get_error_message());
self::assertSame([], $this->tempFiles, 'no temp file may be written for an oversized upload');
}
@@ -147,7 +147,7 @@ final class MediaImporterTest extends TestCase
$result = $this->importer()->fromBase64(str_repeat('A', 16 * 1024 * 1024), 'big.png', []);
self::assertSame('lit_validation_failed', $result->get_error_code());
self::assertToolError($result, 'validation_failed');
self::assertStringContainsString('Limit 10 MB', $result->get_error_message());
self::assertStringContainsString('lit/media-upload-from-url', (string) $result->get_error_data()['hint']);
self::assertSame([], $this->tempFiles);
@@ -157,7 +157,7 @@ final class MediaImporterTest extends TestCase
{
$result = $this->importer()->fromBase64('***', 'x.png', []);
self::assertSame('lit_validation_failed', $result->get_error_code());
self::assertToolError($result, 'validation_failed');
self::assertSame([], $this->tempFiles);
}
@@ -168,7 +168,7 @@ final class MediaImporterTest extends TestCase
$result = $this->importer()->fromBase64(base64_encode('<?php evil();'), 'bild.png', []);
self::assertSame('lit_validation_failed', $result->get_error_code());
self::assertToolError($result, 'validation_failed');
self::assertNotSame([], $this->tempFiles);
$this->assertTempFilesRemoved();
}
@@ -182,7 +182,7 @@ final class MediaImporterTest extends TestCase
$result = $this->importer()->fromBase64(base64_encode('PNGDATA'), 'logo.png', []);
self::assertSame('lit_validation_failed', $result->get_error_code());
self::assertToolError($result, 'validation_failed');
self::assertStringContainsString('png', $result->get_error_message());
}
@@ -198,7 +198,7 @@ final class MediaImporterTest extends TestCase
$result = $this->importer()->fromBase64(base64_encode('PNGDATA'), 'logo.png', []);
$logged = (string) file_get_contents($this->errorLog);
self::assertSame('lit_write_failed', $result->get_error_code());
self::assertToolError($result, 'write_failed');
self::assertStringNotContainsString('/var/www', $result->get_error_message());
self::assertStringNotContainsString('/var/www', (string) json_encode($result->get_error_data()));
self::assertStringContainsString('WordPress hat die Datei nicht übernommen', $result->get_error_message());
@@ -238,7 +238,7 @@ final class MediaImporterTest extends TestCase
self::fail('WriteFailed expected');
} catch (WriteFailed $e) {
self::assertTrue($e->rolledBack);
self::assertSame('lit_write_failed', $e->toError()->get_error_code());
self::assertToolError($e->toError(), 'write_failed');
}
$this->assertTempFilesRemoved();
}
@@ -258,7 +258,7 @@ final class MediaImporterTest extends TestCase
self::assertFalse($e->rolledBack);
self::assertSame(55, $e->postId);
$error = $e->toError();
self::assertSame('lit_partial_write', $error->get_error_code());
self::assertToolError($error, 'partial_write');
self::assertStringContainsString('Medium 55', $error->get_error_message());
self::assertSame(55, $error->get_error_data()['attachment_id']);
}
@@ -282,7 +282,7 @@ final class MediaImporterTest extends TestCase
$result = $this->importer()->fromUrl('http://127.0.0.1/wp-config.php', null, []);
self::assertSame('lit_validation_failed', $result->get_error_code());
self::assertToolError($result, 'validation_failed');
}
public function testOnlyHttpUrlsAreFetched(): void
@@ -292,7 +292,7 @@ final class MediaImporterTest extends TestCase
$result = $this->importer()->fromUrl('ftp://example.com/logo.png', null, []);
self::assertSame('lit_validation_failed', $result->get_error_code());
self::assertToolError($result, 'validation_failed');
}
public function testUrlImportDownloadsSafelyWithTheSizeLimit(): void
@@ -332,7 +332,7 @@ final class MediaImporterTest extends TestCase
$result = $this->importer()->fromUrl('https://example.com/fehlt.jpg', null, []);
self::assertSame('lit_validation_failed', $result->get_error_code());
self::assertToolError($result, 'validation_failed');
self::assertStringContainsString('Not Found', $result->get_error_message());
$this->assertTempFilesRemoved();
}
@@ -344,7 +344,7 @@ final class MediaImporterTest extends TestCase
$result = $this->importer()->fromUrl('https://example.com/fehlt.jpg', null, []);
self::assertSame('lit_validation_failed', $result->get_error_code());
self::assertToolError($result, 'validation_failed');
self::assertStringContainsString('404', $result->get_error_message());
$this->assertTempFilesRemoved();
}
@@ -356,7 +356,7 @@ final class MediaImporterTest extends TestCase
$result = $this->importer()->fromUrl('https://example.com/gross.jpg', null, []);
self::assertSame('lit_validation_failed', $result->get_error_code());
self::assertToolError($result, 'validation_failed');
self::assertStringContainsString('Limit 1 MB', $result->get_error_message());
$this->assertTempFilesRemoved();
}
@@ -368,7 +368,7 @@ final class MediaImporterTest extends TestCase
$result = $this->importer()->fromUrl('https://example.com/gross.jpg', null, []);
self::assertSame('lit_validation_failed', $result->get_error_code());
self::assertToolError($result, 'validation_failed');
self::assertStringContainsString('Limit 1 MB', $result->get_error_message());
$this->assertTempFilesRemoved();
}
@@ -396,7 +396,7 @@ final class MediaImporterTest extends TestCase
$result = $this->importer()->fromBase64(base64_encode('<html></html>'), 'seite.html', []);
self::assertSame('lit_validation_failed', $result->get_error_code());
self::assertToolError($result, 'validation_failed');
$this->assertTempFilesRemoved();
}
@@ -416,7 +416,7 @@ final class MediaImporterTest extends TestCase
$result = $this->importer()->fromBase64(base64_encode('PNGDATA'), 'logo.png', []);
self::assertSame('lit_write_failed', $result->get_error_code());
self::assertToolError($result, 'write_failed');
self::assertFileDoesNotExist($moved);
self::assertFalse(has_filter('wp_handle_upload'));
}
@@ -462,6 +462,6 @@ final class MediaImporterTest extends TestCase
$result = $this->importer()->fromUrl('https://example.com/logo.png', null, []);
self::assertSame('lit_write_failed', $result->get_error_code());
self::assertToolError($result, 'write_failed');
}
}
tests/Unit/Integrations/Media/MediaPreviewAbilityTest.php
+2 -2
View File
@@ -68,7 +68,7 @@ final class MediaPreviewAbilityTest extends TestCase
$result = (new MediaPreviewAbility())->execute(['id' => 33]);
self::assertSame('lit_unsupported', $result->get_error_code());
self::assertToolError($result, 'unsupported');
self::assertStringContainsString(
'lit/media-download (direkt: lit-media-download)',
(string) $result->get_error_data()['hint']
@@ -82,7 +82,7 @@ final class MediaPreviewAbilityTest extends TestCase
$result = (new MediaPreviewAbility())->execute(['id' => 33]);
self::assertSame('lit_not_found', $result->get_error_code());
self::assertToolError($result, 'not_found');
}
public function testIsADirectToolWithoutOutputSchema(): void
tests/Unit/Integrations/Media/MediaSearchAbilityTest.php
+3 -3
View File
@@ -68,7 +68,7 @@ final class MediaSearchAbilityTest extends TestCase
$result = (new MediaSearchAbility($this->presenter(), Mockery::mock(MediaUsageFinder::class)))
->execute(['missing_alt' => true, 'mime' => 'application/pdf']);
self::assertSame('lit_validation_failed', $result->get_error_code());
self::assertToolError($result, 'validation_failed');
}
public function testMissingAltAllowsAnImageSubtypeMime(): void
@@ -108,7 +108,7 @@ final class MediaSearchAbilityTest extends TestCase
$result = (new MediaSearchAbility($this->presenter(), Mockery::mock(MediaUsageFinder::class)))
->execute(['cursor' => '???']);
self::assertSame('lit_validation_failed', $result->get_error_code());
self::assertToolError($result, 'validation_failed');
}
public function testExcludesAttachmentsTheUserCannotEdit(): void
@@ -303,7 +303,7 @@ final class MediaSearchAbilityTest extends TestCase
Functions\when('current_user_can')->justReturn(false);
$ability = new MediaSearchAbility($this->presenter(), Mockery::mock(MediaUsageFinder::class));
self::assertSame('lit_forbidden', $ability->permission([])->get_error_code());
self::assertToolError($ability->permission([]), 'forbidden');
self::assertTrue($ability->isDirect());
}
}
tests/Unit/Integrations/Media/MediaUpdateAbilityTest.php
+5 -5
View File
@@ -92,7 +92,7 @@ final class MediaUpdateAbilityTest extends TestCase
]]);
self::assertInstanceOf(WP_Error::class, $result);
self::assertSame('lit_validation_failed', $result->get_error_code());
self::assertToolError($result, 'validation_failed');
self::assertStringContainsString('3 von 4', $result->get_error_message());
self::assertStringContainsString('nichts wurde gespeichert', $result->get_error_message());
$failures = $result->get_error_data()['failures'];
@@ -109,7 +109,7 @@ final class MediaUpdateAbilityTest extends TestCase
{
$result = (new MediaUpdateAbility($this->log()))->execute(['items' => [['id' => '99', 'alt' => 'x']]]);
self::assertSame('lit_not_found', $result->get_error_code());
self::assertToolError($result, 'not_found');
self::assertSame(99, $result->get_error_data()['failures'][0]['id']);
}
@@ -138,7 +138,7 @@ final class MediaUpdateAbilityTest extends TestCase
['id' => 34, 'alt' => 'neu', 'modified' => '2026-09-24 07:00:00'],
]]);
self::assertSame('lit_rev_mismatch', $result->get_error_code());
self::assertToolError($result, 'rev_mismatch');
self::assertSame(1, $result->get_error_data()['failures'][0]['index']);
self::assertStringContainsString('lit/media-get', $result->get_error_data()['hint']);
self::assertSame([], $this->altUpdates);
@@ -162,7 +162,7 @@ final class MediaUpdateAbilityTest extends TestCase
self::fail('WriteFailed expected');
} catch (WriteFailed $e) {
self::assertTrue($e->rolledBack);
self::assertSame('lit_write_failed', $e->toError()->get_error_code());
self::assertToolError($e->toError(), 'write_failed');
self::assertStringContainsString('neu lesen', $e->toError()->get_error_data()['hint']);
self::assertStringContainsString('Datenbankfehler', $e->getMessage());
}
@@ -232,7 +232,7 @@ final class MediaUpdateAbilityTest extends TestCase
self::fail('WriteFailed expected');
} catch (WriteFailed $e) {
$error = $e->toError();
self::assertSame('lit_partial_write', $error->get_error_code());
self::assertToolError($error, 'partial_write');
self::assertSame([33], $error->get_error_data()['changed_ids']);
self::assertStringContainsString('33', $error->get_error_message());
}
tests/Unit/Integrations/Media/MediaUploadAbilitiesTest.php
+4 -4
View File
@@ -106,7 +106,7 @@ final class MediaUploadAbilitiesTest extends TestCase
$result = (new MediaUploadAbility($importer, $this->uploads(), new Limits()))
->execute(['filename' => 'x.png', 'data' => 'AAAA']);
self::assertSame('lit_validation_failed', $result->get_error_code());
self::assertToolError($result, 'validation_failed');
}
public function testAPartialUploadIsLoggedAsPartialAndRethrown(): void
@@ -136,7 +136,7 @@ final class MediaUploadAbilitiesTest extends TestCase
$ability = new MediaUploadFromUrlAbility(Mockery::mock(MediaImporter::class), $this->uploads());
self::assertTrue($ability->permission(['url' => 'https://example.com/a.png']));
self::assertSame('lit_forbidden', $ability->permission(['url' => 'https://example.com/a.png', 'post_id' => 5])->get_error_code());
self::assertToolError($ability->permission(['url' => 'https://example.com/a.png', 'post_id' => 5]), 'forbidden');
}
public function testPermissionRefusesUsersWithoutUploadRights(): void
@@ -144,7 +144,7 @@ final class MediaUploadAbilitiesTest extends TestCase
Functions\when('current_user_can')->justReturn(false);
$ability = new MediaUploadAbility(Mockery::mock(MediaImporter::class), $this->uploads(), new Limits());
self::assertSame('lit_forbidden', $ability->permission(['filename' => 'a.png', 'data' => 'AAAA'])->get_error_code());
self::assertToolError($ability->permission(['filename' => 'a.png', 'data' => 'AAAA']), 'forbidden');
}
public function testUploadsForAParentThatDoesNotExistAreRefused(): void
@@ -153,7 +153,7 @@ final class MediaUploadAbilitiesTest extends TestCase
Functions\when('get_post')->justReturn(null);
$ability = new MediaUploadAbility(Mockery::mock(MediaImporter::class), $this->uploads(), new Limits());
self::assertSame('lit_not_found', $ability->permission(['filename' => 'a.png', 'data' => 'AAAA', 'post_id' => 9])->get_error_code());
self::assertToolError($ability->permission(['filename' => 'a.png', 'data' => 'AAAA', 'post_id' => 9]), 'not_found');
}
public function testDescriptionNamesTheConfiguredLimit(): void