test: AssertsToolErrors helper for tool error assertions (T3)
tests/Support/AssertsToolErrors (used by TestCase): assertToolError($result, code)
checks the WP_Error code lit_<code> and the code of the client JSON and returns the
payload; clientError() decodes the payload; errorFields() returns the fields and
asserts they exist. Replaces the private clientError() decoders of
DiviWriteAbilitiesTest/DiviReplaceTextAbilityTest, 216 single-line
assertSame('lit_…', …->get_error_code()) assertions, 24 get_error_data()['fields']
digs and two json_decode(message) reads. ErrorsTest keeps json_decode: it tests
the format itself. Tests 1404 -> 1409 (AssertsToolErrorsTest); no test has fewer
assertions.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This commit is contained in:
@@ -59,7 +59,7 @@ final class MediaDownloadAbilityTest extends TestCase
|
||||
|
||||
$result = (new MediaDownloadAbility(new Limits()))->execute(['id' => 40]);
|
||||
|
||||
self::assertSame('lit_unsupported', $result->get_error_code());
|
||||
self::assertToolError($result, 'unsupported');
|
||||
}
|
||||
|
||||
public function testDownloadsAreCappedAtTenMegabytesEvenWithAHigherUploadLimit(): void
|
||||
@@ -69,7 +69,7 @@ final class MediaDownloadAbilityTest extends TestCase
|
||||
|
||||
$result = (new MediaDownloadAbility(new Limits()))->execute(['id' => 40]);
|
||||
|
||||
self::assertSame('lit_unsupported', $result->get_error_code());
|
||||
self::assertToolError($result, 'unsupported');
|
||||
self::assertStringContainsString('Limit 10 MB', $result->get_error_message());
|
||||
self::assertStringContainsString('URL', (string) $result->get_error_data()['hint']);
|
||||
}
|
||||
@@ -81,7 +81,7 @@ final class MediaDownloadAbilityTest extends TestCase
|
||||
|
||||
$result = (new MediaDownloadAbility(new Limits()))->execute(['id' => 40, 'size' => 'huge']);
|
||||
|
||||
self::assertSame('lit_not_found', $result->get_error_code());
|
||||
self::assertToolError($result, 'not_found');
|
||||
self::assertNull((new MediaDownloadAbility(new Limits()))->outputSchema());
|
||||
}
|
||||
|
||||
@@ -92,6 +92,6 @@ final class MediaDownloadAbilityTest extends TestCase
|
||||
|
||||
$result = (new MediaDownloadAbility(new Limits()))->execute(['id' => 40]);
|
||||
|
||||
self::assertSame('lit_not_found', $result->get_error_code());
|
||||
self::assertToolError($result, 'not_found');
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user