test: AssertsToolErrors helper for tool error assertions (T3)

tests/Support/AssertsToolErrors (used by TestCase): assertToolError($result, code)
checks the WP_Error code lit_<code> and the code of the client JSON and returns the
payload; clientError() decodes the payload; errorFields() returns the fields and
asserts they exist. Replaces the private clientError() decoders of
DiviWriteAbilitiesTest/DiviReplaceTextAbilityTest, 216 single-line
assertSame('lit_…', …->get_error_code()) assertions, 24 get_error_data()['fields']
digs and two json_decode(message) reads. ErrorsTest keeps json_decode: it tests
the format itself. Tests 1404 -> 1409 (AssertsToolErrorsTest); no test has fewer
assertions.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This commit is contained in:
2026-09-26 17:55:35 +02:00
co-authored by Claude Opus 5.5
parent 72eeaa46ad
commit 60290c85a5
50 changed files with 337 additions and 256 deletions
@@ -76,7 +76,7 @@ final class ContentCreateAbilityTest extends TestCase
$result = (new ContentCreateAbility($this->schema(), $writer, FakeChangeLog::forbidden()))
->execute(['post_type' => 'lit_person', 'title' => 'Anna']);
self::assertSame('lit_validation_failed', $result->get_error_code());
self::assertToolError($result, 'validation_failed');
}
public function testCreatesADraftWritesExtrasLogsAndReturnsAToolResult(): void
@@ -131,7 +131,7 @@ final class ContentCreateAbilityTest extends TestCase
self::assertTrue($failure->rolledBack);
self::assertStringContainsString('Pods could not save the fields.', $failure->getMessage());
self::assertSame('lit_write_failed', $failure->toError()->get_error_code());
self::assertToolError($failure->toError(), 'write_failed');
}
public function testMetaFieldsTheUserMayNotAddAreRefusedAndTheDraftIsRemoved(): void
@@ -149,8 +149,8 @@ final class ContentCreateAbilityTest extends TestCase
$result = (new ContentCreateAbility($this->schema(), $writer, $log))->execute(self::INPUT);
self::assertSame('lit_validation_failed', $result->get_error_code());
self::assertArrayHasKey('fields.city', $result->get_error_data()['fields']);
self::assertToolError($result, 'validation_failed');
self::assertArrayHasKey('fields.city', self::errorFields($result));
}
public function testARefusedDraftThatCannotBeDeletedIsAPartialWrite(): void
@@ -219,7 +219,7 @@ final class ContentCreateAbilityTest extends TestCase
self::assertFalse($failure->rolledBack);
self::assertNull($failure->postId);
self::assertSame('lit_partial_write', $failure->toError()->get_error_code());
self::assertToolError($failure->toError(), 'partial_write');
$log->assertPartials(['ability' => 'lit/content-create', 'object_type' => 'lit_person', 'object_id' => '']);
}
@@ -261,6 +261,6 @@ final class ContentCreateAbilityTest extends TestCase
self::assertTrue($ability->permission(['post_type' => 'page']));
Functions\when('current_user_can')->justReturn(false);
self::assertSame('lit_forbidden', $ability->permission(['post_type' => 'page'])->get_error_code());
self::assertToolError($ability->permission(['post_type' => 'page']), 'forbidden');
}
}
@@ -128,14 +128,14 @@ final class ContentCreateDiviTest extends TestCase
Functions\expect('wp_insert_post')->never();
$inactive = $this->ability($this->composer(false))->execute(self::INPUT);
self::assertSame('lit_unsupported', $inactive->get_error_code());
self::assertToolError($inactive, 'unsupported');
$none = $this->ability(null)->execute(self::INPUT);
self::assertSame('lit_unsupported', $none->get_error_code());
self::assertToolError($none, 'unsupported');
$both = $this->ability($this->composer())->execute(self::INPUT + ['content' => '<p>x</p>']);
self::assertSame('lit_validation_failed', $both->get_error_code());
self::assertArrayHasKey('content', $both->get_error_data()['fields']);
self::assertToolError($both, 'validation_failed');
self::assertArrayHasKey('content', self::errorFields($both));
}
public function testEveryValidationErrorComesBackAndNothingIsCreated(): void
@@ -149,10 +149,10 @@ final class ContentCreateDiviTest extends TestCase
$error = $this->ability($composer, $writer)->execute(self::INPUT);
self::assertSame('lit_invalid_attr_path', $error->get_error_code());
self::assertToolError($error, 'invalid_attr_path');
self::assertSame(
['fields.role' => 'Pflichtfeld fehlt.', 'divi[0].attrs.x' => 'unbekannt'],
$error->get_error_data()['fields']
self::errorFields($error)
);
}
@@ -181,8 +181,8 @@ final class ContentCreateDiviTest extends TestCase
$error = $this->ability($composer)->execute(self::INPUT);
self::assertInstanceOf(WP_Error::class, $error);
self::assertSame('lit_validation_failed', $error->get_error_code());
self::assertArrayHasKey('divi[0].modules[0].text', $error->get_error_data()['fields']);
self::assertToolError($error, 'validation_failed');
self::assertArrayHasKey('divi[0].modules[0].text', self::errorFields($error));
}
public function testARefusedLayoutWhoseDraftCannotBeDeletedIsAPartialWrite(): void
@@ -254,8 +254,8 @@ final class ContentCreateDiviTest extends TestCase
'attrs' => ['module.meta.adminLabel' => ['desktop' => 'Lang']],
'modules' => [['type' => 'button', 'text' => 'Los', 'attrs' => ['button.innerContent' => ['desktop' => ['text' => 'x']]]]],
]]]);
self::assertSame('lit_validation_failed', $overlap->get_error_code());
$fields = $overlap->get_error_data()['fields'];
self::assertToolError($overlap, 'validation_failed');
$fields = self::errorFields($overlap);
self::assertArrayHasKey('divi[0].attrs.module.meta.adminLabel', $fields, 'S41: label and attrs label');
self::assertArrayHasKey('divi[0].modules[0].modules[0][0].attrs.button.innerContent', $fields, 'S40');
self::assertSame([], $saved);
@@ -47,7 +47,7 @@ final class ContentGetAbilityTest extends TestCase
$schema = Mockery::mock(ContentSchema::class);
$ability = new ContentGetAbility($schema, Mockery::mock(PostPresenter::class));
self::assertSame('lit_not_found', $ability->permission(['post_id' => 99])->get_error_code());
self::assertToolError($ability->permission(['post_id' => 99]), 'not_found');
}
public function testOutputSchemaAllowsNullContentForDivi(): void
@@ -96,7 +96,7 @@ final class ContentQueryAbilityTest extends TestCase
{
$result = $this->ability()->execute(['post_type' => 'page', 'cursor' => '???']);
self::assertSame('lit_validation_failed', $result->get_error_code());
self::assertToolError($result, 'validation_failed');
}
public function testQueryIsRestrictedToOwnPostsWithoutEditOthersPosts(): void
@@ -193,7 +193,7 @@ final class ContentQueryAbilityTest extends TestCase
$result = $this->ability($schema)->execute(['post_type' => 'page', 'field' => ['key' => 'ghost']]);
self::assertSame('lit_validation_failed', $result->get_error_code());
self::assertToolError($result, 'validation_failed');
self::assertStringContainsString('role', $result->get_error_message());
}
@@ -209,9 +209,9 @@ final class ContentQueryAbilityTest extends TestCase
$password = $this->ability($schema)->execute(['post_type' => 'page', 'field' => ['key' => 'secret']]);
$protected = $this->ability($schema)->execute(['post_type' => 'page', 'field' => ['key' => '_internal']]);
self::assertSame('lit_validation_failed', $password->get_error_code());
self::assertToolError($password, 'validation_failed');
self::assertSame('Verfügbare Felder: role.', $password->get_error_data()['hint']);
self::assertSame('lit_validation_failed', $protected->get_error_code());
self::assertToolError($protected, 'validation_failed');
self::assertSame('Verfügbare Felder: role.', $protected->get_error_data()['hint']);
}
@@ -225,7 +225,7 @@ final class ContentQueryAbilityTest extends TestCase
'taxonomy' => ['taxonomy' => 'ghost', 'terms' => [1]],
]);
self::assertSame('lit_validation_failed', $result->get_error_code());
self::assertToolError($result, 'validation_failed');
self::assertStringContainsString('category', $result->get_error_message());
}
@@ -235,7 +235,7 @@ final class ContentQueryAbilityTest extends TestCase
$schema->allows('isManaged')->andReturn(false);
$ability = new ContentQueryAbility($schema, Mockery::mock(PostPresenter::class));
self::assertSame('lit_not_found', $ability->permission(['post_type' => 'secret'])->get_error_code());
self::assertToolError($ability->permission(['post_type' => 'secret']), 'not_found');
}
public function testPermissionIsForbiddenWithoutEditRights(): void
@@ -245,7 +245,7 @@ final class ContentQueryAbilityTest extends TestCase
$schema = SchemaFixture::managed();
$ability = new ContentQueryAbility($schema, Mockery::mock(PostPresenter::class));
self::assertSame('lit_forbidden', $ability->permission(['post_type' => 'page'])->get_error_code());
self::assertToolError($ability->permission(['post_type' => 'page']), 'forbidden');
}
public function testInputSchemaLimitsSearchLengthAndTaxonomyTermsCount(): void
@@ -65,7 +65,7 @@ final class ContentTypesAbilityTest extends TestCase
$result = (new ContentTypesAbility($schema))->execute(['post_type' => 'nope']);
self::assertInstanceOf(WP_Error::class, $result);
self::assertSame('lit_not_found', $result->get_error_code());
self::assertToolError($result, 'not_found');
self::assertStringContainsString('page, post', $result->get_error_message());
}
@@ -95,7 +95,7 @@ final class ContentTypesAbilityTest extends TestCase
$result = (new ContentTypesAbility($schema))->execute(['post_type' => 'page']);
self::assertInstanceOf(WP_Error::class, $result);
self::assertSame('lit_forbidden', $result->get_error_code());
self::assertToolError($result, 'forbidden');
}
public function testPermissionRequiresEditPosts(): void
@@ -103,7 +103,7 @@ final class ContentTypesAbilityTest extends TestCase
Functions\when('current_user_can')->justReturn(false);
$ability = new ContentTypesAbility(Mockery::mock(ContentSchema::class));
self::assertSame('lit_forbidden', $ability->permission([])->get_error_code());
self::assertToolError($ability->permission([]), 'forbidden');
}
public function testPermissionForbidsANonEditableSpecificType(): void
@@ -115,7 +115,7 @@ final class ContentTypesAbilityTest extends TestCase
$result = (new ContentTypesAbility($schema))->permission(['post_type' => 'lit_person']);
self::assertInstanceOf(WP_Error::class, $result);
self::assertSame('lit_forbidden', $result->get_error_code());
self::assertToolError($result, 'forbidden');
}
public function testPermissionAllowsAnEditableSpecificType(): void
@@ -71,7 +71,7 @@ final class ContentUpdateAbilityTest extends TestCase
$result = $this->ability(Mockery::mock(PostWriter::class))
->execute(['post_id' => 5, 'rev' => Rev::ofPost($this->post), 'title' => 'Neu']);
self::assertSame('lit_validation_failed', $result->get_error_code());
self::assertToolError($result, 'validation_failed');
}
public function testAMissedScheduleIsRefusedBecauseSavingWouldPublish(): void
@@ -84,8 +84,8 @@ final class ContentUpdateAbilityTest extends TestCase
$result = $this->ability(Mockery::mock(PostWriter::class))
->execute(['post_id' => 5, 'rev' => Rev::ofPost($this->post), 'title' => 'Neu']);
self::assertSame('lit_validation_failed', $result->get_error_code());
self::assertArrayHasKey('post_id', $result->get_error_data()['fields']);
self::assertToolError($result, 'validation_failed');
self::assertArrayHasKey('post_id', self::errorFields($result));
self::assertStringContainsString('lit/post-schedule', $result->get_error_data()['hint']);
}
@@ -96,7 +96,7 @@ final class ContentUpdateAbilityTest extends TestCase
$result = $this->ability(Mockery::mock(PostWriter::class))
->execute(['post_id' => 5, 'rev' => 'stale', 'title' => 'Neu']);
self::assertSame('lit_rev_mismatch', $result->get_error_code());
self::assertToolError($result, 'rev_mismatch');
self::assertStringContainsString('lit-content-get', $result->get_error_data()['hint']);
}
@@ -105,7 +105,7 @@ final class ContentUpdateAbilityTest extends TestCase
$result = $this->ability(Mockery::mock(PostWriter::class))
->execute(['post_id' => 5, 'rev' => Rev::of('<p>Alt</p>'), 'title' => 'Neu']);
self::assertSame('lit_rev_mismatch', $result->get_error_code());
self::assertToolError($result, 'rev_mismatch');
}
public function testRawContentOnDiviPagesIsUnsupported(): void
@@ -117,7 +117,7 @@ final class ContentUpdateAbilityTest extends TestCase
$result = $this->ability($writer)
->execute(['post_id' => 5, 'rev' => Rev::ofPost($this->post), 'content' => '<p>Neu</p>']);
self::assertSame('lit_unsupported', $result->get_error_code());
self::assertToolError($result, 'unsupported');
self::assertStringContainsString(PostPresenter::DIVI_INACTIVE_NOTE, $result->get_error_data()['hint']);
}
@@ -129,7 +129,7 @@ final class ContentUpdateAbilityTest extends TestCase
$result = $this->ability($writer)->execute(['post_id' => 5, 'rev' => Rev::ofPost($this->post)]);
self::assertSame('lit_validation_failed', $result->get_error_code());
self::assertToolError($result, 'validation_failed');
}
public function testUpdateKeepsTheStatusAndCapturesARestorePointFirst(): void
@@ -236,7 +236,7 @@ final class ContentUpdateAbilityTest extends TestCase
$failure = $this->executeExpectingFailure($writer, $input);
self::assertTrue($failure->rolledBack);
self::assertSame('lit_write_failed', $failure->toError()->get_error_code());
self::assertToolError($failure->toError(), 'write_failed');
$message = $failure->toError()->get_error_message();
self::assertStringNotContainsString('Nichts wurde gespeichert', $message);
self::assertStringContainsString('Die Änderung wurde nicht gespeichert (Revision 811 bleibt erhalten).', $message);
@@ -326,7 +326,7 @@ final class ContentUpdateAbilityTest extends TestCase
self::assertFalse($failure->rolledBack);
self::assertStringContainsString('restore kaputt', $failure->getMessage());
$error = $failure->toError();
self::assertSame('lit_partial_write', $error->get_error_code());
self::assertToolError($error, 'partial_write');
self::assertSame(5, $error->get_error_data()['post_id']);
self::assertSame(811, $error->get_error_data()['revision_id']);
$log->assertPartials([
@@ -48,8 +48,8 @@ final class PostWriterTest extends TestCase
'template' => 'fehlt.php',
], true);
$fields = $result->get_error_data()['fields'];
self::assertSame('lit_validation_failed', $result->get_error_code());
$fields = self::errorFields($result);
self::assertToolError($result, 'validation_failed');
self::assertSame('Pflichtfeld fehlt.', $fields['fields.role']);
self::assertSame('Taxonomie gehört nicht zu diesem Inhaltstyp.', $fields['terms.genre']);
self::assertSame('Inhaltstyp unterstützt kein Beitragsbild.', $fields['featured_image']);
@@ -72,7 +72,7 @@ final class PostWriterTest extends TestCase
$result = $writer->prepare('page', $input, false);
self::assertFalse(is_array($result), $path . ' should be rejected');
return (string) $result->get_error_data()['fields'][$path];
return (string) self::errorFields($result)[$path];
}
public function testParentMustBeAReadableNonDescendantEntryOfAHierarchicalType(): void
@@ -152,7 +152,7 @@ final class PostWriterTest extends TestCase
false
);
self::assertSame(['fields.secret' => 'Keine Berechtigung, dieses Feld zu ändern.'], $result->get_error_data()['fields']);
self::assertSame(['fields.secret' => 'Keine Berechtigung, dieses Feld zu ändern.'], self::errorFields($result));
self::assertSame([['edit_post_meta', 5, 'city'], ['edit_post_meta', 5, 'secret']], $checked);
}
@@ -50,10 +50,10 @@ final class MenuAssignLocationAbilityTest extends TestCase
$result = (new MenuAssignLocationAbility(FakeChangeLog::forbidden()))
->execute(['location' => 'primary-menu', 'menu_id' => 0]);
self::assertSame('lit_confirm_required', $result->get_error_code());
self::assertToolError($result, 'confirm_required');
self::assertStringContainsString(
'"Hauptmenü" (ID 3)',
json_decode($result->get_error_message(), true)['message']
self::clientError($result)['message']
);
}
@@ -104,7 +104,7 @@ final class MenuAssignLocationAbilityTest extends TestCase
$result = (new MenuAssignLocationAbility(FakeChangeLog::forbidden()))
->execute(['location' => 'primary-menu', 'menu_id' => 99]);
self::assertSame('lit_not_found', $result->get_error_code());
self::assertToolError($result, 'not_found');
}
public function testPermissionNeedsThemeOptionRights(): void
@@ -114,7 +114,7 @@ final class MenuAssignLocationAbilityTest extends TestCase
$ability = new MenuAssignLocationAbility(FakeChangeLog::forbidden());
$input = ['location' => 'primary-menu', 'menu_id' => 8];
self::assertSame('lit_forbidden', $ability->permission($input)->get_error_code());
self::assertToolError($ability->permission($input), 'forbidden');
}
public function testIsDestructiveBecauseItReplacesTheMenuOfTheLocation(): void
@@ -20,7 +20,7 @@ final class MenuCreateAbilityTest extends TestCase
$ability = new MenuCreateAbility(FakeChangeLog::forbidden());
$result = $ability->execute(['name' => 'Neu', 'location' => 'nope']);
self::assertSame('lit_validation_failed', $result->get_error_code());
self::assertToolError($result, 'validation_failed');
self::assertStringContainsString('primary-menu', $result->get_error_message());
}
@@ -32,7 +32,7 @@ final class MenuCreateAbilityTest extends TestCase
$result = (new MenuCreateAbility(FakeChangeLog::forbidden()))->execute(['name' => 'Hauptmenü']);
self::assertSame('lit_validation_failed', $result->get_error_code());
self::assertToolError($result, 'validation_failed');
}
public function testCreatesAndAssignsTheLocation(): void
@@ -65,6 +65,6 @@ final class MenuCreateAbilityTest extends TestCase
$ability = new MenuCreateAbility(FakeChangeLog::forbidden());
self::assertSame('lit_forbidden', $ability->permission(['name' => 'Neu'])->get_error_code());
self::assertToolError($ability->permission(['name' => 'Neu']), 'forbidden');
}
}
@@ -48,9 +48,9 @@ final class MenuOperationsTest extends TestCase
$cycle = $operations->apply($this->tree(), [['op' => 'move', 'id' => 1, 'parent_id' => 2]]);
$badOp = $operations->apply($this->tree(), [['op' => 'rename', 'id' => 1]]);
self::assertArrayHasKey('operations.0', $unknown->get_error_data()['fields']);
self::assertStringContainsString('unter sich selbst', $cycle->get_error_data()['fields']['operations.0']);
self::assertStringContainsString('add, move oder remove', $badOp->get_error_data()['fields']['operations.0']);
self::assertArrayHasKey('operations.0', self::errorFields($unknown));
self::assertStringContainsString('unter sich selbst', self::errorFields($cycle)['operations.0']);
self::assertStringContainsString('add, move oder remove', self::errorFields($badOp)['operations.0']);
}
public function testExistingNodesKeepOnlyTheirIdSoTheWriterKeepsTheirData(): void
@@ -51,14 +51,14 @@ final class MenuReadAbilitiesTest extends TestCase
self::assertSame('Start', $result['items'][0]['title']);
self::assertSame(Rev::ofMenu([self::item(10, 0, 'Start')]), $result['menu_rev']);
self::assertContains('menu_rev', $ability->outputSchema()['required']);
self::assertSame('lit_not_found', $ability->execute(['menu_id' => 9])->get_error_code());
self::assertToolError($ability->execute(['menu_id' => 9]), 'not_found');
}
public function testReadToolsNeedThemeOptionRights(): void
{
Functions\when('current_user_can')->justReturn(false);
self::assertSame('lit_forbidden', (new MenuListAbility())->permission([])->get_error_code());
self::assertSame('lit_forbidden', (new MenuGetAbility())->permission(['menu_id' => 3])->get_error_code());
self::assertToolError((new MenuListAbility())->permission([]), 'forbidden');
self::assertToolError((new MenuGetAbility())->permission(['menu_id' => 3]), 'forbidden');
}
}
@@ -42,10 +42,10 @@ final class MenuSetItemsAbilityTest extends TestCase
$stale = $ability->execute(['menu_id' => 3, 'menu_rev' => 'abcdefabcdef', 'items' => [['id' => 10]]]);
$missing = $ability->execute(['menu_id' => 3, 'items' => [['id' => 10]]]);
self::assertSame('lit_rev_mismatch', $stale->get_error_code());
self::assertToolError($stale, 'rev_mismatch');
self::assertStringContainsString('lit/menu-get', $stale->get_error_data()['hint']);
self::assertStringContainsString('Menü', $stale->get_error_message());
self::assertSame('lit_rev_mismatch', $missing->get_error_code());
self::assertToolError($missing, 'rev_mismatch');
self::assertContains('menu_rev', $ability->inputSchema()['required']);
self::assertStringContainsString('menu_rev', $ability->description());
}
@@ -68,7 +68,7 @@ final class MenuSetItemsAbilityTest extends TestCase
{
$ability = new MenuSetItemsAbility(new MenuWriter(), new MenuOperations(), FakeChangeLog::forbidden());
self::assertSame('lit_validation_failed', $ability->execute(['menu_id' => 3, 'menu_rev' => self::rev()])->get_error_code());
self::assertToolError($ability->execute(['menu_id' => 3, 'menu_rev' => self::rev()]), 'validation_failed');
self::assertSame(
'lit_validation_failed',
$ability->execute(['menu_id' => 3, 'menu_rev' => self::rev(), 'items' => [], 'operations' => [['op' => 'remove', 'id' => 10]]])
@@ -81,7 +81,7 @@ final class MenuSetItemsAbilityTest extends TestCase
Functions\when('wp_get_nav_menu_object')->justReturn(false);
$ability = new MenuSetItemsAbility(new MenuWriter(), new MenuOperations(), FakeChangeLog::forbidden());
self::assertSame('lit_not_found', $ability->execute(['menu_id' => 9, 'items' => []])->get_error_code());
self::assertToolError($ability->execute(['menu_id' => 9, 'items' => []]), 'not_found');
}
public function testRemovalsNeedConfirmationAndNothingIsWritten(): void
@@ -92,7 +92,7 @@ final class MenuSetItemsAbilityTest extends TestCase
$result = $ability->execute(['menu_id' => 3, 'menu_rev' => self::rev(), 'items' => []]);
self::assertSame('lit_confirm_required', $result->get_error_code());
self::assertToolError($result, 'confirm_required');
self::assertSame([['id' => 10, 'title' => 'Home']], $result->get_error_data()['removals']);
}
@@ -109,8 +109,8 @@ final class MenuSetItemsAbilityTest extends TestCase
'items' => [['id' => 10], ['type' => 'custom', 'url' => 'javascript:alert(1)', 'title' => 'X']],
]);
self::assertSame('lit_validation_failed', $result->get_error_code());
self::assertArrayHasKey('items.1', $result->get_error_data()['fields']);
self::assertToolError($result, 'validation_failed');
self::assertArrayHasKey('items.1', self::errorFields($result));
}
public function testInvalidOperationsWriteNothing(): void
@@ -121,7 +121,7 @@ final class MenuSetItemsAbilityTest extends TestCase
$result = $ability->execute(['menu_id' => 3, 'menu_rev' => self::rev(), 'operations' => [['op' => 'move', 'id' => 99]]]);
self::assertSame('lit_validation_failed', $result->get_error_code());
self::assertToolError($result, 'validation_failed');
}
public function testAppliesAndReturnsTheTreeBeforeAndAfter(): void
@@ -190,7 +190,7 @@ final class MenuSetItemsAbilityTest extends TestCase
['menu_id' => 3, 'menu_rev' => self::rev(), 'items' => [['type' => 'post', 'object_id' => 7]], 'allow_unpublished' => true]
);
self::assertSame('lit_validation_failed', $result->get_error_code());
self::assertToolError($result, 'validation_failed');
self::assertArrayHasKey('allow_unpublished', $ability->inputSchema()['properties']);
}
@@ -209,8 +209,8 @@ final class MenuSetItemsAbilityTest extends TestCase
$refused = $ability->execute($input);
$allowed = $ability->execute($input + ['allow_unpublished' => true]);
self::assertSame('lit_validation_failed', $refused->get_error_code());
self::assertStringContainsString('allow_unpublished', $refused->get_error_data()['fields']['items.1']);
self::assertToolError($refused, 'validation_failed');
self::assertStringContainsString('allow_unpublished', self::errorFields($refused)['items.1']);
self::assertStringContainsString('1 neu', $allowed['summary']);
self::assertStringContainsString('sofort im Menü sichtbar', $allowed['warnings'][0]);
}
@@ -230,8 +230,8 @@ final class MenuSetItemsAbilityTest extends TestCase
'operations' => [['op' => 'add', 'item' => ['type' => 'post', 'object_id' => 7]]],
]);
self::assertSame('lit_validation_failed', $result->get_error_code());
self::assertStringContainsString('Private Inhalte', $result->get_error_data()['fields']['items.1']);
self::assertToolError($result, 'validation_failed');
self::assertStringContainsString('Private Inhalte', self::errorFields($result)['items.1']);
}
public function testAWriteFailureIsPassedOnAsWriteFailed(): void
@@ -290,7 +290,7 @@ final class MenuSetItemsAbilityTest extends TestCase
Functions\when('current_user_can')->justReturn(false);
$ability = new MenuSetItemsAbility(new MenuWriter(), new MenuOperations(), FakeChangeLog::forbidden());
self::assertSame('lit_forbidden', $ability->permission(['menu_id' => 3, 'menu_rev' => self::rev()])->get_error_code());
self::assertToolError($ability->permission(['menu_id' => 3, 'menu_rev' => self::rev()]), 'forbidden');
}
public function testIsDestructiveAndDescribesWhenConfirmIsNeeded(): void
@@ -334,7 +334,7 @@ final class MenuWriterTest extends TestCase
} catch (WriteFailed $e) {
self::assertTrue($e->rolledBack);
self::assertStringContainsString('kaputt', $e->getMessage());
self::assertSame('lit_write_failed', $e->toError()->get_error_code());
self::assertToolError($e->toError(), 'write_failed');
}
$restore = $calls[3];
@@ -357,7 +357,7 @@ final class MenuWriterTest extends TestCase
} catch (WriteFailed $e) {
self::assertFalse($e->rolledBack);
$error = $e->toError();
self::assertSame('lit_partial_write', $error->get_error_code());
self::assertToolError($error, 'partial_write');
self::assertSame(3, $error->get_error_data()['menu_id']);
self::assertSame('Home', $error->get_error_data()['previous_items'][0]['title']);
self::assertStringContainsString('lit/menu-get', $error->get_error_data()['hint']);
@@ -23,16 +23,16 @@ final class PostGuardTest extends TestCase
public function testRejectsInvalidIds(): void
{
self::assertSame('lit_validation_failed', PostGuard::editable('abc', $this->schema())->get_error_code());
self::assertSame('lit_validation_failed', PostGuard::editable(-3, $this->schema())->get_error_code());
self::assertToolError(PostGuard::editable('abc', $this->schema()), 'validation_failed');
self::assertToolError(PostGuard::editable(-3, $this->schema()), 'validation_failed');
}
public function testMissingOrUnmanagedPostsAreNotFound(): void
{
Functions\when('get_post')->alias(static fn (int $id) => $id === 8 ? new WP_Post(['ID' => 8, 'post_type' => 'et_pb_layout']) : null);
self::assertSame('lit_not_found', PostGuard::editable(5, $this->schema())->get_error_code());
self::assertSame('lit_not_found', PostGuard::editable(8, $this->schema())->get_error_code());
self::assertToolError(PostGuard::editable(5, $this->schema()), 'not_found');
self::assertToolError(PostGuard::editable(8, $this->schema()), 'not_found');
}
public function testRequiresEditRightsAndReturnsThePost(): void
@@ -44,7 +44,7 @@ final class PostGuardTest extends TestCase
self::assertSame($post, PostGuard::editable('5', $this->schema()));
Functions\when('current_user_can')->justReturn(false);
self::assertSame('lit_forbidden', PostGuard::editable(5, $this->schema())->get_error_code());
self::assertToolError(PostGuard::editable(5, $this->schema()), 'forbidden');
}
public function testTrashedPostsAreRefusedUnlessAllowed(): void
@@ -54,8 +54,8 @@ final class PostGuardTest extends TestCase
Functions\when('current_user_can')->justReturn(true);
$error = PostGuard::editable(5, $this->schema(), 'copy_id');
self::assertSame('lit_validation_failed', $error->get_error_code());
self::assertArrayHasKey('copy_id', $error->get_error_data()['fields']);
self::assertToolError($error, 'validation_failed');
self::assertArrayHasKey('copy_id', self::errorFields($error));
self::assertSame($post, PostGuard::editable(5, $this->schema(), 'post_id', true));
}
@@ -107,8 +107,8 @@ final class PostGuardTest extends TestCase
$error = PostGuard::statusStable($post, 'original_id');
self::assertSame('lit_validation_failed', $error->get_error_code());
self::assertArrayHasKey('original_id', $error->get_error_data()['fields']);
self::assertToolError($error, 'validation_failed');
self::assertArrayHasKey('original_id', self::errorFields($error));
self::assertStringContainsString('lit-post-publish', $error->get_error_data()['hint']);
self::assertStringContainsString('lit/post-schedule', $error->get_error_data()['hint']);
self::assertNull(PostGuard::statusStable(new WP_Post(['post_status' => 'publish'])));
@@ -141,12 +141,12 @@ final class PostGuardTest extends TestCase
Functions\when('get_post_type_object')->justReturn($object);
Functions\when('current_user_can')->alias(static fn (string $cap): bool => $cap === 'edit_pages');
self::assertSame('lit_not_found', PostGuard::postType('et_pb_layout', $this->schema(), 'create_posts')->get_error_code());
self::assertSame('lit_not_found', PostGuard::postType(null, $this->schema(), 'create_posts')->get_error_code());
self::assertToolError(PostGuard::postType('et_pb_layout', $this->schema(), 'create_posts'), 'not_found');
self::assertToolError(PostGuard::postType(null, $this->schema(), 'create_posts'), 'not_found');
self::assertSame($object, PostGuard::postType('page', $this->schema(), 'create_posts'));
Functions\when('current_user_can')->justReturn(false);
self::assertSame('lit_forbidden', PostGuard::postType('page', $this->schema(), 'create_posts')->get_error_code());
self::assertToolError(PostGuard::postType('page', $this->schema(), 'create_posts'), 'forbidden');
}
public function testAssertNoMissedScheduleRefusesAMissedScheduleWithTheCallersMessage(): void
@@ -50,7 +50,7 @@ final class RevisionRestoreAbilityTest extends TestCase
public function testNonRevisionIdIsNotFound(): void
{
self::assertSame('lit_not_found', $this->ability(FakeChangeLog::forbidden())->permission(['revision_id' => 5])->get_error_code());
self::assertToolError($this->ability(FakeChangeLog::forbidden())->permission(['revision_id' => 5]), 'not_found');
}
public function testRequiresConfirmation(): void
@@ -59,7 +59,7 @@ final class RevisionRestoreAbilityTest extends TestCase
$result = $this->ability(FakeChangeLog::forbidden())->execute(['revision_id' => 810]);
self::assertSame('lit_confirm_required', $result->get_error_code());
self::assertToolError($result, 'confirm_required');
}
public function testOrphanRevisionYieldsValidationErrorOnRevisionIdField(): void
@@ -71,8 +71,8 @@ final class RevisionRestoreAbilityTest extends TestCase
$error = $this->ability(FakeChangeLog::forbidden())
->permission(['revision_id' => 810, 'rev' => 'irrelevant', 'confirm' => true]);
self::assertSame('lit_validation_failed', $error->get_error_code());
self::assertArrayHasKey('revision_id', $error->get_error_data()['fields']);
self::assertToolError($error, 'validation_failed');
self::assertArrayHasKey('revision_id', self::errorFields($error));
}
public function testATrashedEntryIsRefused(): void
@@ -86,8 +86,8 @@ final class RevisionRestoreAbilityTest extends TestCase
$error = $this->ability(FakeChangeLog::forbidden())->execute(['revision_id' => 810, 'rev' => 'x', 'confirm' => true]);
self::assertSame('lit_validation_failed', $error->get_error_code());
self::assertArrayHasKey('revision_id', $error->get_error_data()['fields']);
self::assertToolError($error, 'validation_failed');
self::assertArrayHasKey('revision_id', self::errorFields($error));
}
public function testAMissedScheduleIsRefusedBecauseRestoringWouldPublish(): void
@@ -110,7 +110,7 @@ final class RevisionRestoreAbilityTest extends TestCase
'confirm' => true,
]);
self::assertSame('lit_validation_failed', $error->get_error_code());
self::assertToolError($error, 'validation_failed');
self::assertStringContainsString('lit-post-publish', $error->get_error_data()['hint']);
}
@@ -121,7 +121,7 @@ final class RevisionRestoreAbilityTest extends TestCase
$result = $this->ability(FakeChangeLog::forbidden())
->execute(['revision_id' => 810, 'confirm' => true, 'rev' => 'stale']);
self::assertSame('lit_rev_mismatch', $result->get_error_code());
self::assertToolError($result, 'rev_mismatch');
}
public function testSavesTheCurrentStateThenRestores(): void
@@ -173,7 +173,7 @@ final class RevisionRestoreAbilityTest extends TestCase
'rev' => $this->currentRev(),
]);
self::assertSame('lit_write_failed', $result->get_error_code());
self::assertToolError($result, 'write_failed');
self::assertStringNotContainsString('Nichts wurde gespeichert', $result->get_error_message());
self::assertStringContainsString(
'Die Änderung wurde nicht gespeichert (Revision 813 bleibt erhalten).',
@@ -79,6 +79,6 @@ final class RevisionsListAbilityTest extends TestCase
{
$result = $this->ability()->execute(['post_id' => 5, 'cursor' => 'not-a-cursor']);
self::assertSame('lit_validation_failed', $result->get_error_code());
self::assertToolError($result, 'validation_failed');
}
}
@@ -120,8 +120,8 @@ final class WpSettingsAbilitiesTest extends TestCase
$result = (new WpSettingsUpdateAbility(new SettingsWhitelist(), FakeChangeLog::forbidden()))
->execute(['settings' => ['blogname' => 'Neu', 'admin_email' => 'x@y.de']]);
self::assertSame('lit_validation_failed', $result->get_error_code());
self::assertArrayHasKey('admin_email', $result->get_error_data()['fields']);
self::assertToolError($result, 'validation_failed');
self::assertArrayHasKey('admin_email', self::errorFields($result));
}
public function testRejectsAGenuinelyUnknownKey(): void
@@ -131,8 +131,8 @@ final class WpSettingsAbilitiesTest extends TestCase
$result = (new WpSettingsUpdateAbility(new SettingsWhitelist(), FakeChangeLog::forbidden()))
->execute(['settings' => ['template' => 'twentyten']]);
self::assertSame('lit_validation_failed', $result->get_error_code());
self::assertArrayHasKey('template', $result->get_error_data()['fields']);
self::assertToolError($result, 'validation_failed');
self::assertArrayHasKey('template', self::errorFields($result));
}
public function testUpdatesOnlyChangedValuesAndFlushesPermalinks(): void
@@ -221,7 +221,7 @@ final class WpSettingsAbilitiesTest extends TestCase
'blogdescription' => 'Auch neu',
]);
self::assertSame('lit_write_failed', $error->get_error_code());
self::assertToolError($error, 'write_failed');
$log->assertRecorded();
$log->assertPartials();
}
@@ -252,7 +252,7 @@ final class WpSettingsAbilitiesTest extends TestCase
'blogdescription' => 'Auch neu',
]);
self::assertSame('lit_partial_write', $error->get_error_code());
self::assertToolError($error, 'partial_write');
self::assertStringContainsString('blogname', $error->get_error_message());
self::assertStringContainsString('lit/wp-settings-get', $error->get_error_data()['hint']);
$log->assertPartials([
@@ -278,7 +278,7 @@ final class WpSettingsAbilitiesTest extends TestCase
{
Functions\when('current_user_can')->alias(static fn (string $cap): bool => $cap !== 'manage_options');
self::assertSame('lit_forbidden', (new WpSettingsGetAbility(new SettingsWhitelist()))->permission([])->get_error_code());
self::assertToolError((new WpSettingsGetAbility(new SettingsWhitelist()))->permission([]), 'forbidden');
self::assertSame(
'lit_forbidden',
(new WpSettingsUpdateAbility(new SettingsWhitelist(), FakeChangeLog::forbidden()))->permission([])->get_error_code()
@@ -230,7 +230,7 @@ final class PostClonerTest extends TestCase
self::fail('WriteFailed expected');
} catch (WriteFailed $e) {
self::assertTrue($e->rolledBack);
self::assertSame('lit_write_failed', $e->toError()->get_error_code());
self::assertToolError($e->toError(), 'write_failed');
}
}
@@ -71,7 +71,7 @@ final class PostDuplicateAbilityTest extends TestCase
$result = $this->ability($cloner, FakeChangeLog::forbidden())->execute(['post_id' => 5]);
self::assertSame('lit_forbidden', $result->get_error_code());
self::assertToolError($result, 'forbidden');
}
public function testATrashedOriginalIsRefused(): void
@@ -82,7 +82,7 @@ final class PostDuplicateAbilityTest extends TestCase
$result = $this->ability($cloner, FakeChangeLog::forbidden())->execute(['post_id' => 5]);
self::assertSame('lit_validation_failed', $result->get_error_code());
self::assertToolError($result, 'validation_failed');
}
public function testIsIndirectAndNotIdempotent(): void
@@ -95,7 +95,7 @@ final class PostPublishAbilityTest extends TestCase
self::assertFalse($e->rolledBack);
self::assertSame(5, $e->postId);
self::assertStringContainsString('save_post-Hook kaputt', $e->getMessage());
self::assertSame('lit_partial_write', $e->toError()->get_error_code());
self::assertToolError($e->toError(), 'partial_write');
}
$log->assertPartials(['ability' => 'lit/post-publish', 'object_type' => 'page', 'object_id' => '5']);
}
@@ -107,7 +107,7 @@ final class PostPublishAbilityTest extends TestCase
$result = $this->ability(FakeChangeLog::forbidden())->execute(['post_id' => 5]);
self::assertSame('lit_validation_failed', $result->get_error_code());
self::assertToolError($result, 'validation_failed');
}
public function testPermissionNeedsPublishRights(): void
@@ -115,6 +115,6 @@ final class PostPublishAbilityTest extends TestCase
$this->stubPost(['post_status' => 'draft']);
Functions\when('current_user_can')->alias(static fn (string $cap): bool => $cap !== 'publish_post');
self::assertSame('lit_forbidden', $this->ability(FakeChangeLog::forbidden())->permission(['post_id' => 5])->get_error_code());
self::assertToolError($this->ability(FakeChangeLog::forbidden())->permission(['post_id' => 5]), 'forbidden');
}
}
@@ -68,7 +68,7 @@ final class PostReplaceWithCopyAbilityTest extends TestCase
$result = $this->ability($cloner, FakeChangeLog::forbidden())
->execute(['original_id' => 5, 'copy_id' => 77, 'rev' => Rev::ofPost($this->original)]);
self::assertSame('lit_confirm_required', $result->get_error_code());
self::assertToolError($result, 'confirm_required');
}
public function testCopyMustStemFromTheOriginal(): void
@@ -79,7 +79,7 @@ final class PostReplaceWithCopyAbilityTest extends TestCase
$result = $this->ability($cloner, FakeChangeLog::forbidden())->execute($this->input());
self::assertSame('lit_validation_failed', $result->get_error_code());
self::assertToolError($result, 'validation_failed');
}
/** @return list<array{0: string, 1: string}> */
@@ -103,7 +103,7 @@ final class PostReplaceWithCopyAbilityTest extends TestCase
$result = $this->ability($cloner, FakeChangeLog::forbidden())->execute($this->input());
self::assertSame('lit_validation_failed', $result->get_error_code());
self::assertToolError($result, 'validation_failed');
}
public function testAMissedScheduleOfTheOriginalIsRefused(): void
@@ -116,8 +116,8 @@ final class PostReplaceWithCopyAbilityTest extends TestCase
$result = $this->ability($cloner, FakeChangeLog::forbidden())->execute($this->input());
self::assertSame('lit_validation_failed', $result->get_error_code());
self::assertArrayHasKey('original_id', $result->get_error_data()['fields']);
self::assertToolError($result, 'validation_failed');
self::assertArrayHasKey('original_id', self::errorFields($result));
}
public function testAPendingCopyIsAccepted(): void
@@ -142,7 +142,7 @@ final class PostReplaceWithCopyAbilityTest extends TestCase
$result = $this->ability($cloner, FakeChangeLog::forbidden())->execute($this->input(['rev' => 'veraltet']));
self::assertSame('lit_rev_mismatch', $result->get_error_code());
self::assertToolError($result, 'rev_mismatch');
}
public function testDisabledTrashIsRefusedBeforeAnyChange(): void
@@ -152,7 +152,7 @@ final class PostReplaceWithCopyAbilityTest extends TestCase
$result = $this->ability($cloner, FakeChangeLog::forbidden(), false)->execute($this->input());
self::assertSame('lit_unsupported', $result->get_error_code());
self::assertToolError($result, 'unsupported');
}
public function testRevisionThenReplaceThenTrashTheCopy(): void
@@ -232,7 +232,7 @@ final class PostReplaceWithCopyAbilityTest extends TestCase
self::fail('WriteFailed expected');
} catch (WriteFailed $e) {
self::assertTrue($e->rolledBack);
self::assertSame('lit_write_failed', $e->toError()->get_error_code());
self::assertToolError($e->toError(), 'write_failed');
self::assertSame(88, $e->toError()->get_error_data()['backup_id']);
$message = $e->toError()->get_error_message();
self::assertStringNotContainsString('Nichts wurde gespeichert', $message);
@@ -259,7 +259,7 @@ final class PostReplaceWithCopyAbilityTest extends TestCase
self::assertSame(5, $e->postId);
self::assertSame(900, $e->revisionId);
$error = $e->toError();
self::assertSame('lit_partial_write', $error->get_error_code());
self::assertToolError($error, 'partial_write');
self::assertSame(88, $error->get_error_data()['backup_id']);
self::assertStringContainsString('Sicherung', $error->get_error_message());
self::assertStringContainsString('88', $error->get_error_message());
@@ -280,8 +280,8 @@ final class PostReplaceWithCopyAbilityTest extends TestCase
$cloner->expects('replace')->never();
$ability = $this->ability($cloner, FakeChangeLog::forbidden());
self::assertSame('lit_forbidden', $ability->permission($this->input())->get_error_code());
self::assertSame('lit_forbidden', $ability->execute($this->input())->get_error_code());
self::assertToolError($ability->permission($this->input()), 'forbidden');
self::assertToolError($ability->execute($this->input()), 'forbidden');
}
public function testAFailedBackupAbortsBeforeTheOriginalIsTouched(): void
@@ -298,7 +298,7 @@ final class PostReplaceWithCopyAbilityTest extends TestCase
$this->ability($cloner, FakeChangeLog::forbidden())->execute($this->input());
self::fail('WriteFailed expected');
} catch (WriteFailed $e) {
self::assertSame('lit_write_failed', $e->toError()->get_error_code());
self::assertToolError($e->toError(), 'write_failed');
}
}
@@ -92,7 +92,7 @@ final class PostScheduleAbilityTest extends TestCase
self::assertFalse($e->rolledBack);
self::assertSame(5, $e->postId);
self::assertStringContainsString('save_post-Hook kaputt', $e->getMessage());
self::assertSame('lit_partial_write', $e->toError()->get_error_code());
self::assertToolError($e->toError(), 'partial_write');
}
$log->assertPartials(['ability' => 'lit/post-schedule', 'object_type' => 'post', 'object_id' => '5']);
}
@@ -104,7 +104,7 @@ final class PostScheduleAbilityTest extends TestCase
$result = $this->ability(FakeChangeLog::forbidden())->execute(['post_id' => 5, 'date' => '2099-06-01 09:30']);
self::assertSame('lit_validation_failed', $result->get_error_code());
self::assertToolError($result, 'validation_failed');
}
public function testPastAndImpossibleDatesAreRejected(): void
@@ -115,9 +115,9 @@ final class PostScheduleAbilityTest extends TestCase
$past = $ability->execute(['post_id' => 5, 'date' => '2020-01-01 10:00']);
$impossible = $ability->execute(['post_id' => 5, 'date' => '2099-13-45 10:00']);
self::assertSame('lit_validation_failed', $past->get_error_code());
self::assertToolError($past, 'validation_failed');
self::assertStringContainsString('Zukunft', $past->get_error_message());
self::assertSame('lit_validation_failed', $impossible->get_error_code());
self::assertToolError($impossible, 'validation_failed');
}
public function testADateWithinTheNextMinuteIsRejectedBecauseWordPressWouldPublishAtOnce(): void
@@ -131,6 +131,6 @@ final class PostScheduleAbilityTest extends TestCase
$result = $this->ability(FakeChangeLog::forbidden())
->execute(['post_id' => 5, 'date' => $soon->format('Y-m-d H:i')]);
self::assertSame('lit_validation_failed', $result->get_error_code());
self::assertToolError($result, 'validation_failed');
}
}
@@ -44,7 +44,7 @@ final class PostTrashAbilityTest extends TestCase
$result = $this->ability(FakeChangeLog::forbidden())->execute(['post_id' => 5]);
self::assertSame('lit_confirm_required', $result->get_error_code());
self::assertToolError($result, 'confirm_required');
}
public function testMovesToTrashNeverDeletes(): void
@@ -76,7 +76,7 @@ final class PostTrashAbilityTest extends TestCase
$result = $ability->execute(['post_id' => 5, 'confirm' => true]);
self::assertSame('lit_unsupported', $result->get_error_code());
self::assertToolError($result, 'unsupported');
}
public function testAHookThrowingDuringTheWriteIsAPartialWrite(): void
@@ -93,7 +93,7 @@ final class PostTrashAbilityTest extends TestCase
self::assertFalse($e->rolledBack);
self::assertSame(5, $e->postId);
self::assertStringContainsString('save_post-Hook kaputt', $e->getMessage());
self::assertSame('lit_partial_write', $e->toError()->get_error_code());
self::assertToolError($e->toError(), 'partial_write');
}
$log->assertPartials(['ability' => 'lit/post-trash', 'object_type' => 'page', 'object_id' => '5']);
}
@@ -52,7 +52,7 @@ final class PostUnpublishAbilityTest extends TestCase
self::assertFalse($e->rolledBack);
self::assertSame(5, $e->postId);
self::assertStringContainsString('save_post-Hook kaputt', $e->getMessage());
self::assertSame('lit_partial_write', $e->toError()->get_error_code());
self::assertToolError($e->toError(), 'partial_write');
}
$log->assertPartials(['ability' => 'lit/post-unpublish', 'object_type' => 'page', 'object_id' => '5']);
}
@@ -63,7 +63,7 @@ final class PostUnpublishAbilityTest extends TestCase
$result = $this->ability(FakeChangeLog::forbidden(), 'trash')->execute(['post_id' => 5]);
self::assertSame('lit_validation_failed', $result->get_error_code());
self::assertToolError($result, 'validation_failed');
}
public function testDraftIsANoOp(): void
@@ -80,6 +80,6 @@ final class WordPressIntegrationTest extends TestCase
))[0];
$result = $create->execute(['post_type' => 'page', 'title' => 'Start', 'divi' => [['type' => 'section']]]);
self::assertSame('lit_unsupported', $result->get_error_code());
self::assertToolError($result, 'unsupported');
}
}