test: AssertsToolErrors helper for tool error assertions (T3)
tests/Support/AssertsToolErrors (used by TestCase): assertToolError($result, code)
checks the WP_Error code lit_<code> and the code of the client JSON and returns the
payload; clientError() decodes the payload; errorFields() returns the fields and
asserts they exist. Replaces the private clientError() decoders of
DiviWriteAbilitiesTest/DiviReplaceTextAbilityTest, 216 single-line
assertSame('lit_…', …->get_error_code()) assertions, 24 get_error_data()['fields']
digs and two json_decode(message) reads. ErrorsTest keeps json_decode: it tests
the format itself. Tests 1404 -> 1409 (AssertsToolErrorsTest); no test has fewer
assertions.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This commit is contained in:
@@ -51,14 +51,14 @@ final class MenuReadAbilitiesTest extends TestCase
|
||||
self::assertSame('Start', $result['items'][0]['title']);
|
||||
self::assertSame(Rev::ofMenu([self::item(10, 0, 'Start')]), $result['menu_rev']);
|
||||
self::assertContains('menu_rev', $ability->outputSchema()['required']);
|
||||
self::assertSame('lit_not_found', $ability->execute(['menu_id' => 9])->get_error_code());
|
||||
self::assertToolError($ability->execute(['menu_id' => 9]), 'not_found');
|
||||
}
|
||||
|
||||
public function testReadToolsNeedThemeOptionRights(): void
|
||||
{
|
||||
Functions\when('current_user_can')->justReturn(false);
|
||||
|
||||
self::assertSame('lit_forbidden', (new MenuListAbility())->permission([])->get_error_code());
|
||||
self::assertSame('lit_forbidden', (new MenuGetAbility())->permission(['menu_id' => 3])->get_error_code());
|
||||
self::assertToolError((new MenuListAbility())->permission([]), 'forbidden');
|
||||
self::assertToolError((new MenuGetAbility())->permission(['menu_id' => 3]), 'forbidden');
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user