test: AssertsToolErrors helper for tool error assertions (T3)
tests/Support/AssertsToolErrors (used by TestCase): assertToolError($result, code)
checks the WP_Error code lit_<code> and the code of the client JSON and returns the
payload; clientError() decodes the payload; errorFields() returns the fields and
asserts they exist. Replaces the private clientError() decoders of
DiviWriteAbilitiesTest/DiviReplaceTextAbilityTest, 216 single-line
assertSame('lit_…', …->get_error_code()) assertions, 24 get_error_data()['fields']
digs and two json_decode(message) reads. ErrorsTest keeps json_decode: it tests
the format itself. Tests 1404 -> 1409 (AssertsToolErrorsTest); no test has fewer
assertions.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This commit is contained in:
@@ -92,7 +92,7 @@ final class PostScheduleAbilityTest extends TestCase
|
||||
self::assertFalse($e->rolledBack);
|
||||
self::assertSame(5, $e->postId);
|
||||
self::assertStringContainsString('save_post-Hook kaputt', $e->getMessage());
|
||||
self::assertSame('lit_partial_write', $e->toError()->get_error_code());
|
||||
self::assertToolError($e->toError(), 'partial_write');
|
||||
}
|
||||
$log->assertPartials(['ability' => 'lit/post-schedule', 'object_type' => 'post', 'object_id' => '5']);
|
||||
}
|
||||
@@ -104,7 +104,7 @@ final class PostScheduleAbilityTest extends TestCase
|
||||
|
||||
$result = $this->ability(FakeChangeLog::forbidden())->execute(['post_id' => 5, 'date' => '2099-06-01 09:30']);
|
||||
|
||||
self::assertSame('lit_validation_failed', $result->get_error_code());
|
||||
self::assertToolError($result, 'validation_failed');
|
||||
}
|
||||
|
||||
public function testPastAndImpossibleDatesAreRejected(): void
|
||||
@@ -115,9 +115,9 @@ final class PostScheduleAbilityTest extends TestCase
|
||||
$past = $ability->execute(['post_id' => 5, 'date' => '2020-01-01 10:00']);
|
||||
$impossible = $ability->execute(['post_id' => 5, 'date' => '2099-13-45 10:00']);
|
||||
|
||||
self::assertSame('lit_validation_failed', $past->get_error_code());
|
||||
self::assertToolError($past, 'validation_failed');
|
||||
self::assertStringContainsString('Zukunft', $past->get_error_message());
|
||||
self::assertSame('lit_validation_failed', $impossible->get_error_code());
|
||||
self::assertToolError($impossible, 'validation_failed');
|
||||
}
|
||||
|
||||
public function testADateWithinTheNextMinuteIsRejectedBecauseWordPressWouldPublishAtOnce(): void
|
||||
@@ -131,6 +131,6 @@ final class PostScheduleAbilityTest extends TestCase
|
||||
$result = $this->ability(FakeChangeLog::forbidden())
|
||||
->execute(['post_id' => 5, 'date' => $soon->format('Y-m-d H:i')]);
|
||||
|
||||
self::assertSame('lit_validation_failed', $result->get_error_code());
|
||||
self::assertToolError($result, 'validation_failed');
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user