Loosen-IT/WP-LIT-MCP
3
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 7 Wiki Activity

fix: slash media title/alt on import, keep sideload errors out of client responses

Browse Source
This commit is contained in:
janniclas.loosen
2026-09-26 05:06:34 +02:00
parent 648d53cb96
commit 66663daa99
2 changed files with 52 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/Unit/Integrations/Media/MediaImporterTest.php
+38 -1
View File
@@ -32,9 +32,15 @@ final class MediaImporterTest extends TestCase
/** @var list<string> */
private array $tempFiles = [];
/** error_log() is a PHP internal and cannot be stubbed; it is redirected to this file. */
private string $errorLog = '';
private string|false $previousErrorLog = false;
protected function setUp(): void
{
parent::setUp();
$this->errorLog = (string) tempnam(sys_get_temp_dir(), 'lit-mcp-log');
$this->previousErrorLog = ini_set('error_log', $this->errorLog);
Functions\when('get_option')->justReturn(['upload_mb' => 1]);
Functions\when('wp_tempnam')->alias(function (): string {
$file = (string) tempnam(sys_get_temp_dir(), 'lit-up');
@@ -63,6 +69,10 @@ final class MediaImporterTest extends TestCase
protected function tearDown(): void
{
ini_set('error_log', (string) $this->previousErrorLog);
if (is_file($this->errorLog)) {
unlink($this->errorLog);
}
foreach ($this->tempFiles as $file) {
if (is_file($file)) {
unlink($file);
@@ -181,13 +191,40 @@ final class MediaImporterTest extends TestCase
Functions\when('wp_check_filetype_and_ext')->justReturn(['ext' => 'png', 'type' => 'image/png', 'proper_filename' => false]);
Functions\when('media_handle_sideload')->justReturn(new WP_Error('upload_error', 'Verzeichnis nicht beschreibbar'));
Functions\when('media_handle_sideload')->justReturn(
new WP_Error('upload_error', 'Verzeichnis /var/www/html/wp-content/uploads/2026/09 nicht beschreibbar')
);
$result = $this->importer()->fromBase64(base64_encode('PNGDATA'), 'logo.png', []);
$logged = (string) file_get_contents($this->errorLog);
self::assertSame('lit_write_failed', $result->get_error_code());
self::assertStringContainsString('Verzeichnis nicht beschreibbar', $result->get_error_message());
self::assertStringNotContainsString('/var/www', $result->get_error_message());
self::assertStringNotContainsString('/var/www', (string) json_encode($result->get_error_data()));
self::assertStringContainsString('WordPress hat die Datei nicht übernommen', $result->get_error_message());
self::assertStringContainsString('/var/www/html/wp-content/uploads/2026/09 nicht beschreibbar', $logged);
$this->assertTempFilesRemoved();
}
public function testTitleAndAltTextAreSlashedForWordPress(): void
{
Functions\when('wp_slash')->alias('addslashes');
Functions\when('wp_check_filetype_and_ext')->justReturn(['ext' => 'png', 'type' => 'image/png', 'proper_filename' => false]);
Functions\expect('media_handle_sideload')->once()
->with(Mockery::type('array'), 0, 'C:\\\\Pfad')
->andReturn(55);
Functions\expect('update_post_meta')->once()
->with(55, '_wp_attachment_image_alt', 'Back\\\\slash')
->andReturn(true);
$id = $this->importer()->fromBase64(base64_encode('PNGDATA'), 'logo.png', [
'title' => 'C:\\Pfad',
'alt' => 'Back\\slash',
]);
self::assertSame(55, $id);
}
public function testFailedAltTextDeletesTheNewAttachmentAgain(): void
{
Functions\when('wp_check_filetype_and_ext')->justReturn(['ext' => 'png', 'type' => 'image/png', 'proper_filename' => false]);