feat: Pods fields in Theme Builder bodies checked against the template's post types (E12)

Both forms Divi writes are recognized (ruling Q11): custom_meta_<key> and the
dialog form post_meta_key + select_meta_key. Choice fields get a note about the
stored value, relation fields name IDs (F4). Only templates the user may edit
are checked or named; others are counted (Q21 pattern). Warnings only, also in
the dry run of a live body. DynamicFields extracted from lit/divi-dynamic-sources.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

src/Integrations/Divi/Pages/DiviDynamicSourcesAbility.php

@@ -13,8 +13,6 @@ use LIT\MCP\Integrations\Divi\Compose\Placeholders;
 use LIT\MCP\Integrations\Divi\Library\DiviRoles;
 use LIT\MCP\Integrations\WordPress\PostGuard;
 use LIT\MCP\Integrations\WordPress\Schema\ContentSchema;
-use LIT\MCP\Integrations\WordPress\Schema\FieldDefinition;
-use Throwable;
 use WP_Error;
 
 defined('ABSPATH') || exit;
@@ -27,24 +25,18 @@ defined('ABSPATH') || exit;
  *
  * Answer F4: only text-like fields are offered; relation/file fields show IDs in Divi (F26), Pods
  * table storage is not post meta, protected keys never (S12), unknown types not (ruling P9) – each
- * left out with its reason. Hidden fields (security audit M4) are neither offered nor named. The
- * field list needs the Divi role option read_dynamic_content_custom_fields (E3, F25).
+ * left out with its reason (DynamicFields). Hidden fields (security audit M4) are neither offered nor
+ * named. The field list needs the Divi role option read_dynamic_content_custom_fields (E3, F25).
  */
 final class DiviDynamicSourcesAbility implements Ability
 {
-    /** Field types Divi can show as text (arrays of strings are joined with ", ", F26). */
-    private const TEXT_TYPES = ['string', 'text', 'number', 'integer', 'date', 'datetime', 'time', 'choice'];
-
-    private const ID_TYPES = ['relation', 'file'];
-
     /** Candidates the default sample lookup checks for edit_post. */
     private const SAMPLE_CANDIDATES = 10;
 
     /** @var Closure(string): int */
     private Closure $samplePost;
 
-    /** @var Closure(string): ?string */
-    private Closure $podStorage;
+    private DynamicFields $fields;
 
     /**
      * @param (Closure(string): int)|null     $samplePost Post type → an entry to ask Divi with (0 = none).
@@ -59,7 +51,7 @@ final class DiviDynamicSourcesAbility implements Ability
         ?Closure $podStorage = null
     ) {
         $this->samplePost = $samplePost ?? self::defaultSample(...);
-        $this->podStorage = $podStorage ?? self::defaultStorage(...);
+        $this->fields = new DynamicFields($schema, $podStorage);
     }
 
     public function name(): string
@@ -182,7 +174,7 @@ final class DiviDynamicSourcesAbility implements Ability
         $fields = [];
         $omitted = [];
         if ($this->roles->allows('read_dynamic_content_custom_fields')) {
-            [$fields, $omitted] = $this->fields($postType);
+            [$fields, $omitted] = $this->fields->offered($postType);
         } else {
             $notes[] = 'Felder werden nicht gelistet: die Divi-Rolle erlaubt „Dynamic Content: benutzerdefinierte '
                 . 'Felder lesen“ nicht (Divi → Rollen-Editor).';
@@ -215,53 +207,6 @@ final class DiviDynamicSourcesAbility implements Ability
         return $type === 'attachment' || str_starts_with($type, '_') ? null : '{{link:<ID>}}';
     }
 
-    /**
-     * @return array{0: list<array<string, string>>, 1: list<array<string, string>>} Offered and omitted fields.
-     */
-    private function fields(string $postType): array
-    {
-        $storage = ($this->podStorage)($postType);
-        $fields = [];
-        $omitted = [];
-        foreach ($this->schema->fields($postType) as $field) {
-            if ($field->status === FieldDefinition::HIDDEN) {
-                continue;
-            }
-
-            $entry = ['key' => $field->key, 'label' => $field->label];
-            $reason = self::omission($field, $storage);
-            if ($reason !== null) {
-                $omitted[] = $entry + ['reason' => $reason];
-                continue;
-            }
-
-            $fields[] = $entry + [
-                'type' => $field->type,
-                'source' => $field->source,
-                'placeholder' => '{{field:' . $field->key . '}}',
-            ];
-        }
-
-        return [$fields, $omitted];
-    }
-
-    private static function omission(FieldDefinition $field, ?string $storage): ?string
-    {
-        return match (true) {
-            ! DynamicContentRules::isMetaKey($field->key)
-                => 'geschütztes oder ungültiges Meta-Feld (beginnt mit „_“)',
-            $field->source === 'pods' && $storage === 'table'
-                => 'Pods mit Tabellen-Speicherung – Divi liest nur Post-Meta',
-            in_array($field->type, self::ID_TYPES, true)
-                => 'Beziehungs- oder Dateifeld – Divi zeigt davon nur IDs',
-            $field->type === 'unknown'
-                => 'Feldtyp unbekannt – Divi zeigt womöglich keinen Text',
-            ! in_array($field->type, self::TEXT_TYPES, true)
-                => sprintf('Feldtyp „%s“ ist nicht textartig', $field->type),
-            default => null,
-        };
-    }
-
     /** The most recently modified entry of the type the current user may edit, else 0. */
     private static function defaultSample(string $postType): int
     {
@@ -283,19 +228,4 @@ final class DiviDynamicSourcesAbility implements Ability
 
         return 0;
     }
-
-    private static function defaultStorage(string $postType): ?string
-    {
-        if (! function_exists('pods_api')) {
-            return null;
-        }
-
-        try {
-            $pod = pods_api()->load_pod(['name' => $postType]);
-        } catch (Throwable) {
-            return null;
-        }
-
-        return is_object($pod) && method_exists($pod, 'get_storage') ? (string) $pod->get_storage() : null;
-    }
 }