fix(4e-review M-1): Schleifen-Warnung nennt die ganze Kette (Terme > Beiträge); loopWhere mit frühen Returns

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This commit is contained in:
Jan-Niclas Loosen
2026-10-20 00:40:05 +02:00
co-authored by Claude Sonnet 5.5
parent 8be2f5e558
commit 71ffbdbf59
3 changed files with 41 additions and 16 deletions
@@ -423,7 +423,9 @@ final class DiviLoopWriteTest extends DiviWriteAbilityTestCase
]);
self::assertTrue($result['ok'], (string) json_encode($result));
self::assertStringContainsString('loop_post_meta_key_manual_custom_field', implode(' | ', $result['warnings']));
$warnings = implode(' | ', $result['warnings']);
self::assertStringContainsString('loop_post_meta_key_manual_custom_field', $warnings);
self::assertStringContainsString('Typ: Terme > Beiträge (vorher: Beiträge > Beiträge)', $warnings);
}
/** Audit L2: "terms" is a term loop for Divi, an unsupported target "can show data of another object". */
@@ -531,7 +533,9 @@ final class DiviLoopWriteTest extends DiviWriteAbilityTestCase
$result = $this->moveNode(['id' => 's0.r0.c0.m0', 'parent' => 's0.r0.c1']);
self::assertTrue($result['ok'], (string) json_encode($result));
self::assertStringContainsString('loop_post_meta_key_manual_custom_field', implode(' | ', $result['warnings']));
$warnings = implode(' | ', $result['warnings']);
self::assertStringContainsString('loop_post_meta_key_manual_custom_field', $warnings);
self::assertStringContainsString('Typ: Terme > Beiträge (vorher: Beiträge)', $warnings);
}
/** Two sections: a post loop on its own, and a post loop inside a term loop (s1). */