test: FakeChangeLog and SchemaFixture instead of repeated mocks (T2)
- tests/Support/FakeChangeLog extends ChangeLog: records record()/recordPartial() calls, increasing ids, optional failure; new FakeChangeLog(id) / partialsOnly() / any(id) / forbidden() mirror what the replaced mocks allowed. assertRecorded() / assertPartials() check count and the named arguments. Calls a fake does not allow throw and are also verified in TestCase::tearDown (one assertion per test that uses a fake), so swallowed change-log calls still fail like a never() expectation. - All ChangeLog mocks of ability/integration tests replaced (the admin tests that stub query/purge/clear keep their mocks); expectException tests that checked the partial log now catch and assert. - SchemaFixture::managed(?divi) replaces the 21 isManaged-only ContentSchema mocks; DiviFixtures::schema() uses it. Tests 1397 -> 1404 (FakeChangeLogTest); no test has fewer assertions. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This commit is contained in:
@@ -6,9 +6,9 @@ namespace LIT\MCP\Tests\Unit\Integrations\WordPress\Content;
|
||||
|
||||
use Brain\Monkey\Functions;
|
||||
use LIT\MCP\Abilities\WriteFailed;
|
||||
use LIT\MCP\ChangeLog\ChangeLog;
|
||||
use LIT\MCP\Integrations\WordPress\Content\NewDraft;
|
||||
use LIT\MCP\Integrations\WordPress\Content\PostWriter;
|
||||
use LIT\MCP\Tests\Support\FakeChangeLog;
|
||||
use LIT\MCP\Tests\Unit\TestCase;
|
||||
use Mockery;
|
||||
use RuntimeException;
|
||||
@@ -22,9 +22,7 @@ final class NewDraftTest extends TestCase
|
||||
Functions\when('wp_delete_post')->alias(static function (): never {
|
||||
throw new RuntimeException('delete_post hook kaputt');
|
||||
});
|
||||
$log = Mockery::mock(ChangeLog::class);
|
||||
$log->expects('recordPartial')
|
||||
->with('lit/content-create', 'page', '42', 'Entwurf 42: Anlegen nur teilweise zurückgenommen');
|
||||
$log = FakeChangeLog::partialsOnly();
|
||||
$draft = new NewDraft($writer, $log, 'lit/content-create', 'page');
|
||||
|
||||
try {
|
||||
@@ -40,6 +38,12 @@ final class NewDraftTest extends TestCase
|
||||
$e->getMessage()
|
||||
);
|
||||
}
|
||||
$log->assertPartials([
|
||||
'ability' => 'lit/content-create',
|
||||
'object_type' => 'page',
|
||||
'object_id' => '42',
|
||||
'summary' => 'Entwurf 42: Anlegen nur teilweise zurückgenommen',
|
||||
]);
|
||||
}
|
||||
|
||||
public function testACleanDiscardIsRolledBackWithTheGivenReason(): void
|
||||
@@ -47,8 +51,7 @@ final class NewDraftTest extends TestCase
|
||||
$writer = Mockery::mock(PostWriter::class);
|
||||
$writer->expects('deleteCreatedTerms');
|
||||
Functions\expect('wp_delete_post')->once()->with(42, true)->andReturn(true);
|
||||
$log = Mockery::mock(ChangeLog::class);
|
||||
$log->expects('recordPartial')->never();
|
||||
$log = FakeChangeLog::forbidden();
|
||||
$draft = new NewDraft($writer, $log, 'lit/content-create', 'page');
|
||||
|
||||
try {
|
||||
|
||||
Reference in New Issue
Block a user