Loosen-IT/WP-LIT-MCP
3
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 7 Wiki Activity

test: fix the P9/P14 backup wording of every VisibleEdits caller (ruling Q17 M3)

Browse Source 
VisibleEditsTest asserts the exact refusal messages (no unfiltered_html,
trash disabled) and the keepingBackup() hints for rolled-back and partial
failures with each caller's label and entry. The callers' own tests drive
GlobalEdits, ThemeBuilderEdits (through DiviWriter) and make-global with
revisions off and assert the same sentences.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01At3V6SjwbMe6eMzVGW3Hs7
This commit is contained in:
janniclas.loosen
2026-09-27 23:03:05 +02:00
co-authored by Claude Opus 5.5
parent 43dc3fb889
commit 79f2fdbda6
5 changed files with 165 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/Unit/Integrations/Divi/Library/GlobalEditsTest.php
+18 -4
View File
@@ -5,6 +5,7 @@ declare(strict_types=1);
namespace LIT\MCP\Tests\Unit\Integrations\Divi\Library;
use Brain\Monkey\Functions;
use LIT\MCP\Abilities\Errors;
use LIT\MCP\Abilities\Rev;
use LIT\MCP\Abilities\WriteFailed;
use LIT\MCP\Integrations\Divi\Library\GlobalEdits;
@@ -20,6 +21,7 @@ use LIT\MCP\Tests\Support\DiviFixtures;
use LIT\MCP\Tests\Support\DiviWriterFixture;
use LIT\MCP\Tests\Support\FakeChangeLog;
use LIT\MCP\Tests\Support\LibraryFixtures;
use LIT\MCP\Tests\Unit\Integrations\Divi\Pages\VisibleEditsTest;
use LIT\MCP\Tests\Unit\TestCase;
use Mockery;
use WP_Post;
@@ -27,6 +29,9 @@ use WP_Post;
/** The Divi write tools on library entries (E2, answer F2). */
final class GlobalEditsTest extends TestCase
{
private const BACKUP_HINT = 'Revisionen für die Divi-Bibliothek aktivieren (WP_POST_REVISIONS) oder den Eintrag im '
. 'Divi-Builder bearbeiten.';
/** @var list<array{string, SaveScope}> Content and scope handed to the saver. */
private array $saved = [];
@@ -227,7 +232,11 @@ final class GlobalEditsTest extends TestCase
$result = (new DiviUpdateAbility($this->writer()))->execute(self::relabel(1059, true));
self::assertToolError($result, 'unsupported');
self::assertStringContainsString('Revisionen', $result->get_error_message());
self::assertSame(
sprintf(VisibleEditsTest::UNFAITHFUL, 'Bibliothekseintrag 1059'),
Errors::clientMessage($result)
);
self::assertSame(self::BACKUP_HINT, $result->get_error_data()['hint']);
self::assertSame(0, $this->backups);
self::assertSame([], $this->saved);
}
@@ -242,7 +251,8 @@ final class GlobalEditsTest extends TestCase
$result = (new DiviUpdateAbility($this->writer()))->execute(self::relabel(1059, true));
self::assertToolError($result, 'unsupported');
self::assertStringContainsString('Papierkorb', $result->get_error_message());
self::assertSame(sprintf(VisibleEditsTest::NO_TRASH, 'Bibliothekseintrag 1059'), Errors::clientMessage($result));
self::assertSame(self::BACKUP_HINT, $result->get_error_data()['hint']);
self::assertSame(0, $this->backups);
self::assertSame([], $this->saved);
}
@@ -396,7 +406,11 @@ final class GlobalEditsTest extends TestCase
self::assertTrue($e->rolledBack);
self::assertSame(1071, $error->get_error_data()['backup_id']);
self::assertStringContainsString('Sicherung 1071 liegt im Papierkorb', $error->get_error_data()['hint']);
self::assertSame(
VisibleEditsTest::keptRolledBack(1071, 'des Bibliothekseintrags'),
$error->get_error_data()['hint']
);
self::assertStringContainsString(Errors::notSavedKeeping('Sicherung 1071 im Papierkorb'), Errors::clientMessage($error));
self::assertStringNotContainsString('Nichts wurde gespeichert', $error->get_error_message());
self::assertSame(1, $this->backups);
}
@@ -418,7 +432,7 @@ final class GlobalEditsTest extends TestCase
self::assertToolError($error, 'partial_write');
self::assertSame(1071, $error->get_error_data()['backup_id']);
self::assertSame(1059, $error->get_error_data()['post_id']);
self::assertStringContainsString('Sicherung 1071 liegt im Papierkorb', $error->get_error_data()['hint']);
self::assertSame(VisibleEditsTest::keptPartial(1071, 'des Bibliothekseintrags'), $error->get_error_data()['hint']);
self::assertCount(1, $this->log->partials);
}
tests/Unit/Integrations/Divi/Library/LibraryMakeGlobalAbilityTest.php
+43 -1
View File
@@ -5,6 +5,7 @@ declare(strict_types=1);
namespace LIT\MCP\Tests\Unit\Integrations\Divi\Library;
use Brain\Monkey\Functions;
use LIT\MCP\Abilities\Errors;
use LIT\MCP\Abilities\Rev;
use LIT\MCP\Abilities\WriteFailed;
use LIT\MCP\Integrations\Divi\BlockTree\LibraryContent;
@@ -23,6 +24,7 @@ use LIT\MCP\Tests\Support\DiviWriterFixture;
use LIT\MCP\Tests\Support\FakeChangeLog;
use LIT\MCP\Tests\Support\LibraryFixtures;
use LIT\MCP\Tests\Support\ThemeBuilderFixtures;
use LIT\MCP\Tests\Unit\Integrations\Divi\Pages\VisibleEditsTest;
use LIT\MCP\Tests\Unit\TestCase;
use Mockery;
use Throwable;
@@ -30,6 +32,8 @@ use WP_Post;
final class LibraryMakeGlobalAbilityTest extends TestCase
{
private const BACKUP_HINT = 'Revisionen aktivieren (WP_POST_REVISIONS) oder die Seite im Divi-Builder bearbeiten.';
private WP_Post $page;
/** @var list<LibraryItemSpec> */
@@ -453,11 +457,49 @@ final class LibraryMakeGlobalAbilityTest extends TestCase
$this->saved = [];
$this->givenCopiesOf1058();
Functions\when('current_user_can')->alias(static fn (string $cap): bool => $cap !== 'unfiltered_html');
self::assertToolError($this->ability()->execute(self::targets(['s0'], ['s1'], true)), 'unsupported');
$refused = $this->ability()->execute(self::targets(['s0'], ['s1'], true));
self::assertToolError($refused, 'unsupported');
self::assertSame(sprintf(VisibleEditsTest::UNFAITHFUL, 'Seite 8'), Errors::clientMessage($refused));
self::assertSame(self::BACKUP_HINT, $refused->get_error_data()['hint']);
self::assertSame([], $this->backups);
self::assertSame([], $this->saved);
}
/** Review I-3 (ruling Q17 M3): the trash refusal and a failure after the backup name the page. */
public function testTheBackupWordingNamesThePage(): void
{
$this->givenCopiesOf1058();
Functions\when('wp_revisions_enabled')->justReturn(false);
$noFailures = [];
$ability = new LibraryMakeGlobalAbility(
LibraryFixtures::access(),
DiviWriterFixture::writer($this->saved, $noFailures, false, LibraryFixtures::loader()),
new NewLibraryEntry(LibraryFixtures::access(), Mockery::mock(DiviSaver::class), DiviWriterFixture::modules()),
$this->log,
null,
new VisibleEdits(static fn (WP_Post $post): int => 1071, static fn (): bool => false)
);
$noTrash = $ability->execute(self::targets(['s0'], ['s1'], true));
self::assertToolError($noTrash, 'unsupported');
self::assertSame(sprintf(VisibleEditsTest::NO_TRASH, 'Seite 8'), Errors::clientMessage($noTrash));
self::assertSame(self::BACKUP_HINT, $noTrash->get_error_data()['hint']);
self::assertSame([], $this->saved);
$this->givenCopiesOf1058();
try {
$this->ability([], true, false, [WriteFailed::rolledBack('Grund.')])
->execute(self::targets(['s0'], ['s1'], true));
self::fail('no WriteFailed');
} catch (WriteFailed $e) {
self::assertSame(1071, $e->details['backup_id']);
self::assertSame(VisibleEditsTest::keptRolledBack(1071, 'der Seite'), $e->toError()->get_error_data()['hint']);
self::assertStringContainsString(
Errors::notSavedKeeping('Sicherung 1071 im Papierkorb'),
Errors::clientMessage($e->toError())
);
}
}
/** A failure on page N: the pages before stay replaced (each with revision), the rest untouched – all named. */
public function testAFailureMidwayReportsEveryPage(): void
{