Loosen-IT/WP-LIT-MCP
3
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 7 Wiki Activity

fix: media usage check fails closed on database errors; refused deletes checked for partial state

Browse Source 
MediaUsageFinder treats a failed query (null result or last_error) as a possible
usage and an incomplete scan, so media-delete refuses without force. A refused
wp_delete_attachment() is write_failed only when the attachment is intact,
otherwise partial_write. media-update: re-read hint on write_failed, normalized
ids in failures, documented lock resolution and kses on restore.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01At3V6SjwbMe6eMzVGW3Hs7
This commit is contained in:
janniclas.loosen
2026-09-26 02:54:37 +02:00
co-authored by Claude Opus 5.5
parent 931ddeb137
commit 7f136f6f4c
10 changed files with 238 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/Unit/Integrations/Media/MediaDeleteAbilityTest.php
+51 -1
View File
@@ -23,6 +23,7 @@ final class MediaDeleteAbilityTest extends TestCase
parent::setUp();
Functions\when('get_post')->justReturn(new WP_Post(['ID' => 33, 'post_type' => 'attachment', 'post_status' => 'inherit', 'post_title' => 'Foto']));
Functions\when('current_user_can')->justReturn(true);
Functions\when('get_post_meta')->justReturn('2026/09/foto.jpg');
}
private function ability(array $usages, ChangeLog $log, bool $trash = false): MediaDeleteAbility
@@ -96,8 +97,9 @@ final class MediaDeleteAbilityTest extends TestCase
self::assertSame('trashed', $result['changed'][0]['action']);
}
public function testRefusedDeleteIsAWriteFailure(): void
public function testRefusedDeleteWithTheAttachmentIntactIsAWriteFailure(): void
{
Functions\when('get_post_meta')->justReturn('2026/09/foto.jpg');
Functions\expect('wp_delete_attachment')->once()->andReturn(false);
$result = $this->ability([], Mockery::mock(ChangeLog::class))->execute(['id' => 33, 'confirm' => true]);
@@ -105,6 +107,54 @@ final class MediaDeleteAbilityTest extends TestCase
self::assertSame('lit_write_failed', $result->get_error_code());
}
public function testRefusedDeleteThatRemovedDataIsAPartialWrite(): void
{
$meta = '2026/09/foto.jpg';
Functions\when('get_post_meta')->alias(static function () use (&$meta): string {
return $meta;
});
Functions\expect('wp_delete_attachment')->once()->andReturnUsing(static function () use (&$meta) {
$meta = '';
return null;
});
$log = Mockery::mock(ChangeLog::class);
$log->expects('recordPartial')->once()->with('lit/media-delete', 'attachment', '33', Mockery::type('string'));
$result = $this->ability([], $log)->execute(['id' => 33, 'confirm' => true]);
self::assertSame('lit_partial_write', $result->get_error_code());
self::assertSame(33, $result->get_error_data()['attachment_id']);
}
public function testADatabaseErrorInTheUsageCheckRefusesWithoutForce(): void
{
Functions\when('get_post_meta')->justReturn('2026/09/foto.jpg');
Functions\when('get_option')->justReturn(false);
Functions\when('get_theme_mod')->justReturn(false);
Functions\expect('wp_delete_attachment')->never();
/** @var \Mockery\MockInterface&\wpdb $db */
$db = Mockery::mock(\wpdb::class)->makePartial();
$db->allows('get_results')->andReturn(null);
$ability = new MediaDeleteAbility(
new MediaUsageFinder(static fn (): array => [], $db),
Mockery::mock(ChangeLog::class),
static fn (): bool => false
);
$file = (string) tempnam(sys_get_temp_dir(), 'lit-mcp-log');
$previous = ini_set('error_log', $file);
try {
$result = $ability->execute(['id' => 33, 'confirm' => true]);
} finally {
ini_set('error_log', (string) $previous);
unlink($file);
}
self::assertSame('lit_in_use', $result->get_error_code());
self::assertSame(MediaUsageFinder::FAILED_TITLE, $result->get_error_data()['usages'][0]['title']);
}
public function testChangeLogFailureIsOnlyAWarning(): void
{
Functions\expect('wp_delete_attachment')->once()->andReturn(new WP_Post(['ID' => 33]));