Loosen-IT/WP-LIT-MCP
3
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 7 Wiki Activity

fix(4e-review M1): Update unterscheidet Composer und Zweitdurchlauf nach der ganzen Schleifen-Kette (LoopScope::key)

Browse Source 
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This commit is contained in:
Jan-Niclas Loosen
2026-10-20 00:38:33 +02:00
co-authored by Claude Sonnet 5.5
parent b91c356a28
commit 8be2f5e558
3 changed files with 70 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/Unit/Integrations/Divi/Pages/DiviLoopWriteTest.php
+54
View File
@@ -47,6 +47,9 @@ final class DiviLoopWriteTest extends DiviWriteAbilityTestCase
'date_format' => $field('select'), 'custom_date_format' => $field('text'),
]),
'loop_term_name' => $option('loop_term_name', 'Loop Terms', $common),
'loop_post_meta_key_manual_custom_field' => $option('loop_post_meta_key_manual_custom_field', 'Loop', $common + [
'select_loop_meta_key' => $field('select'), 'loop_meta_key' => $field('text'),
]),
];
}
@@ -530,4 +533,55 @@ final class DiviLoopWriteTest extends DiviWriteAbilityTestCase
self::assertTrue($result['ok'], (string) json_encode($result));
self::assertStringContainsString('loop_post_meta_key_manual_custom_field', implode(' | ', $result['warnings']));
}
/** Two sections: a post loop on its own, and a post loop inside a term loop (s1). */
private function useTwoSectionPage(): void
{
$inner = static fn (): string => self::block('text', self::loop(self::POST_LOOP));
$this->usePage('<!-- wp:divi/placeholder -->'
. self::block('section', [], self::block('row', [], self::block('column', [], $inner())))
. self::block('section', self::loop(self::TERM_LOOP), self::block('row', [], self::block('column', [], $inner())))
. '<!-- /wp:divi/placeholder -->');
}
private static function metaChange(string $id): array
{
$ref = VariableRef::serialize(
'content',
'loop_post_meta_key_manual_custom_field',
['before' => '', 'after' => '', 'loop_meta_key' => 'telefon']
);
return ['id' => $id, 'attrs' => ['content.innerContent' => ['desktop' => $ref]]];
}
/** Re-review (M1): the composers of one update call are told apart by the whole chain, not the inner kind. */
public function testMetaKeyContentIsCheckedAgainstTheWholeChainInOneCall(): void
{
$this->useTwoSectionPage();
$inTerm = $this->changeAll([self::metaChange('s1.r0.c0.m0')]);
self::assertStringContainsString('Typ: Beiträge', self::problems($inTerm), 'refused when sent alone');
$both = $this->changeAll([self::metaChange('s0.r0.c0.m0'), self::metaChange('s1.r0.c0.m0')]);
self::assertStringContainsString('changes[1]', implode(' ', array_keys(self::errorFields($both))));
self::assertStringContainsString('passt nicht zur Schleife', self::problems($both));
self::assertSame([], $this->saved);
$plain = $this->changeAll([self::metaChange('s0.r0.c0.m0')]);
self::assertTrue($plain['ok'], (string) json_encode($plain));
}
/** Re-review (M1): an outer loop switched to another kind in the same call refuses meta key content below. */
public function testSwitchingTheOuterLoopRefusesMetaKeyContentOfTheInnerLoop(): void
{
$this->useTwoSectionPage();
$refused = $this->changeAll([
['id' => 's0', 'attrs' => ['module.advanced.loop' => ['desktop' => self::TERM_LOOP]]],
self::metaChange('s0.r0.c0.m0'),
]);
self::assertStringContainsString('changes[1]', implode(' ', array_keys(self::errorFields($refused))));
self::assertSame([], $this->saved);
}
}