Loosen-IT/WP-LIT-MCP
3
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 7 Wiki Activity

fix: typed write failures, template rollback, parent and term cleanup

Browse Source 
WriteFailed maps to lit_write_failed / lit_partial_write (partial writes are
logged with result partial); old template read before the update; row marker
set before wp_update_post; created terms deleted on rollback; parent must be a
readable non-descendant of a hierarchical type; featured image must be
readable; snapshot keeps empty values; meta comparison after sanitize_meta;
follow-up failures (listener, change log) only add warnings.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01At3V6SjwbMe6eMzVGW3Hs7
This commit is contained in:
janniclas.loosen
2026-09-25 23:11:18 +02:00
co-authored by Claude Opus 5.5
parent 4f9a47fe32
commit a9b2f2db71
18 changed files with 934 additions and 130 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/Unit/Integrations/WordPress/Content/ContentCreateAbilityTest.php
+125 -17
View File
@@ -8,17 +8,21 @@ use Brain\Monkey\Actions;
use Brain\Monkey\Functions;
use LIT\MCP\Abilities\Errors;
use LIT\MCP\Abilities\Rev;
use LIT\MCP\Abilities\WriteFailed;
use LIT\MCP\ChangeLog\ChangeLog;
use LIT\MCP\Integrations\WordPress\Content\ContentCreateAbility;
use LIT\MCP\Integrations\WordPress\Content\PostWriter;
use LIT\MCP\Integrations\WordPress\Schema\ContentSchema;
use LIT\MCP\Tests\Unit\TestCase;
use Mockery;
use Mockery\MockInterface;
use RuntimeException;
use WP_Post;
final class ContentCreateAbilityTest extends TestCase
{
private const INPUT = ['post_type' => 'lit_person', 'title' => 'Anna', 'fields' => ['role' => 'Leitung']];
private function schema(): ContentSchema
{
Functions\when('get_post_type_object')->justReturn((object) ['cap' => (object) ['create_posts' => 'edit_pages']]);
@@ -29,6 +33,38 @@ final class ContentCreateAbilityTest extends TestCase
return $schema;
}
/** @return PostWriter&MockInterface */
private function writer(array $warnings = []): PostWriter
{
$writer = Mockery::mock(PostWriter::class);
$writer->allows('prepare')->andReturn(['fields' => ['role' => 'Leitung'], 'terms' => [], 'warnings' => $warnings]);
$writer->allows('postData')->andReturn(['post_title' => 'Anna']);
Functions\when('get_current_user_id')->justReturn(3);
return $writer;
}
private function execute(PostWriter $writer, ChangeLog $log): WriteFailed
{
try {
(new ContentCreateAbility($this->schema(), $writer, $log))->execute(self::INPUT);
} catch (WriteFailed $e) {
return $e;
}
self::fail('WriteFailed expected');
}
private function stubResultLinks(): WP_Post
{
$post = new WP_Post(['ID' => 42, 'post_title' => 'Anna', 'post_type' => 'lit_person']);
Functions\when('get_post')->justReturn($post);
Functions\when('get_preview_post_link')->justReturn('https://kunde.de/?p=42&preview=true');
Functions\when('get_edit_post_link')->justReturn('https://kunde.de/wp-admin/post.php?post=42&action=edit');
return $post;
}
public function testInvalidInputWritesNothing(): void
{
$writer = Mockery::mock(PostWriter::class);
@@ -45,7 +81,7 @@ final class ContentCreateAbilityTest extends TestCase
{
$schema = $this->schema();
$prepared = ['fields' => ['role' => 'Leitung'], 'terms' => [], 'warnings' => ['w']];
$input = ['post_type' => 'lit_person', 'title' => 'Anna', 'fields' => ['role' => 'Leitung']];
$input = self::INPUT;
$writer = Mockery::mock(PostWriter::class);
$writer->allows('prepare')->with('lit_person', $input, true)->andReturn($prepared);
$writer->allows('postData')->andReturn(['post_title' => 'Anna']);
@@ -58,10 +94,7 @@ final class ContentCreateAbilityTest extends TestCase
'post_author' => 3,
], true)->andReturn(42);
Actions\expectDone('lit_mcp_after_save')->once()->with(42, 'lit/content-create', $input);
$post = new WP_Post(['ID' => 42, 'post_title' => 'Anna', 'post_type' => 'lit_person']);
Functions\when('get_post')->justReturn($post);
Functions\when('get_preview_post_link')->justReturn('https://kunde.de/?p=42&preview=true');
Functions\when('get_edit_post_link')->justReturn('https://kunde.de/wp-admin/post.php?post=42&action=edit');
$post = $this->stubResultLinks();
$log = Mockery::mock(ChangeLog::class);
$log->expects('record')->with('lit/content-create', 'lit_person', '42', 'Entwurf "Anna" angelegt')->andReturn(7);
@@ -75,28 +108,103 @@ final class ContentCreateAbilityTest extends TestCase
self::assertSame(Rev::ofPost($post), $result['rev']);
}
public function testFailingExtrasDeleteTheNewDraftAndNothingIsLogged(): void
public function testFailingExtrasDeleteCreatedTermsAndTheNewDraft(): void
{
$schema = $this->schema();
$input = ['post_type' => 'lit_person', 'title' => 'Anna', 'fields' => ['role' => 'Leitung']];
$writer = Mockery::mock(PostWriter::class);
$writer->allows('prepare')->andReturn(['fields' => ['role' => 'Leitung'], 'terms' => [], 'warnings' => []]);
$writer->allows('postData')->andReturn(['post_title' => 'Anna']);
$writer = $this->writer();
$writer->expects('writeExtras')->andThrow(new RuntimeException('Pods could not save the fields.'));
Functions\when('get_current_user_id')->justReturn(3);
$writer->expects('deleteCreatedTerms');
Functions\when('wp_insert_post')->justReturn(42);
Functions\expect('wp_delete_post')->once()->with(42, true)->andReturn(new WP_Post(['ID' => 42]));
Actions\expectDone('lit_mcp_after_save')->never();
$log = Mockery::mock(ChangeLog::class);
$log->expects('record')->never();
$failure = $this->execute($writer, $log);
self::assertTrue($failure->rolledBack);
self::assertStringContainsString('Pods could not save the fields.', $failure->getMessage());
self::assertSame('lit_write_failed', $failure->toError()->get_error_code());
}
public function testADraftThatCannotBeDeletedIsAPartialWriteAndLogged(): void
{
$writer = $this->writer();
$writer->expects('writeExtras')->andThrow(new RuntimeException('meta kaputt'));
$writer->expects('deleteCreatedTerms');
Functions\when('wp_insert_post')->justReturn(42);
Functions\when('wp_delete_post')->justReturn(false);
$log = Mockery::mock(ChangeLog::class);
$log->expects('record')
->with('lit/content-create', 'lit_person', '42', Mockery::type('string'), null, null, 'partial')
->andReturn(9);
$failure = $this->execute($writer, $log);
self::assertFalse($failure->rolledBack);
self::assertSame(42, $failure->postId);
self::assertStringContainsString('Eintrag 42', $failure->toError()->get_error_message());
}
public function testLeftoverCreatedTermsMakeItAPartialWrite(): void
{
$writer = $this->writer();
$writer->expects('writeExtras')->andThrow(new RuntimeException('meta kaputt'));
$writer->expects('deleteCreatedTerms')->andThrow(new RuntimeException('term 15 bleibt'));
Functions\when('wp_insert_post')->justReturn(42);
Functions\when('wp_delete_post')->justReturn(new WP_Post(['ID' => 42]));
$log = Mockery::mock(ChangeLog::class);
$log->expects('record')->andReturn(9);
$failure = $this->execute($writer, $log);
self::assertFalse($failure->rolledBack);
self::assertStringContainsString('term 15 bleibt', $failure->getMessage());
}
public function testAnInsertThatThrowsIsAPartialWriteWithoutId(): void
{
$writer = $this->writer();
Functions\when('wp_insert_post')->alias(static function (): never {
throw new RuntimeException('save_post hook kaputt');
});
$log = Mockery::mock(ChangeLog::class);
$log->expects('record')
->with('lit/content-create', 'lit_person', '', Mockery::type('string'), null, null, 'partial')
->andReturn(9);
$failure = $this->execute($writer, $log);
self::assertFalse($failure->rolledBack);
self::assertNull($failure->postId);
self::assertSame('lit_partial_write', $failure->toError()->get_error_code());
}
public function testFailuresAfterTheWriteOnlyAddWarnings(): void
{
$writer = $this->writer(['w']);
$writer->allows('writeExtras');
Functions\when('wp_insert_post')->justReturn(42);
$this->stubResultLinks();
Actions\expectDone('lit_mcp_after_save')->once()->whenHappen(static function (): void {
throw new RuntimeException('listener kaputt');
});
$log = Mockery::mock(ChangeLog::class);
$log->expects('record')->andThrow(new RuntimeException('db weg'));
$file = (string) tempnam(sys_get_temp_dir(), 'lit-mcp-log');
$previous = ini_set('error_log', $file);
try {
(new ContentCreateAbility($schema, $writer, $log))->execute($input);
self::fail('RuntimeException expected');
} catch (RuntimeException $e) {
self::assertStringContainsString('Pods could not save the fields.', $e->getMessage());
self::assertStringContainsString('deleted', $e->getMessage());
$result = (new ContentCreateAbility($this->schema(), $writer, $log))->execute(self::INPUT);
} finally {
ini_set('error_log', (string) $previous);
}
self::assertTrue($result['ok']);
self::assertNull($result['log_id']);
self::assertCount(3, $result['warnings']);
self::assertStringContainsString('listener kaputt', (string) file_get_contents($file));
self::assertStringContainsString('db weg', (string) file_get_contents($file));
unlink($file);
}
public function testStatusIsNotAnInputAndPermissionNeedsCreateRights(): void