fix: never publish a missed schedule, refuse trashed posts, fail on meta read errors

- PostGuard::editable() refuses trashed entries unless the caller opts in
  (content-get, revisions-list, post-trash); publish/schedule/unpublish/update/
  restore/duplicate/replace now refuse them.
- PostGuard::statusStable(): content-update, revision-restore and
  replace-with-copy refuse a future post whose date has passed (any save would
  publish it); the content-update rollback and PostCloner row writes re-check.
- PostCloner::ownMeta() treats a failed SELECT as an error; replace() reads the
  copy before its first write.
- replace-with-copy needs create_posts (backup clone) and reports backup_id in
  write_failed/partial_write.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01At3V6SjwbMe6eMzVGW3Hs7

tests/Stubs/Wpdb.php

@@ -16,6 +16,7 @@ if (! class_exists('wpdb')) {
         public $usermeta = 'wp_usermeta';
         public $options = 'wp_options';
         public $insert_id = 0;
+        public $last_error = '';
 
         public function prepare($query, ...$args)
         {

tests/Unit/Abilities/WriteFailedTest.php

@@ -46,4 +46,13 @@ final class WriteFailedTest extends TestCase
         self::assertSame('Mit lit-menu-get prüfen.', $error->get_error_data()['hint']);
         self::assertSame(3, $error->get_error_data()['menu_id']);
     }
+
+    public function testCleanRollbackKeepsItsDetails(): void
+    {
+        $error = (new WriteFailed('Nicht übernommen.', true, details: ['backup_id' => 88]))->toError();
+
+        self::assertSame('lit_write_failed', $error->get_error_code());
+        self::assertSame(88, $error->get_error_data()['backup_id']);
+        self::assertStringContainsString('"backup_id":88', $error->get_error_message());
+    }
 }

tests/Unit/Integrations/WordPress/Content/ContentGetAbilityTest.php

@@ -29,6 +29,19 @@ final class ContentGetAbilityTest extends TestCase
         self::assertSame(['id' => 5], $ability->execute(['post_id' => 5]));
     }
 
+    public function testATrashedPostCanStillBeRead(): void
+    {
+        $post = new WP_Post(['ID' => 5, 'post_type' => 'page', 'post_status' => 'trash']);
+        Functions\when('get_post')->justReturn($post);
+        Functions\when('current_user_can')->justReturn(true);
+        $schema = Mockery::mock(ContentSchema::class);
+        $schema->allows('isManaged')->andReturn(true);
+        $presenter = Mockery::mock(PostPresenter::class);
+        $presenter->expects('full')->with($post)->andReturn(['id' => 5]);
+
+        self::assertSame(['id' => 5], (new ContentGetAbility($schema, $presenter))->execute(['post_id' => 5]));
+    }
+
     public function testMissingPostIsNotFound(): void
     {
         Functions\when('get_post')->justReturn(null);

tests/Unit/Integrations/WordPress/Content/ContentUpdateAbilityTest.php

@@ -61,6 +61,32 @@ final class ContentUpdateAbilityTest extends TestCase
         );
     }
 
+    public function testATrashedPostIsRefused(): void
+    {
+        $this->post->post_status = 'trash';
+        Functions\expect('wp_update_post')->never();
+
+        $result = $this->ability(Mockery::mock(PostWriter::class))
+            ->execute(['post_id' => 5, 'rev' => Rev::ofPost($this->post), 'title' => 'Neu']);
+
+        self::assertSame('lit_validation_failed', $result->get_error_code());
+    }
+
+    public function testAMissedScheduleIsRefusedBecauseSavingWouldPublish(): void
+    {
+        $this->post->post_status = 'future';
+        $this->post->post_date_gmt = gmdate('Y-m-d H:i:s', time() - 600);
+        Functions\expect('wp_update_post')->never();
+        Functions\expect('wp_save_post_revision')->never();
+
+        $result = $this->ability(Mockery::mock(PostWriter::class))
+            ->execute(['post_id' => 5, 'rev' => Rev::ofPost($this->post), 'title' => 'Neu']);
+
+        self::assertSame('lit_validation_failed', $result->get_error_code());
+        self::assertArrayHasKey('post_id', $result->get_error_data()['fields']);
+        self::assertStringContainsString('lit/post-schedule', $result->get_error_data()['hint']);
+    }
+
     public function testStaleRevIsRejectedWithoutWriting(): void
     {
         Functions\expect('wp_update_post')->never();
@@ -254,6 +280,30 @@ final class ContentUpdateAbilityTest extends TestCase
         self::assertSame(['post_name' => 'team', 'ID' => 5], $updates[1]);
     }
 
+    public function testTheRollbackNeverRewritesARowWhoseScheduleHasPassedMeanwhile(): void
+    {
+        [$writer, $input] = $this->failingWriter(['post_name' => 'unser-team']);
+        $post = $this->post;
+        $updates = [];
+        Functions\when('wp_update_post')->alias(static function (array $data) use (&$updates, $post): int {
+            $updates[] = $data;
+            // The entry turned into a missed schedule while the call ran (e.g. edited in WordPress).
+            $post->post_status = 'future';
+            $post->post_date_gmt = gmdate('Y-m-d H:i:s', time() - 5);
+            return 5;
+        });
+        Functions\when('wp_revisions_enabled')->justReturn(true);
+        Functions\expect('wp_restore_post_revision')->never();
+        $log = Mockery::mock(ChangeLog::class);
+        $log->expects('recordPartial');
+
+        $failure = $this->executeExpectingFailure($writer, $input, $log);
+
+        self::assertFalse($failure->rolledBack);
+        self::assertCount(1, $updates);
+        self::assertStringContainsString('publish', $failure->getMessage());
+    }
+
     public function testAnIncompleteRollbackIsAPartialWriteAndLogged(): void
     {
         [$writer, $input] = $this->failingWriter(['post_title' => 'Unser Team'], false);

tests/Unit/Integrations/WordPress/PostGuardTest.php

@@ -47,6 +47,44 @@ final class PostGuardTest extends TestCase
         self::assertSame('lit_forbidden', PostGuard::editable(5, $this->schema())->get_error_code());
     }
 
+    public function testTrashedPostsAreRefusedUnlessAllowed(): void
+    {
+        $post = new WP_Post(['ID' => 5, 'post_type' => 'page', 'post_status' => 'trash']);
+        Functions\when('get_post')->justReturn($post);
+        Functions\when('current_user_can')->justReturn(true);
+
+        $error = PostGuard::editable(5, $this->schema(), 'copy_id');
+        self::assertSame('lit_validation_failed', $error->get_error_code());
+        self::assertArrayHasKey('copy_id', $error->get_error_data()['fields']);
+        self::assertSame($post, PostGuard::editable(5, $this->schema(), 'post_id', true));
+    }
+
+    public function testMissedScheduleIsAFuturePostWhoseDateHasPassed(): void
+    {
+        $past = gmdate('Y-m-d H:i:s', time() - 3600);
+        $future = gmdate('Y-m-d H:i:s', time() + 3600);
+
+        self::assertTrue(PostGuard::missedSchedule(new WP_Post(['post_status' => 'future', 'post_date_gmt' => $past])));
+        self::assertFalse(PostGuard::missedSchedule(new WP_Post(['post_status' => 'future', 'post_date_gmt' => $future])));
+        self::assertFalse(PostGuard::missedSchedule(new WP_Post(['post_status' => 'draft', 'post_date_gmt' => $past])));
+        self::assertFalse(PostGuard::missedSchedule(
+            new WP_Post(['post_status' => 'future', 'post_date_gmt' => '0000-00-00 00:00:00'])
+        ));
+    }
+
+    public function testStatusStableRefusesAMissedScheduleWithAHint(): void
+    {
+        $post = new WP_Post(['ID' => 5, 'post_status' => 'future', 'post_date_gmt' => gmdate('Y-m-d H:i:s', time() - 60)]);
+
+        $error = PostGuard::statusStable($post, 'original_id');
+
+        self::assertSame('lit_validation_failed', $error->get_error_code());
+        self::assertArrayHasKey('original_id', $error->get_error_data()['fields']);
+        self::assertStringContainsString('lit-post-publish', $error->get_error_data()['hint']);
+        self::assertStringContainsString('lit/post-schedule', $error->get_error_data()['hint']);
+        self::assertNull(PostGuard::statusStable(new WP_Post(['post_status' => 'publish'])));
+    }
+
     public function testPostTypeChecksAvailabilityAndCapability(): void
     {
         $object = (object) ['cap' => (object) ['create_posts' => 'edit_pages']];

tests/Unit/Integrations/WordPress/Revisions/RevisionRestoreAbilityTest.php

@@ -76,6 +76,45 @@ final class RevisionRestoreAbilityTest extends TestCase
         self::assertArrayHasKey('revision_id', $error->get_error_data()['fields']);
     }
 
+    public function testATrashedEntryIsRefused(): void
+    {
+        Functions\when('get_post')->alias(static fn (int $id) => match ($id) {
+            810 => new WP_Post(['ID' => 810, 'post_type' => 'revision', 'post_parent' => 5]),
+            5 => new WP_Post(array_merge(self::CURRENT_POST, ['post_status' => 'trash'])),
+            default => null,
+        });
+        Functions\expect('wp_restore_post_revision')->never();
+
+        $error = $this->ability(Mockery::mock(ChangeLog::class))->execute(['revision_id' => 810, 'rev' => 'x', 'confirm' => true]);
+
+        self::assertSame('lit_validation_failed', $error->get_error_code());
+        self::assertArrayHasKey('revision_id', $error->get_error_data()['fields']);
+    }
+
+    public function testAMissedScheduleIsRefusedBecauseRestoringWouldPublish(): void
+    {
+        $current = array_merge(self::CURRENT_POST, [
+            'post_status' => 'future',
+            'post_date_gmt' => gmdate('Y-m-d H:i:s', time() - 600),
+        ]);
+        Functions\when('get_post')->alias(static fn (int $id) => match ($id) {
+            810 => new WP_Post(['ID' => 810, 'post_type' => 'revision', 'post_parent' => 5]),
+            5 => new WP_Post($current),
+            default => null,
+        });
+        Functions\expect('wp_save_post_revision')->never();
+        Functions\expect('wp_restore_post_revision')->never();
+
+        $error = $this->ability(Mockery::mock(ChangeLog::class))->execute([
+            'revision_id' => 810,
+            'rev' => Rev::ofPost(new WP_Post($current)),
+            'confirm' => true,
+        ]);
+
+        self::assertSame('lit_validation_failed', $error->get_error_code());
+        self::assertStringContainsString('lit-post-publish', $error->get_error_data()['hint']);
+    }
+
     public function testMissingOrStaleRevIsRevMismatch(): void
     {
         Functions\expect('wp_restore_post_revision')->never();

tests/Unit/Integrations/WordPress/Revisions/RevisionsListAbilityTest.php

@@ -69,6 +69,14 @@ final class RevisionsListAbilityTest extends TestCase
         self::assertSame([PostPresenter::DIVI_HINT], $result['hints']);
     }
 
+    public function testRevisionsOfATrashedPostCanStillBeListed(): void
+    {
+        Functions\when('get_post')->justReturn(new WP_Post(['ID' => 5, 'post_type' => 'page', 'post_status' => 'trash']));
+        Functions\when('wp_get_post_revisions')->justReturn([]);
+
+        self::assertSame([], $this->ability()->execute(['post_id' => 5])['items']);
+    }
+
     public function testInvalidCursorIsRejected(): void
     {
         $result = $this->ability()->execute(['post_id' => 5, 'cursor' => 'not-a-cursor']);

tests/Unit/Integrations/WordPress/Status/PostClonerTest.php

@@ -24,17 +24,30 @@ final class PostClonerTest extends TestCase
 
     private bool $insertFails = false;
 
+    /** Post IDs whose meta SELECT fails: 'null' returns null, 'error' sets $wpdb->last_error. */
+    private array $metaReadFails = [];
+
     protected function setUp(): void
     {
         parent::setUp();
         Functions\when('wp_cache_delete')->justReturn(true);
+        Functions\when('get_post')->justReturn(null);
     }
 
     private function cloner(): PostCloner
     {
         $db = Mockery::mock(\wpdb::class)->makePartial();
-        $db->allows('get_results')->andReturnUsing(function (string $sql): array {
+        $db->allows('get_results')->andReturnUsing(function (string $sql) use ($db): ?array {
             preg_match('/post_id = (\d+)/', $sql, $match);
+            $db->last_error = '';
+            $failure = $this->metaReadFails[(int) $match[1]] ?? null;
+            if ($failure === 'null') {
+                return null;
+            }
+            if ($failure === 'error') {
+                $db->last_error = 'Table wp_postmeta is marked as crashed';
+                return [];
+            }
             $rows = [];
             foreach ($this->meta[(int) $match[1]] ?? [] as $key => $values) {
                 foreach ($values as $value) {
@@ -246,6 +259,7 @@ final class PostClonerTest extends TestCase
 
     public function testAReplaceRejectedByWordPressNamesOnlyThePostRow(): void
     {
+        Functions\when('get_object_taxonomies')->justReturn([]);
         Functions\when('wp_update_post')->justReturn(new WP_Error('x', 'kaputt'));
         Functions\expect('delete_post_meta')->never();
 
@@ -272,6 +286,96 @@ final class PostClonerTest extends TestCase
         }
     }
 
+    /** @return array<string, array{0: string}> */
+    public function metaReadFailures(): array
+    {
+        return ['null result' => ['null'], 'database error' => ['error']];
+    }
+
+    /** @dataProvider metaReadFailures */
+    public function testAFailedMetaReadIsAnErrorNotEmptyMeta(string $failure): void
+    {
+        $this->metaReadFails = [5 => $failure];
+        Functions\when('get_object_taxonomies')->justReturn([]);
+
+        $this->expectException(RuntimeException::class);
+        $this->expectExceptionMessage('Meta of post 5 could not be read');
+
+        $this->cloner()->snapshot($this->original());
+    }
+
+    /** @dataProvider metaReadFailures */
+    public function testReplaceReadsTheCopyBeforeWritingAnything(string $failure): void
+    {
+        $this->metaReadFails = [77 => $failure];
+        Functions\when('get_object_taxonomies')->justReturn([]);
+        Functions\expect('wp_update_post')->never();
+        Functions\expect('delete_post_meta')->never();
+
+        try {
+            $this->cloner()->replace($this->original(), $this->copy());
+            self::fail('ReplaceFailed expected');
+        } catch (ReplaceFailed $e) {
+            self::assertSame([], $e->parts);
+            self::assertStringContainsString('Meta of post 77 could not be read', $e->getMessage());
+        }
+    }
+
+    public function testADuplicateWithAFailedMetaReadIsDeletedAgain(): void
+    {
+        $this->metaReadFails = [5 => 'error'];
+        Functions\when('get_current_user_id')->justReturn(3);
+        Functions\when('wp_insert_post')->justReturn(90);
+        Functions\expect('wp_delete_post')->once()->with(90, true)->andReturn(new WP_Post(['ID' => 90]));
+
+        try {
+            $this->cloner()->duplicate($this->original());
+            self::fail('WriteFailed expected');
+        } catch (WriteFailed $e) {
+            self::assertTrue($e->rolledBack);
+        }
+    }
+
+    private function missedSchedule(): void
+    {
+        Functions\when('get_post')->justReturn(new WP_Post([
+            'ID' => 5,
+            'post_type' => 'page',
+            'post_status' => 'future',
+            'post_date_gmt' => gmdate('Y-m-d H:i:s', time() - 60),
+        ]));
+    }
+
+    public function testReplaceRefusesAMissedScheduleBeforeWriting(): void
+    {
+        $this->missedSchedule();
+        Functions\when('get_object_taxonomies')->justReturn([]);
+        Functions\expect('wp_update_post')->never();
+
+        try {
+            $this->cloner()->replace($this->original(), $this->copy());
+            self::fail('ReplaceFailed expected');
+        } catch (ReplaceFailed $e) {
+            self::assertSame([], $e->parts);
+            self::assertStringContainsString('missed schedule', $e->getMessage());
+        }
+    }
+
+    public function testRestoreNeverRewritesTheRowOfAMissedSchedule(): void
+    {
+        $this->missedSchedule();
+        Functions\expect('wp_update_post')->never();
+
+        $this->expectException(RuntimeException::class);
+        $this->expectExceptionMessage('missed schedule');
+
+        $this->cloner()->restore($this->original(), [
+            'post' => ['post_title' => 'Team', 'post_content' => '', 'post_excerpt' => ''],
+            'meta' => [],
+            'terms' => [],
+        ], ['post']);
+    }
+
     public function testSnapshotAndRestoreBringBackRowMetaAndTerms(): void
     {
         $this->meta = [5 => ['_edit_lock' => ['1'], 'role' => ['b:0;']]];

tests/Unit/Integrations/WordPress/Status/PostPublishAbilityTest.php

@@ -74,6 +74,16 @@ final class PostPublishAbilityTest extends TestCase
         self::assertStringContainsString('bereits veröffentlicht', $result['summary']);
     }
 
+    public function testATrashedPostIsRefused(): void
+    {
+        $this->stubPost(['post_status' => 'trash']);
+        Functions\expect('wp_update_post')->never();
+
+        $result = $this->ability(Mockery::mock(ChangeLog::class))->execute(['post_id' => 5]);
+
+        self::assertSame('lit_validation_failed', $result->get_error_code());
+    }
+
     public function testPermissionNeedsPublishRights(): void
     {
         $this->stubPost(['post_status' => 'draft']);

tests/Unit/Integrations/WordPress/Status/PostReplaceWithCopyAbilityTest.php

@@ -31,6 +31,7 @@ final class PostReplaceWithCopyAbilityTest extends TestCase
         $this->copy = new WP_Post(['ID' => 77, 'post_type' => 'page', 'post_title' => 'Team (Kopie)', 'post_status' => 'draft']);
         Functions\when('get_post')->alias(fn (int $id) => $id === 5 ? $this->original : $this->copy);
         Functions\when('current_user_can')->justReturn(true);
+        Functions\when('get_post_type_object')->justReturn((object) ['cap' => (object) ['create_posts' => 'edit_pages']]);
         Functions\when('get_post_meta')->justReturn('5');
         Functions\when('get_permalink')->justReturn('https://kunde.de/team/');
         Functions\when('get_edit_post_link')->justReturn('https://kunde.de/wp-admin/post.php?post=5&action=edit');
@@ -105,6 +106,20 @@ final class PostReplaceWithCopyAbilityTest extends TestCase
         self::assertSame('lit_validation_failed', $result->get_error_code());
     }
 
+    public function testAMissedScheduleOfTheOriginalIsRefused(): void
+    {
+        $this->original->post_status = 'future';
+        $this->original->post_date_gmt = gmdate('Y-m-d H:i:s', time() - 600);
+        $cloner = Mockery::mock(PostCloner::class);
+        $cloner->expects('backup')->never();
+        $cloner->expects('replace')->never();
+
+        $result = $this->ability($cloner, Mockery::mock(ChangeLog::class))->execute($this->input());
+
+        self::assertSame('lit_validation_failed', $result->get_error_code());
+        self::assertArrayHasKey('original_id', $result->get_error_data()['fields']);
+    }
+
     public function testAPendingCopyIsAccepted(): void
     {
         $this->copy->post_status = 'pending';
@@ -215,6 +230,7 @@ final class PostReplaceWithCopyAbilityTest extends TestCase
         } catch (WriteFailed $e) {
             self::assertTrue($e->rolledBack);
             self::assertSame('lit_write_failed', $e->toError()->get_error_code());
+            self::assertSame(88, $e->toError()->get_error_data()['backup_id']);
         }
     }
 
@@ -239,10 +255,26 @@ final class PostReplaceWithCopyAbilityTest extends TestCase
             self::assertFalse($e->rolledBack);
             self::assertSame(5, $e->postId);
             self::assertSame(900, $e->revisionId);
-            self::assertSame('lit_partial_write', $e->toError()->get_error_code());
+            $error = $e->toError();
+            self::assertSame('lit_partial_write', $error->get_error_code());
+            self::assertSame(88, $error->get_error_data()['backup_id']);
+            self::assertStringContainsString('Sicherung', $error->get_error_message());
+            self::assertStringContainsString('88', $error->get_error_message());
         }
     }
 
+    public function testNeedsTheRightToCreateEntriesForTheBackup(): void
+    {
+        Functions\when('current_user_can')->alias(static fn (string $cap): bool => $cap !== 'edit_pages');
+        $cloner = Mockery::mock(PostCloner::class);
+        $cloner->expects('backup')->never();
+        $cloner->expects('replace')->never();
+        $ability = $this->ability($cloner, Mockery::mock(ChangeLog::class));
+
+        self::assertSame('lit_forbidden', $ability->permission($this->input())->get_error_code());
+        self::assertSame('lit_forbidden', $ability->execute($this->input())->get_error_code());
+    }
+
     public function testAFailedBackupAbortsBeforeTheOriginalIsTouched(): void
     {
         $cloner = Mockery::mock(PostCloner::class);

tests/Unit/Integrations/WordPress/Status/PostScheduleAbilityTest.php

@@ -52,6 +52,16 @@ final class PostScheduleAbilityTest extends TestCase
         self::assertStringContainsString('2099-06-01 09:30', $result['summary']);
     }
 
+    public function testATrashedPostIsRefused(): void
+    {
+        Functions\when('get_post')->justReturn(new WP_Post(['ID' => 5, 'post_type' => 'post', 'post_status' => 'trash']));
+        Functions\expect('wp_update_post')->never();
+
+        $result = $this->ability(Mockery::mock(ChangeLog::class))->execute(['post_id' => 5, 'date' => '2099-06-01 09:30']);
+
+        self::assertSame('lit_validation_failed', $result->get_error_code());
+    }
+
     public function testPastAndImpossibleDatesAreRejected(): void
     {
         Functions\expect('wp_update_post')->never();

tests/Unit/Integrations/WordPress/Status/PostTrashAbilityTest.php

@@ -60,6 +60,18 @@ final class PostTrashAbilityTest extends TestCase
         self::assertSame('lit_unsupported', $result->get_error_code());
     }
 
+    public function testAnAlreadyTrashedPostIsANoOp(): void
+    {
+        $ability = $this->ability(Mockery::mock(ChangeLog::class));
+        Functions\when('get_post')->justReturn(new WP_Post(['ID' => 5, 'post_type' => 'page', 'post_title' => 'Alt', 'post_status' => 'trash']));
+        Functions\expect('wp_trash_post')->never();
+
+        $result = $ability->execute(['post_id' => 5, 'confirm' => true]);
+
+        self::assertSame([], $result['changed']);
+        self::assertStringContainsString('bereits im Papierkorb', $result['summary']);
+    }
+
     public function testIsDestructiveAndIndirect(): void
     {
         $ability = $this->ability(Mockery::mock(ChangeLog::class));

tests/Unit/Integrations/WordPress/Status/PostUnpublishAbilityTest.php

@@ -37,6 +37,15 @@ final class PostUnpublishAbilityTest extends TestCase
         self::assertSame('unpublished', $result['changed'][0]['action']);
     }
 
+    public function testATrashedPostIsRefusedInsteadOfBecomingADraft(): void
+    {
+        Functions\expect('wp_update_post')->never();
+
+        $result = $this->ability(Mockery::mock(ChangeLog::class), 'trash')->execute(['post_id' => 5]);
+
+        self::assertSame('lit_validation_failed', $result->get_error_code());
+    }
+
     public function testDraftIsANoOp(): void
     {
         Functions\expect('wp_update_post')->never();