fix: never publish a missed schedule, refuse trashed posts, fail on meta read errors

- PostGuard::editable() refuses trashed entries unless the caller opts in
  (content-get, revisions-list, post-trash); publish/schedule/unpublish/update/
  restore/duplicate/replace now refuse them.
- PostGuard::statusStable(): content-update, revision-restore and
  replace-with-copy refuse a future post whose date has passed (any save would
  publish it); the content-update rollback and PostCloner row writes re-check.
- PostCloner::ownMeta() treats a failed SELECT as an error; replace() reads the
  copy before its first write.
- replace-with-copy needs create_posts (backup clone) and reports backup_id in
  write_failed/partial_write.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01At3V6SjwbMe6eMzVGW3Hs7
This commit is contained in:
2026-09-26 01:20:21 +02:00
co-authored by Claude Opus 5.5
parent 6a7193424c
commit d831cf59ca
24 changed files with 501 additions and 43 deletions
@@ -47,6 +47,44 @@ final class PostGuardTest extends TestCase
self::assertSame('lit_forbidden', PostGuard::editable(5, $this->schema())->get_error_code());
}
public function testTrashedPostsAreRefusedUnlessAllowed(): void
{
$post = new WP_Post(['ID' => 5, 'post_type' => 'page', 'post_status' => 'trash']);
Functions\when('get_post')->justReturn($post);
Functions\when('current_user_can')->justReturn(true);
$error = PostGuard::editable(5, $this->schema(), 'copy_id');
self::assertSame('lit_validation_failed', $error->get_error_code());
self::assertArrayHasKey('copy_id', $error->get_error_data()['fields']);
self::assertSame($post, PostGuard::editable(5, $this->schema(), 'post_id', true));
}
public function testMissedScheduleIsAFuturePostWhoseDateHasPassed(): void
{
$past = gmdate('Y-m-d H:i:s', time() - 3600);
$future = gmdate('Y-m-d H:i:s', time() + 3600);
self::assertTrue(PostGuard::missedSchedule(new WP_Post(['post_status' => 'future', 'post_date_gmt' => $past])));
self::assertFalse(PostGuard::missedSchedule(new WP_Post(['post_status' => 'future', 'post_date_gmt' => $future])));
self::assertFalse(PostGuard::missedSchedule(new WP_Post(['post_status' => 'draft', 'post_date_gmt' => $past])));
self::assertFalse(PostGuard::missedSchedule(
new WP_Post(['post_status' => 'future', 'post_date_gmt' => '0000-00-00 00:00:00'])
));
}
public function testStatusStableRefusesAMissedScheduleWithAHint(): void
{
$post = new WP_Post(['ID' => 5, 'post_status' => 'future', 'post_date_gmt' => gmdate('Y-m-d H:i:s', time() - 60)]);
$error = PostGuard::statusStable($post, 'original_id');
self::assertSame('lit_validation_failed', $error->get_error_code());
self::assertArrayHasKey('original_id', $error->get_error_data()['fields']);
self::assertStringContainsString('lit-post-publish', $error->get_error_data()['hint']);
self::assertStringContainsString('lit/post-schedule', $error->get_error_data()['hint']);
self::assertNull(PostGuard::statusStable(new WP_Post(['post_status' => 'publish'])));
}
public function testPostTypeChecksAvailabilityAndCapability(): void
{
$object = (object) ['cap' => (object) ['create_posts' => 'edit_pages']];