fix: never publish a missed schedule, refuse trashed posts, fail on meta read errors

- PostGuard::editable() refuses trashed entries unless the caller opts in
  (content-get, revisions-list, post-trash); publish/schedule/unpublish/update/
  restore/duplicate/replace now refuse them.
- PostGuard::statusStable(): content-update, revision-restore and
  replace-with-copy refuse a future post whose date has passed (any save would
  publish it); the content-update rollback and PostCloner row writes re-check.
- PostCloner::ownMeta() treats a failed SELECT as an error; replace() reads the
  copy before its first write.
- replace-with-copy needs create_posts (backup clone) and reports backup_id in
  write_failed/partial_write.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01At3V6SjwbMe6eMzVGW3Hs7
This commit is contained in:
2026-09-26 01:20:21 +02:00
co-authored by Claude Opus 5.5
parent 6a7193424c
commit d831cf59ca
24 changed files with 501 additions and 43 deletions
@@ -24,17 +24,30 @@ final class PostClonerTest extends TestCase
private bool $insertFails = false;
/** Post IDs whose meta SELECT fails: 'null' returns null, 'error' sets $wpdb->last_error. */
private array $metaReadFails = [];
protected function setUp(): void
{
parent::setUp();
Functions\when('wp_cache_delete')->justReturn(true);
Functions\when('get_post')->justReturn(null);
}
private function cloner(): PostCloner
{
$db = Mockery::mock(\wpdb::class)->makePartial();
$db->allows('get_results')->andReturnUsing(function (string $sql): array {
$db->allows('get_results')->andReturnUsing(function (string $sql) use ($db): ?array {
preg_match('/post_id = (\d+)/', $sql, $match);
$db->last_error = '';
$failure = $this->metaReadFails[(int) $match[1]] ?? null;
if ($failure === 'null') {
return null;
}
if ($failure === 'error') {
$db->last_error = 'Table wp_postmeta is marked as crashed';
return [];
}
$rows = [];
foreach ($this->meta[(int) $match[1]] ?? [] as $key => $values) {
foreach ($values as $value) {
@@ -246,6 +259,7 @@ final class PostClonerTest extends TestCase
public function testAReplaceRejectedByWordPressNamesOnlyThePostRow(): void
{
Functions\when('get_object_taxonomies')->justReturn([]);
Functions\when('wp_update_post')->justReturn(new WP_Error('x', 'kaputt'));
Functions\expect('delete_post_meta')->never();
@@ -272,6 +286,96 @@ final class PostClonerTest extends TestCase
}
}
/** @return array<string, array{0: string}> */
public function metaReadFailures(): array
{
return ['null result' => ['null'], 'database error' => ['error']];
}
/** @dataProvider metaReadFailures */
public function testAFailedMetaReadIsAnErrorNotEmptyMeta(string $failure): void
{
$this->metaReadFails = [5 => $failure];
Functions\when('get_object_taxonomies')->justReturn([]);
$this->expectException(RuntimeException::class);
$this->expectExceptionMessage('Meta of post 5 could not be read');
$this->cloner()->snapshot($this->original());
}
/** @dataProvider metaReadFailures */
public function testReplaceReadsTheCopyBeforeWritingAnything(string $failure): void
{
$this->metaReadFails = [77 => $failure];
Functions\when('get_object_taxonomies')->justReturn([]);
Functions\expect('wp_update_post')->never();
Functions\expect('delete_post_meta')->never();
try {
$this->cloner()->replace($this->original(), $this->copy());
self::fail('ReplaceFailed expected');
} catch (ReplaceFailed $e) {
self::assertSame([], $e->parts);
self::assertStringContainsString('Meta of post 77 could not be read', $e->getMessage());
}
}
public function testADuplicateWithAFailedMetaReadIsDeletedAgain(): void
{
$this->metaReadFails = [5 => 'error'];
Functions\when('get_current_user_id')->justReturn(3);
Functions\when('wp_insert_post')->justReturn(90);
Functions\expect('wp_delete_post')->once()->with(90, true)->andReturn(new WP_Post(['ID' => 90]));
try {
$this->cloner()->duplicate($this->original());
self::fail('WriteFailed expected');
} catch (WriteFailed $e) {
self::assertTrue($e->rolledBack);
}
}
private function missedSchedule(): void
{
Functions\when('get_post')->justReturn(new WP_Post([
'ID' => 5,
'post_type' => 'page',
'post_status' => 'future',
'post_date_gmt' => gmdate('Y-m-d H:i:s', time() - 60),
]));
}
public function testReplaceRefusesAMissedScheduleBeforeWriting(): void
{
$this->missedSchedule();
Functions\when('get_object_taxonomies')->justReturn([]);
Functions\expect('wp_update_post')->never();
try {
$this->cloner()->replace($this->original(), $this->copy());
self::fail('ReplaceFailed expected');
} catch (ReplaceFailed $e) {
self::assertSame([], $e->parts);
self::assertStringContainsString('missed schedule', $e->getMessage());
}
}
public function testRestoreNeverRewritesTheRowOfAMissedSchedule(): void
{
$this->missedSchedule();
Functions\expect('wp_update_post')->never();
$this->expectException(RuntimeException::class);
$this->expectExceptionMessage('missed schedule');
$this->cloner()->restore($this->original(), [
'post' => ['post_title' => 'Team', 'post_content' => '', 'post_excerpt' => ''],
'meta' => [],
'terms' => [],
], ['post']);
}
public function testSnapshotAndRestoreBringBackRowMetaAndTerms(): void
{
$this->meta = [5 => ['_edit_lock' => ['1'], 'role' => ['b:0;']]];