fix: gespeichertes false (Divi-Standardschrift) gilt in Theme-Optionen get/update als nicht gesetzt
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This commit is contained in:
co-authored by
Claude Sonnet 5.5
parent
879ca752e7
commit
dab4a9ba2e
@@ -84,6 +84,23 @@ final class DiviThemeOptionsGetAbilityTest extends TestCase
|
||||
self::assertSame('Open Sans', $rows['body_font']['value']);
|
||||
}
|
||||
|
||||
/** Divi stores its default font as false: reported as not set, with the default in effect. */
|
||||
public function testAStoredFalseCountsAsNotSet(): void
|
||||
{
|
||||
$stored = ['heading_font' => false] + ThemeOptionsAreaTest::stored();
|
||||
$writes = [];
|
||||
$ability = new DiviThemeOptionsGetAbility(ThemeOptionsAreaTest::adapter($stored, $writes));
|
||||
|
||||
$result = $ability->execute([]);
|
||||
$row = self::byKey($result)['heading_font'];
|
||||
self::assertSame(ThemeOptionBook::fromDivi($stored)->rev(), $result['design_rev'], 'the rev of the dry run');
|
||||
|
||||
self::assertNull($row['value']);
|
||||
self::assertTrue($row['is_default']);
|
||||
self::assertSame(ThemeOptionSpec::effective('heading_font', []), $row['effective']);
|
||||
self::assertSame($row['effective'], $row['default']);
|
||||
}
|
||||
|
||||
/** Ruling W3: an unset tablet size inherits the desktop size – as effective value and as its default. */
|
||||
public function testUnsetSizesInheritTheLargerSize(): void
|
||||
{
|
||||
|
||||
@@ -280,6 +280,22 @@ final class DiviThemeOptionsUpdateAbilityTest extends TestCase
|
||||
self::assertSame([], $this->writes);
|
||||
}
|
||||
|
||||
/** A stored false (Divi's default font) is "not set": null is no change, a font is "added". */
|
||||
public function testAStoredFalseCountsAsNotSet(): void
|
||||
{
|
||||
$this->stored = ['heading_font' => false] + $this->stored;
|
||||
|
||||
self::assertSame([], $this->ability()->execute(['set' => ['heading_font' => null]])['diff']);
|
||||
$dry = self::assertToolError(
|
||||
$this->ability()->execute(['set' => ['heading_font' => 'Roboto']]),
|
||||
'confirm_required'
|
||||
);
|
||||
self::assertSame([['heading_font', 'added']], array_map(
|
||||
static fn (array $row): array => [$row['key'], $row['action']],
|
||||
$dry['diff']
|
||||
));
|
||||
}
|
||||
|
||||
public function testUnchangedValuesAreNoChange(): void
|
||||
{
|
||||
$result = $this->ability()->execute(['set' => ['body_font_size' => 16, 'gutter_width' => null]]);
|
||||
|
||||
Reference in New Issue
Block a user