Loosen-IT/WP-LIT-MCP
3
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 7 Wiki Activity

fix: trashed backup before replace, byte-exact meta copy, partial rollback

Browse Source 
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01At3V6SjwbMe6eMzVGW3Hs7
This commit is contained in:
janniclas.loosen
2026-09-25 23:34:13 +02:00
co-authored by Claude Opus 5.5
parent 4fed69cf65
commit e183874ff7
7 changed files with 490 additions and 152 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/Unit/Integrations/WordPress/Status/PostClonerTest.php
+172 -50
View File
@@ -7,13 +7,54 @@ namespace LIT\MCP\Tests\Unit\Integrations\WordPress\Status;
use Brain\Monkey\Functions;
use LIT\MCP\Abilities\WriteFailed;
use LIT\MCP\Integrations\WordPress\Status\PostCloner;
use LIT\MCP\Integrations\WordPress\Status\ReplaceFailed;
use LIT\MCP\Tests\Unit\TestCase;
use Mockery;
use RuntimeException;
use WP_Error;
use WP_Post;
final class PostClonerTest extends TestCase
{
/** @var array<int, array<string, list<string|null>>> Stored meta by post ID, as meta_value strings. */
private array $meta = [];
/** @var list<array{0: int, 1: string, 2: string|null}> Raw postmeta inserts. */
private array $inserts = [];
private bool $insertFails = false;
protected function setUp(): void
{
parent::setUp();
Functions\when('wp_cache_delete')->justReturn(true);
}
private function cloner(): PostCloner
{
$db = Mockery::mock(\wpdb::class)->makePartial();
$db->allows('get_results')->andReturnUsing(function (string $sql): array {
preg_match('/post_id = (\d+)/', $sql, $match);
$rows = [];
foreach ($this->meta[(int) $match[1]] ?? [] as $key => $values) {
foreach ($values as $value) {
$rows[] = ['meta_key' => $key, 'meta_value' => $value];
}
}
return $rows;
});
$db->allows('insert')->andReturnUsing(function (string $table, array $data, array $format) {
self::assertSame('wp_postmeta', $table);
self::assertSame(['%d', '%s', '%s'], $format);
$this->inserts[] = [$data['post_id'], $data['meta_key'], $data['meta_value']];
return $this->insertFails ? false : 1;
});
return new PostCloner($db);
}
private function original(): WP_Post
{
return new WP_Post([
@@ -41,33 +82,64 @@ final class PostClonerTest extends TestCase
public function testDuplicateCopiesContentMetaAndTermsAsDraft(): void
{
Functions\when('get_current_user_id')->justReturn(4);
Functions\when('maybe_unserialize')->returnArg();
Functions\expect('wp_insert_post')->once()->with($this->draftMatcher(), true)->andReturn(77);
Functions\when('get_post_meta')->alias(static fn (int $id) => $id === 5
? [
Functions\expect('wp_insert_post')->once()->with($this->draftMatcher('Team (Kopie)'), true)->andReturn(77);
$this->meta = [
5 => [
'_edit_lock' => ['123:1'],
'_edit_last' => ['1'],
'_wp_old_slug' => ['team-alt'],
'_lit_mcp_backup_of' => ['3'],
'_et_pb_use_builder' => ['on'],
'_et_pb_use_divi_5' => ['on'],
'_wp_page_template' => ['page-template-blank.php'],
'_thumbnail_id' => ['31'],
'role' => ['Leitung'],
]
: ['_edit_lock' => ['999:4'], '_et_pb_use_builder' => ['off']]);
// Meta a save hook put on the fresh copy is replaced by the original's.
],
// Meta a save hook put on the fresh copy is replaced by the original's.
77 => ['_edit_lock' => ['999:4'], '_et_pb_use_builder' => ['off']],
];
Functions\expect('delete_post_meta')->once()->with(77, '_et_pb_use_builder');
Functions\expect('add_post_meta')->once()->with(77, '_et_pb_use_builder', 'on');
Functions\expect('add_post_meta')->once()->with(77, '_et_pb_use_divi_5', 'on');
Functions\expect('add_post_meta')->once()->with(77, '_wp_page_template', 'page-template-blank.php');
Functions\expect('add_post_meta')->once()->with(77, '_thumbnail_id', '31');
Functions\expect('add_post_meta')->once()->with(77, 'role', 'Leitung');
Functions\when('get_object_taxonomies')->justReturn(['category']);
Functions\when('wp_get_object_terms')->justReturn([4, 9]);
Functions\expect('wp_set_object_terms')->once()->with(77, [4, 9], 'category', false);
Functions\expect('update_post_meta')->once()->with(77, '_lit_mcp_copy_of', 5);
self::assertSame(77, (new PostCloner())->duplicate($this->original()));
self::assertSame(77, $this->cloner()->duplicate($this->original()));
self::assertSame([
[77, '_et_pb_use_builder', 'on'],
[77, '_et_pb_use_divi_5', 'on'],
[77, '_wp_page_template', 'page-template-blank.php'],
[77, '_thumbnail_id', '31'],
[77, 'role', 'Leitung'],
], $this->inserts);
}
public function testMetaIsCopiedByteExact(): void
{
Functions\when('get_current_user_id')->justReturn(4);
Functions\when('wp_insert_post')->justReturn(77);
Functions\when('get_object_taxonomies')->justReturn([]);
Functions\when('update_post_meta')->justReturn(true);
$raw = [
'path' => ['a:1:{s:1:"p";s:9:"C:\\new\\x\\";}'],
'quoted' => ['Er sagte \\"hallo\\"'],
'flag' => ['b:0;'],
'object' => ['O:8:"stdClass":1:{s:1:"a";i:1;}'],
'empty' => [''],
'null' => [null],
];
$this->meta = [5 => $raw];
$this->cloner()->duplicate($this->original());
self::assertSame([
[77, 'path', 'a:1:{s:1:"p";s:9:"C:\\new\\x\\";}'],
[77, 'quoted', 'Er sagte \\"hallo\\"'],
[77, 'flag', 'b:0;'],
[77, 'object', 'O:8:"stdClass":1:{s:1:"a";i:1;}'],
[77, 'empty', ''],
[77, 'null', null],
], $this->inserts);
}
public function testDuplicateFailureThrows(): void
@@ -77,20 +149,19 @@ final class PostClonerTest extends TestCase
$this->expectException(RuntimeException::class);
(new PostCloner())->duplicate($this->original());
$this->cloner()->duplicate($this->original());
}
public function testDuplicateFailingAfterInsertDeletesTheNewDraft(): void
{
Functions\when('get_current_user_id')->justReturn(4);
Functions\when('maybe_unserialize')->returnArg();
Functions\when('wp_insert_post')->justReturn(77);
Functions\when('get_post_meta')->alias(static fn (int $id) => $id === 5 ? ['role' => ['Leitung']] : []);
Functions\when('add_post_meta')->justReturn(false);
$this->meta = [5 => ['role' => ['Leitung']]];
$this->insertFails = true;
Functions\expect('wp_delete_post')->once()->with(77, true)->andReturn(new WP_Post(['ID' => 77]));
try {
(new PostCloner())->duplicate($this->original());
$this->cloner()->duplicate($this->original());
self::fail('WriteFailed expected');
} catch (WriteFailed $e) {
self::assertTrue($e->rolledBack);
@@ -100,15 +171,13 @@ final class PostClonerTest extends TestCase
public function testDuplicateReportsALeftoverDraftWhenItCannotBeDeleted(): void
{
Functions\when('get_current_user_id')->justReturn(4);
Functions\when('maybe_unserialize')->returnArg();
Functions\when('wp_insert_post')->justReturn(77);
Functions\when('get_post_meta')->justReturn([]);
Functions\when('get_object_taxonomies')->justReturn(['category']);
Functions\when('wp_get_object_terms')->justReturn(new WP_Error('x', 'kaputt'));
Functions\when('wp_delete_post')->justReturn(false);
try {
(new PostCloner())->duplicate($this->original());
$this->cloner()->duplicate($this->original());
self::fail('WriteFailed expected');
} catch (WriteFailed $e) {
self::assertFalse($e->rolledBack);
@@ -116,100 +185,153 @@ final class PostClonerTest extends TestCase
}
}
public function testBackupIsAFullCloneInTheTrash(): void
{
Functions\when('get_current_user_id')->justReturn(4);
Functions\expect('wp_insert_post')->once()->with($this->draftMatcher('Team (Sicherung)'), true)->andReturn(88);
$this->meta = [5 => ['_et_pb_use_builder' => ['on'], '_lit_mcp_copy_of' => ['1']]];
Functions\when('get_object_taxonomies')->justReturn(['category']);
Functions\when('wp_get_object_terms')->justReturn([4]);
Functions\expect('wp_set_object_terms')->once()->with(88, [4], 'category', false);
Functions\expect('update_post_meta')->once()->with(88, '_lit_mcp_backup_of', 5)->andReturn(12);
Functions\expect('wp_trash_post')->once()->with(88)->andReturn(new WP_Post(['ID' => 88]));
Functions\when('get_post_status')->justReturn('trash');
Functions\expect('wp_delete_post')->never();
self::assertSame(88, $this->cloner()->backup($this->original()));
self::assertSame([[88, '_et_pb_use_builder', 'on']], $this->inserts);
}
public function testABackupThatCannotBeTrashedIsDeletedAgain(): void
{
Functions\when('get_current_user_id')->justReturn(4);
Functions\when('wp_insert_post')->justReturn(88);
Functions\when('get_object_taxonomies')->justReturn([]);
Functions\when('update_post_meta')->justReturn(12);
Functions\when('wp_trash_post')->justReturn(new WP_Post(['ID' => 88]));
Functions\when('get_post_status')->justReturn('draft');
Functions\expect('wp_delete_post')->once()->with(88, true)->andReturn(new WP_Post(['ID' => 88]));
try {
$this->cloner()->backup($this->original());
self::fail('WriteFailed expected');
} catch (WriteFailed $e) {
self::assertTrue($e->rolledBack);
self::assertSame('lit_write_failed', $e->toError()->get_error_code());
}
}
public function testReplaceOverwritesContentMetaAndTermsButKeepsTheOriginalsIdentity(): void
{
Functions\when('maybe_unserialize')->returnArg();
Functions\expect('wp_update_post')->once()->with([
'ID' => 5,
'post_title' => 'Team',
'post_content' => 'neu',
'post_excerpt' => 'Neu kurz',
], true)->andReturn(5);
Functions\when('get_post_meta')->alias(static fn (int $id) => $id === 5
? ['_edit_lock' => ['1'], '_wp_old_slug' => ['alt'], 'role' => ['Alt'], 'city' => ['Trier']]
: ['_lit_mcp_copy_of' => ['5'], '_edit_last' => ['4'], 'role' => ['Neu']]);
$this->meta = [
5 => ['_edit_lock' => ['1'], '_wp_old_slug' => ['alt'], 'role' => ['Alt'], 'city' => ['Trier']],
77 => ['_lit_mcp_copy_of' => ['5'], '_edit_last' => ['4'], 'role' => ['Neu']],
];
Functions\expect('delete_post_meta')->once()->with(5, 'role');
Functions\expect('delete_post_meta')->once()->with(5, 'city');
Functions\expect('add_post_meta')->once()->with(5, 'role', 'Neu');
Functions\when('get_object_taxonomies')->justReturn(['category']);
Functions\when('wp_get_object_terms')->justReturn([12]);
Functions\expect('wp_set_object_terms')->once()->with(5, [12], 'category', false);
(new PostCloner())->replace($this->original(), $this->copy());
$this->cloner()->replace($this->original(), $this->copy());
self::assertSame([[5, 'role', 'Neu']], $this->inserts);
}
public function testReplaceThrowsWhenWordPressRejectsTheUpdate(): void
public function testAReplaceRejectedByWordPressNamesOnlyThePostRow(): void
{
Functions\when('wp_update_post')->justReturn(new WP_Error('x', 'kaputt'));
Functions\expect('delete_post_meta')->never();
$this->expectException(RuntimeException::class);
(new PostCloner())->replace($this->original(), $this->copy());
try {
$this->cloner()->replace($this->original(), $this->copy());
self::fail('ReplaceFailed expected');
} catch (ReplaceFailed $e) {
self::assertSame(['post'], $e->parts);
}
}
public function testReplaceThrowsWhenTermsCannotBeSet(): void
public function testAFailingTermStepNamesAllParts(): void
{
Functions\when('wp_update_post')->justReturn(5);
Functions\when('get_post_meta')->justReturn([]);
Functions\when('get_object_taxonomies')->justReturn(['category']);
Functions\when('wp_get_object_terms')->justReturn([12]);
Functions\when('wp_set_object_terms')->justReturn(new WP_Error('x', 'kaputt'));
$this->expectException(RuntimeException::class);
(new PostCloner())->replace($this->original(), $this->copy());
try {
$this->cloner()->replace($this->original(), $this->copy());
self::fail('ReplaceFailed expected');
} catch (ReplaceFailed $e) {
self::assertSame(['post', 'meta', 'terms'], $e->parts);
}
}
public function testSnapshotAndRestoreBringBackRowMetaAndTerms(): void
{
$meta = ['_edit_lock' => ['1'], 'role' => ['Alt']];
Functions\when('get_post_meta')->alias(static function () use (&$meta): array {
return $meta;
});
$this->meta = [5 => ['_edit_lock' => ['1'], 'role' => ['b:0;']]];
Functions\when('get_object_taxonomies')->justReturn(['category']);
Functions\when('wp_get_object_terms')->justReturn([4]);
$cloner = new PostCloner();
$cloner = $this->cloner();
$snapshot = $cloner->snapshot($this->original());
self::assertSame(['post_title' => 'Team', 'post_content' => '<!-- wp:divi/section /-->', 'post_excerpt' => 'Kurz'], $snapshot['post']);
self::assertSame(['role' => ['Alt']], $snapshot['meta']);
self::assertSame(['role' => ['b:0;']], $snapshot['meta']);
self::assertSame(['category' => [4]], $snapshot['terms']);
$meta = ['_edit_lock' => ['1'], 'role' => ['Neu'], 'city' => ['Trier']];
Functions\when('maybe_unserialize')->returnArg();
$this->meta = [5 => ['_edit_lock' => ['1'], 'role' => ['Neu'], 'city' => ['Trier']]];
Functions\expect('wp_update_post')->once()
->with(array_merge(['ID' => 5], $snapshot['post']), true)->andReturn(5);
Functions\expect('delete_post_meta')->once()->with(5, 'role');
Functions\expect('delete_post_meta')->once()->with(5, 'city');
Functions\expect('add_post_meta')->once()->with(5, 'role', 'Alt');
Functions\expect('wp_set_object_terms')->once()->with(5, [4], 'category', false);
$cloner->restore($this->original(), $snapshot);
self::assertSame([[5, 'role', 'b:0;']], $this->inserts);
}
public function testRestoreWritesOnlyThePartsReached(): void
{
Functions\expect('wp_update_post')->once()->andReturn(5);
Functions\expect('delete_post_meta')->never();
Functions\expect('wp_set_object_terms')->never();
$this->cloner()->restore($this->original(), [
'post' => ['post_title' => 'Team', 'post_content' => '', 'post_excerpt' => ''],
'meta' => ['role' => ['Alt']],
'terms' => ['category' => [4]],
], ['post']);
self::assertSame([], $this->inserts);
}
public function testRestoreTriesEveryPartAndReportsFailures(): void
{
Functions\when('wp_update_post')->justReturn(new WP_Error('x', 'kaputt'));
Functions\when('get_post_meta')->justReturn([]);
Functions\expect('wp_set_object_terms')->once()->with(5, [4], 'category', false);
$this->expectException(RuntimeException::class);
$this->expectExceptionMessage('Restore incomplete');
(new PostCloner())->restore($this->original(), [
$this->cloner()->restore($this->original(), [
'post' => ['post_title' => 'Team', 'post_content' => '', 'post_excerpt' => ''],
'meta' => [],
'terms' => ['category' => [4]],
]);
}
private function draftMatcher(): \Mockery\Matcher\Closure
private function draftMatcher(string $title): \Mockery\Matcher\Closure
{
return \Mockery::on(static fn (array $data): bool => $data['post_status'] === 'draft'
return Mockery::on(static fn (array $data): bool => $data['post_status'] === 'draft'
&& $data['post_type'] === 'page'
&& $data['post_title'] === 'Team (Kopie)'
&& $data['post_title'] === $title
&& $data['post_content'] === '<!-- wp:divi/section /-->'
&& $data['post_excerpt'] === 'Kurz'
&& $data['post_parent'] === 2