refactor: PostChangeResult for the after-save block of the post tools

after_save hook, re-read, change log and ToolResult (rev, log_id, warnings)
were repeated in nine post abilities; they now share one helper. Behaviour
and warning texts are unchanged.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01At3V6SjwbMe6eMzVGW3Hs7
This commit is contained in:
2026-09-26 01:22:34 +02:00
co-authored by Claude Opus 5.5
parent d831cf59ca
commit e57b53d0e5
15 changed files with 231 additions and 191 deletions
@@ -96,7 +96,7 @@ final class ContentCreateAbilityTest extends TestCase
Actions\expectDone('lit_mcp_after_save')->once()->with(42, 'lit/content-create', $input);
$post = $this->stubResultLinks();
$log = Mockery::mock(ChangeLog::class);
$log->expects('record')->with('lit/content-create', 'lit_person', '42', 'Entwurf "Anna" angelegt')->andReturn(7);
$log->expects('record')->with('lit/content-create', 'lit_person', '42', 'Entwurf "Anna" angelegt', null)->andReturn(7);
$result = (new ContentCreateAbility($schema, $writer, $log))->execute($input);
@@ -0,0 +1,91 @@
<?php
declare(strict_types=1);
namespace LIT\MCP\Tests\Unit\Integrations\WordPress;
use Brain\Monkey\Actions;
use Brain\Monkey\Functions;
use LIT\MCP\Abilities\Rev;
use LIT\MCP\ChangeLog\ChangeLog;
use LIT\MCP\Integrations\WordPress\PostChangeResult;
use LIT\MCP\Tests\Unit\TestCase;
use Mockery;
use RuntimeException;
use WP_Post;
final class PostChangeResultTest extends TestCase
{
private string $errorLog = '';
private string|false $previousLog = false;
protected function setUp(): void
{
parent::setUp();
$this->errorLog = (string) tempnam(sys_get_temp_dir(), 'lit-mcp-log');
$this->previousLog = ini_set('error_log', $this->errorLog);
}
protected function tearDown(): void
{
ini_set('error_log', (string) $this->previousLog);
unlink($this->errorLog);
parent::tearDown();
}
public function testRunsTheHookLogsAndBuildsTheResult(): void
{
$post = new WP_Post(['ID' => 5, 'post_title' => 'Team']);
Actions\expectDone('lit_mcp_after_save')->once()->with(5, 'lit/content-update', ['post_id' => 5]);
Functions\when('get_post')->justReturn($post);
$log = Mockery::mock(ChangeLog::class);
$log->expects('record')->with('lit/content-update', 'page', '5', 'geändert', 811)->andReturn(9);
$change = new PostChangeResult('lit/content-update', $log, 5, 'die Änderung', ['vorher']);
$change->afterSave(['post_id' => 5]);
$updated = $change->reread();
$change->log('page', 'geändert', 811);
$result = $change->result('Fertig.', $updated)->toArray();
self::assertSame($post, $updated);
self::assertSame('Fertig.', $result['summary']);
self::assertSame(Rev::ofPost($post), $result['rev']);
self::assertSame(9, $result['log_id']);
self::assertSame(['vorher'], $result['warnings']);
}
public function testFailuresAfterTheWriteBecomeWarnings(): void
{
Actions\expectDone('lit_mcp_after_save')->once()->whenHappen(static function (): void {
throw new RuntimeException('listener kaputt');
});
Functions\when('get_post')->justReturn(null);
$log = Mockery::mock(ChangeLog::class);
$log->expects('record')->andThrow(new RuntimeException('log kaputt'));
$fallback = new WP_Post(['ID' => 5]);
$change = new PostChangeResult('lit/post-publish', $log, 5);
$change->afterSave([], 'Veröffentlichen');
$updated = $change->reread($fallback);
$change->log('page', 'x');
$result = $change->result('ok', $updated)->toArray();
self::assertSame($fallback, $updated);
self::assertNull($result['log_id']);
self::assertSame([
'Eine Erweiterung ist nach dem Veröffentlichen auf einen Fehler gestoßen; die Änderung ist gespeichert.',
'Änderungsprotokoll konnte nicht geschrieben werden; die Änderung ist gespeichert.',
], $result['warnings']);
self::assertStringContainsString('listener kaputt', (string) file_get_contents($this->errorLog));
}
public function testWithoutAReadablePostTheRevIsNull(): void
{
Functions\when('get_post')->justReturn(null);
$change = new PostChangeResult('lit/content-create', Mockery::mock(ChangeLog::class), 5, 'der Entwurf');
self::assertNull($change->reread());
self::assertNull($change->result('ok', null)->toArray()['rev']);
}
}
@@ -46,7 +46,7 @@ final class PostDuplicateAbilityTest extends TestCase
$cloner->expects('duplicate')->with($this->original)->andReturn(77);
Actions\expectDone('lit_mcp_after_save')->once()->with(77, 'lit/post-duplicate', ['post_id' => 5]);
$log = Mockery::mock(ChangeLog::class);
$log->expects('record')->with('lit/post-duplicate', 'page', '77', 'Kopie von "Team" (ID 5) angelegt')->andReturn(8);
$log->expects('record')->with('lit/post-duplicate', 'page', '77', 'Kopie von "Team" (ID 5) angelegt', null)->andReturn(8);
$result = $this->ability($cloner, $log)->execute(['post_id' => 5]);
@@ -36,7 +36,7 @@ final class PostPublishAbilityTest extends TestCase
Functions\expect('wp_update_post')->once()->with(['ID' => 5, 'post_status' => 'publish'], true)->andReturn(5);
Functions\when('get_post_status')->justReturn('publish');
$log = Mockery::mock(ChangeLog::class);
$log->expects('record')->with('lit/post-publish', 'page', '5', '"Team" veröffentlicht')->andReturn(9);
$log->expects('record')->with('lit/post-publish', 'page', '5', '"Team" veröffentlicht', null)->andReturn(9);
$result = $this->ability($log)->execute(['post_id' => 5]);
@@ -38,7 +38,7 @@ final class PostTrashAbilityTest extends TestCase
Functions\expect('wp_trash_post')->once()->with(5)->andReturn(new WP_Post(['ID' => 5]));
Functions\expect('wp_delete_post')->never();
$log = Mockery::mock(ChangeLog::class);
$log->expects('record')->with('lit/post-trash', 'page', '5', '"Alt" in den Papierkorb gelegt')->andReturn(2);
$log->expects('record')->with('lit/post-trash', 'page', '5', '"Alt" in den Papierkorb gelegt', null)->andReturn(2);
$result = $this->ability($log)->execute(['post_id' => 5, 'confirm' => true]);