feat: access tab with allowed roles and connection revocation
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01At3V6SjwbMe6eMzVGW3Hs7
This commit is contained in:
Claude Opus 5.5
@@ -0,0 +1,211 @@
|
||||
<?php
|
||||
|
||||
declare(strict_types=1);
|
||||
|
||||
namespace LIT\MCP\Admin;
|
||||
|
||||
use LIT\MCP\Access;
|
||||
|
||||
/**
|
||||
* Tab "Zugriff": roles allowed to use LIT MCP and the active OAuth connections
|
||||
* with revocation (spec §8.4).
|
||||
*/
|
||||
final class AccessTab implements AdminTab
|
||||
{
|
||||
public const GROUP = 'lit_mcp_access';
|
||||
public const REVOKE_ACTION = 'lit_mcp_revoke';
|
||||
|
||||
/** @var callable(): void */
|
||||
private $terminate;
|
||||
|
||||
public function __construct(
|
||||
private Access $access,
|
||||
private ConnectionRepository $connections,
|
||||
?callable $terminate = null
|
||||
) {
|
||||
$this->terminate = $terminate ?? static function (): void {
|
||||
exit;
|
||||
};
|
||||
}
|
||||
|
||||
public function slug(): string
|
||||
{
|
||||
return 'zugriff';
|
||||
}
|
||||
|
||||
public function label(): string
|
||||
{
|
||||
return __('Zugriff', 'wp-lit-mcp');
|
||||
}
|
||||
|
||||
public function registerSettings(): void
|
||||
{
|
||||
register_setting(self::GROUP, Access::OPTION, [
|
||||
'type' => 'array',
|
||||
'sanitize_callback' => [self::class, 'sanitizeRoles'],
|
||||
'default' => ['administrator'],
|
||||
]);
|
||||
}
|
||||
|
||||
public function registerActions(): void
|
||||
{
|
||||
add_action('admin_post_' . self::REVOKE_ACTION, [$this, 'handleRevoke']);
|
||||
}
|
||||
|
||||
/**
|
||||
* Keeps only existing role slugs. Runs twice on the very first save (update_option
|
||||
* falls through to add_option, which sanitizes again), so each warning is added
|
||||
* only once. The settings page itself needs manage_options, not lit_mcp_use, so
|
||||
* removing the current user's own role is allowed – but warned about.
|
||||
*
|
||||
* @return list<string>
|
||||
*/
|
||||
public static function sanitizeRoles(mixed $input): array
|
||||
{
|
||||
$existing = array_keys((array) wp_roles()->roles);
|
||||
$roles = array_values(array_unique(array_intersect(
|
||||
array_filter(is_array($input) ? $input : [], 'is_string'),
|
||||
$existing
|
||||
)));
|
||||
|
||||
if ($roles === []) {
|
||||
self::warnOnce(
|
||||
'lit_mcp_no_roles',
|
||||
__('Keine Rolle freigegeben – niemand kann LIT MCP nutzen.', 'wp-lit-mcp')
|
||||
);
|
||||
} elseif (self::currentUserLosesAccess($roles)) {
|
||||
self::warnOnce(
|
||||
'lit_mcp_own_role',
|
||||
__(
|
||||
'Keine Ihrer Rollen ist mehr freigegeben – Sie selbst können LIT MCP nicht mehr nutzen.',
|
||||
'wp-lit-mcp'
|
||||
)
|
||||
);
|
||||
}
|
||||
|
||||
return $roles;
|
||||
}
|
||||
|
||||
public function render(): void
|
||||
{
|
||||
$allowed = $this->access->allowedRoles();
|
||||
|
||||
echo '<h2>' . esc_html__('Freigegebene Rollen', 'wp-lit-mcp') . '</h2>';
|
||||
echo '<p>' . esc_html__(
|
||||
'Nur Benutzer dieser Rollen können Tools nutzen; zusätzlich gelten ihre normalen WordPress-Rechte.',
|
||||
'wp-lit-mcp'
|
||||
) . '</p>';
|
||||
echo '<form method="post" action="options.php">';
|
||||
settings_fields(self::GROUP);
|
||||
// Makes an all-unchecked submission arrive as [''] instead of dropping the field.
|
||||
printf('<input type="hidden" name="%s[]" value="">', esc_attr(Access::OPTION));
|
||||
foreach (wp_roles()->get_names() as $role => $name) {
|
||||
printf(
|
||||
'<label><input type="checkbox" name="%s[]" value="%s"%s> %s</label><br>',
|
||||
esc_attr(Access::OPTION),
|
||||
esc_attr((string) $role),
|
||||
checked(in_array($role, $allowed, true), true, false),
|
||||
esc_html(translate_user_role((string) $name))
|
||||
);
|
||||
}
|
||||
submit_button();
|
||||
echo '</form>';
|
||||
|
||||
$this->renderConnections();
|
||||
}
|
||||
|
||||
public function handleRevoke(): void
|
||||
{
|
||||
if (! current_user_can('manage_options')) {
|
||||
wp_die(esc_html__('Keine Berechtigung.', 'wp-lit-mcp'), '', ['response' => 403]);
|
||||
}
|
||||
|
||||
// phpcs:disable WordPress.Security.NonceVerification.Missing -- verified right below.
|
||||
$uuid = isset($_POST['uuid']) ? sanitize_text_field(wp_unslash((string) $_POST['uuid'])) : '';
|
||||
$userId = isset($_POST['user_id']) ? absint($_POST['user_id']) : 0;
|
||||
// phpcs:enable WordPress.Security.NonceVerification.Missing
|
||||
check_admin_referer(self::REVOKE_ACTION . '_' . $uuid);
|
||||
|
||||
$revoked = $this->connections->revoke($userId, $uuid);
|
||||
$notice = $revoked ? 'revoked' : 'revoke_failed';
|
||||
wp_safe_redirect(SettingsPage::url($this->slug(), ['lit_mcp_notice' => $notice]));
|
||||
($this->terminate)();
|
||||
}
|
||||
|
||||
private static function warnOnce(string $code, string $message): void
|
||||
{
|
||||
foreach ((array) get_settings_errors(Access::OPTION) as $error) {
|
||||
if (is_array($error) && ($error['code'] ?? '') === $code) {
|
||||
return;
|
||||
}
|
||||
}
|
||||
|
||||
add_settings_error(Access::OPTION, $code, $message, 'warning');
|
||||
}
|
||||
|
||||
/** @param list<string> $roles */
|
||||
private static function currentUserLosesAccess(array $roles): bool
|
||||
{
|
||||
// Multisite super admins pass every capability check regardless of role.
|
||||
if (is_multisite() && is_super_admin()) {
|
||||
return false;
|
||||
}
|
||||
|
||||
$user = wp_get_current_user();
|
||||
|
||||
return array_intersect((array) $user->roles, $roles) === [];
|
||||
}
|
||||
|
||||
private function renderConnections(): void
|
||||
{
|
||||
echo '<h2>' . esc_html__('Aktive Verbindungen', 'wp-lit-mcp') . '</h2>';
|
||||
$connections = $this->connections->all();
|
||||
if ($connections === []) {
|
||||
echo '<p>' . esc_html__('Keine aktiven Verbindungen.', 'wp-lit-mcp') . '</p>';
|
||||
return;
|
||||
}
|
||||
|
||||
echo '<table class="widefat striped"><thead><tr>';
|
||||
$headings = [
|
||||
__('Benutzer', 'wp-lit-mcp'),
|
||||
__('Client', 'wp-lit-mcp'),
|
||||
__('Erstellt', 'wp-lit-mcp'),
|
||||
__('Zuletzt genutzt', 'wp-lit-mcp'),
|
||||
'',
|
||||
];
|
||||
foreach ($headings as $heading) {
|
||||
echo '<th>' . esc_html($heading) . '</th>';
|
||||
}
|
||||
echo '</tr></thead><tbody>';
|
||||
|
||||
foreach ($connections as $connection) {
|
||||
$this->renderConnectionRow($connection);
|
||||
}
|
||||
|
||||
echo '</tbody></table>';
|
||||
}
|
||||
|
||||
/**
|
||||
* @param array{user_id: int, user_login: string, uuid: string, name: string,
|
||||
* app_id: string, created: int, last_used: ?int} $connection
|
||||
*/
|
||||
private function renderConnectionRow(array $connection): void
|
||||
{
|
||||
echo '<tr>';
|
||||
echo '<td>' . esc_html($connection['user_login']) . '</td>';
|
||||
printf('<td>%s<br><code>%s</code></td>', esc_html($connection['name']), esc_html($connection['app_id']));
|
||||
echo '<td>' . esc_html((string) wp_date('Y-m-d H:i', $connection['created'])) . '</td>';
|
||||
$lastUsed = $connection['last_used'] === null
|
||||
? '–'
|
||||
: (string) wp_date('Y-m-d H:i', $connection['last_used']);
|
||||
echo '<td>' . esc_html($lastUsed) . '</td>';
|
||||
echo '<td>';
|
||||
printf('<form method="post" action="%s">', esc_url(admin_url('admin-post.php')));
|
||||
printf('<input type="hidden" name="action" value="%s">', esc_attr(self::REVOKE_ACTION));
|
||||
printf('<input type="hidden" name="user_id" value="%s">', esc_attr((string) $connection['user_id']));
|
||||
printf('<input type="hidden" name="uuid" value="%s">', esc_attr($connection['uuid']));
|
||||
wp_nonce_field(self::REVOKE_ACTION . '_' . $connection['uuid']);
|
||||
submit_button(__('Widerrufen', 'wp-lit-mcp'), 'delete small', 'submit', false);
|
||||
echo '</form></td></tr>';
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,110 @@
|
||||
<?php
|
||||
|
||||
declare(strict_types=1);
|
||||
|
||||
namespace LIT\MCP\Admin;
|
||||
|
||||
use WPMedia\MCP\OAuth\Auth\TokenEndpoint;
|
||||
|
||||
/**
|
||||
* OAuth connections created by mcp-oauth (v1.1.2, TokenEndpoint): for every grant it
|
||||
* creates one application password (name = client name, app_id = the CIMD client_id,
|
||||
* always an https URL) and stores the refresh-token marker user meta
|
||||
* `mcp_refresh_jti_<uuid>`. An application password counts as an LIT MCP connection
|
||||
* only if BOTH hold: the marker meta exists and its app_id is an https URL. Any other
|
||||
* application password of the user (other tools, manual ones) is neither listed nor
|
||||
* revoked.
|
||||
*
|
||||
* Multisite: only users who are members of the current site are managed, and a
|
||||
* non-super-admin never sees or revokes a super admin's connections.
|
||||
*
|
||||
* Not final so the access tab can be tested with a mock.
|
||||
*/
|
||||
class ConnectionRepository
|
||||
{
|
||||
public function __construct(private ?\wpdb $db = null)
|
||||
{
|
||||
}
|
||||
|
||||
/**
|
||||
* @return list<array{user_id: int, user_login: string, uuid: string, name: string,
|
||||
* app_id: string, created: int, last_used: ?int}>
|
||||
*/
|
||||
public function all(): array
|
||||
{
|
||||
$wpdb = $this->db ?? $GLOBALS['wpdb'];
|
||||
$prefix = TokenEndpoint::REFRESH_JTI_META_PREFIX;
|
||||
$rows = $wpdb->get_results($wpdb->prepare(
|
||||
"SELECT user_id, meta_key FROM {$wpdb->usermeta} WHERE meta_key LIKE %s ORDER BY user_id, umeta_id",
|
||||
$wpdb->esc_like($prefix) . '%'
|
||||
));
|
||||
|
||||
$connections = [];
|
||||
foreach ((array) $rows as $row) {
|
||||
$userId = (int) $row->user_id;
|
||||
$uuid = substr((string) $row->meta_key, strlen($prefix));
|
||||
if ($uuid === '' || ! $this->manageable($userId)) {
|
||||
continue;
|
||||
}
|
||||
|
||||
$item = \WP_Application_Passwords::get_user_application_password($userId, $uuid);
|
||||
if (! self::isMcpOauthPassword($item)) {
|
||||
continue;
|
||||
}
|
||||
|
||||
$user = get_userdata($userId);
|
||||
$connections[] = [
|
||||
'user_id' => $userId,
|
||||
'user_login' => is_object($user) ? (string) $user->user_login : '#' . $userId,
|
||||
'uuid' => $uuid,
|
||||
'name' => (string) ($item['name'] ?? ''),
|
||||
'app_id' => (string) $item['app_id'],
|
||||
'created' => (int) ($item['created'] ?? 0),
|
||||
'last_used' => isset($item['last_used']) ? (int) $item['last_used'] : null,
|
||||
];
|
||||
}
|
||||
|
||||
return $connections;
|
||||
}
|
||||
|
||||
public function revoke(int $userId, string $uuid): bool
|
||||
{
|
||||
if ($userId <= 0 || $uuid === '' || ! $this->manageable($userId)) {
|
||||
return false;
|
||||
}
|
||||
|
||||
$marker = (string) get_user_meta($userId, TokenEndpoint::REFRESH_JTI_META_PREFIX . $uuid, true);
|
||||
if ($marker === '') {
|
||||
return false;
|
||||
}
|
||||
|
||||
$item = \WP_Application_Passwords::get_user_application_password($userId, $uuid);
|
||||
if (! self::isMcpOauthPassword($item)) {
|
||||
return false;
|
||||
}
|
||||
|
||||
// Fires wp_delete_application_password, on which mcp-oauth purges its marker meta.
|
||||
return \WP_Application_Passwords::delete_application_password($userId, $uuid) === true;
|
||||
}
|
||||
|
||||
/** Whether the current administrator may see and revoke this user's connections. */
|
||||
private function manageable(int $userId): bool
|
||||
{
|
||||
if (! is_multisite()) {
|
||||
return true;
|
||||
}
|
||||
|
||||
if (is_super_admin($userId) && ! is_super_admin()) {
|
||||
return false;
|
||||
}
|
||||
|
||||
return is_user_member_of_blog($userId, get_current_blog_id());
|
||||
}
|
||||
|
||||
private static function isMcpOauthPassword(mixed $item): bool
|
||||
{
|
||||
return is_array($item)
|
||||
&& is_string($item['app_id'] ?? null)
|
||||
&& str_starts_with($item['app_id'], 'https://');
|
||||
}
|
||||
}
|
||||
+5
-1
@@ -6,7 +6,9 @@ namespace LIT\MCP;
|
||||
|
||||
use LIT\MCP\Abilities\AbilityRegistrar;
|
||||
use LIT\MCP\Abilities\ExposurePolicy;
|
||||
use LIT\MCP\Admin\AccessTab;
|
||||
use LIT\MCP\Admin\AdminNotices;
|
||||
use LIT\MCP\Admin\ConnectionRepository;
|
||||
use LIT\MCP\Admin\ConnectionStatus;
|
||||
use LIT\MCP\Admin\ConnectionTab;
|
||||
use LIT\MCP\Admin\SettingsPage;
|
||||
@@ -47,7 +49,8 @@ final class Plugin
|
||||
return;
|
||||
}
|
||||
|
||||
(new Access())->register();
|
||||
$access = new Access();
|
||||
$access->register();
|
||||
(new RequestContext())->register();
|
||||
(new VisibilityFilter())->register();
|
||||
|
||||
@@ -78,6 +81,7 @@ final class Plugin
|
||||
(new SiteHealth($status))->register();
|
||||
self::$settingsPage = new SettingsPage([
|
||||
new ConnectionTab($status),
|
||||
new AccessTab($access, new ConnectionRepository()),
|
||||
]);
|
||||
if (is_admin()) {
|
||||
self::$settingsPage->register();
|
||||
|
||||
Reference in New Issue
Block a user