I1: query the attachments themselves author-restricted when the user lacks edit_others_posts (PostGuard::ownPostsOnly, extracted from ContentQueryAbility so content-query reuses the exact same rule) instead of relying solely on a post-query editable() filter, which could leak the existence of other users' attachments via an empty page plus next_cursor. editable() stays as a backstop. Also: M1 document that only status=inherit attachments are listed; M2 tie-break ordering by ID (content-query and media-search) for stable pagination; M3 no next_cursor once the last candidate was examined; M4 reject an explicit non-image mime with missing_alt; M5 additional coverage (posts_per_page, cursor offset pass-through, invalid cursor, post_status/date/mime args); mime maxLength 100. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01At3V6SjwbMe6eMzVGW3Hs7
123 lines
5.5 KiB
PHP
123 lines
5.5 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
namespace LIT\MCP\Tests\Unit\Integrations\WordPress;
|
|
|
|
use Brain\Monkey\Functions;
|
|
use LIT\MCP\Integrations\WordPress\PostGuard;
|
|
use LIT\MCP\Integrations\WordPress\Schema\ContentSchema;
|
|
use LIT\MCP\Tests\Unit\TestCase;
|
|
use Mockery;
|
|
use WP_Post;
|
|
|
|
final class PostGuardTest extends TestCase
|
|
{
|
|
private function schema(): ContentSchema
|
|
{
|
|
$schema = Mockery::mock(ContentSchema::class);
|
|
$schema->allows('isManaged')->andReturnUsing(static fn (string $type): bool => in_array($type, ['page', 'post'], true));
|
|
|
|
return $schema;
|
|
}
|
|
|
|
public function testRejectsInvalidIds(): void
|
|
{
|
|
self::assertSame('lit_validation_failed', PostGuard::editable('abc', $this->schema())->get_error_code());
|
|
self::assertSame('lit_validation_failed', PostGuard::editable(-3, $this->schema())->get_error_code());
|
|
}
|
|
|
|
public function testMissingOrUnmanagedPostsAreNotFound(): void
|
|
{
|
|
Functions\when('get_post')->alias(static fn (int $id) => $id === 8 ? new WP_Post(['ID' => 8, 'post_type' => 'et_pb_layout']) : null);
|
|
|
|
self::assertSame('lit_not_found', PostGuard::editable(5, $this->schema())->get_error_code());
|
|
self::assertSame('lit_not_found', PostGuard::editable(8, $this->schema())->get_error_code());
|
|
}
|
|
|
|
public function testRequiresEditRightsAndReturnsThePost(): void
|
|
{
|
|
$post = new WP_Post(['ID' => 5, 'post_type' => 'page']);
|
|
Functions\when('get_post')->justReturn($post);
|
|
Functions\when('current_user_can')->alias(static fn (string $cap, int $id = 0): bool => $id === 5);
|
|
|
|
self::assertSame($post, PostGuard::editable('5', $this->schema()));
|
|
|
|
Functions\when('current_user_can')->justReturn(false);
|
|
self::assertSame('lit_forbidden', PostGuard::editable(5, $this->schema())->get_error_code());
|
|
}
|
|
|
|
public function testTrashedPostsAreRefusedUnlessAllowed(): void
|
|
{
|
|
$post = new WP_Post(['ID' => 5, 'post_type' => 'page', 'post_status' => 'trash']);
|
|
Functions\when('get_post')->justReturn($post);
|
|
Functions\when('current_user_can')->justReturn(true);
|
|
|
|
$error = PostGuard::editable(5, $this->schema(), 'copy_id');
|
|
self::assertSame('lit_validation_failed', $error->get_error_code());
|
|
self::assertArrayHasKey('copy_id', $error->get_error_data()['fields']);
|
|
self::assertSame($post, PostGuard::editable(5, $this->schema(), 'post_id', true));
|
|
}
|
|
|
|
public function testMissedScheduleIsAFuturePostWhoseDateHasPassed(): void
|
|
{
|
|
$past = gmdate('Y-m-d H:i:s', time() - 3600);
|
|
$future = gmdate('Y-m-d H:i:s', time() + 3600);
|
|
|
|
self::assertTrue(PostGuard::missedSchedule(new WP_Post(['post_status' => 'future', 'post_date_gmt' => $past])));
|
|
self::assertFalse(PostGuard::missedSchedule(new WP_Post(['post_status' => 'future', 'post_date_gmt' => $future])));
|
|
self::assertFalse(PostGuard::missedSchedule(new WP_Post(['post_status' => 'draft', 'post_date_gmt' => $past])));
|
|
self::assertFalse(PostGuard::missedSchedule(
|
|
new WP_Post(['post_status' => 'future', 'post_date_gmt' => '0000-00-00 00:00:00'])
|
|
));
|
|
}
|
|
|
|
public function testStatusStableRefusesAMissedScheduleWithAHint(): void
|
|
{
|
|
$post = new WP_Post(['ID' => 5, 'post_status' => 'future', 'post_date_gmt' => gmdate('Y-m-d H:i:s', time() - 60)]);
|
|
|
|
$error = PostGuard::statusStable($post, 'original_id');
|
|
|
|
self::assertSame('lit_validation_failed', $error->get_error_code());
|
|
self::assertArrayHasKey('original_id', $error->get_error_data()['fields']);
|
|
self::assertStringContainsString('lit-post-publish', $error->get_error_data()['hint']);
|
|
self::assertStringContainsString('lit/post-schedule', $error->get_error_data()['hint']);
|
|
self::assertNull(PostGuard::statusStable(new WP_Post(['post_status' => 'publish'])));
|
|
}
|
|
|
|
public function testOwnPostsOnlyReturnsTheCurrentUserWithoutEditOthersPosts(): void
|
|
{
|
|
Functions\when('get_post_type_object')->justReturn(
|
|
(object) ['cap' => (object) ['edit_others_posts' => 'edit_others_posts']]
|
|
);
|
|
Functions\when('current_user_can')->alias(static fn (string $cap): bool => $cap !== 'edit_others_posts');
|
|
Functions\when('get_current_user_id')->justReturn(7);
|
|
|
|
self::assertSame(7, PostGuard::ownPostsOnly('page'));
|
|
}
|
|
|
|
public function testOwnPostsOnlyReturnsNullWithEditOthersPosts(): void
|
|
{
|
|
Functions\when('get_post_type_object')->justReturn(
|
|
(object) ['cap' => (object) ['edit_others_posts' => 'edit_others_posts']]
|
|
);
|
|
Functions\when('current_user_can')->justReturn(true);
|
|
|
|
self::assertNull(PostGuard::ownPostsOnly('page'));
|
|
}
|
|
|
|
public function testPostTypeChecksAvailabilityAndCapability(): void
|
|
{
|
|
$object = (object) ['cap' => (object) ['create_posts' => 'edit_pages']];
|
|
Functions\when('get_post_type_object')->justReturn($object);
|
|
Functions\when('current_user_can')->alias(static fn (string $cap): bool => $cap === 'edit_pages');
|
|
|
|
self::assertSame('lit_not_found', PostGuard::postType('et_pb_layout', $this->schema(), 'create_posts')->get_error_code());
|
|
self::assertSame('lit_not_found', PostGuard::postType(null, $this->schema(), 'create_posts')->get_error_code());
|
|
self::assertSame($object, PostGuard::postType('page', $this->schema(), 'create_posts'));
|
|
|
|
Functions\when('current_user_can')->justReturn(false);
|
|
self::assertSame('lit_forbidden', PostGuard::postType('page', $this->schema(), 'create_posts')->get_error_code());
|
|
}
|
|
}
|