janniclas.loosenandClaude Opus 5.5
02ae76d4f3
Review fix round 1 on the lit/divi-catalog task:
- AttrPathIndex::collectKinds() no longer records a kind from a
component.type === "group" node (a composite of several sub-kinds,
e.g. button.innerContent = text + link + target), and kinds() now
drops any attrName with more than one distinct candidate kind
instead of last-write-wins (e.g. imageIcon.innerContent had onoff +
icon + image sub-fields sharing one attrName). Both previously
produced a wrong-but-present kind, which is more dangerous for 2b's
sanitization routing than "unknown". Verified against the committed
blurb/button/fullwidth-header fixture entries and live against the
full 100-module catalog.
- AttrPathIndex::fromDefaults() now builds on AttrMap::flatten()
instead of a parallel walker.
- ModuleCatalog::shortName() replaces the duplicated
substr($name, strlen('divi/')) in DiviCatalogAbility.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01At3V6SjwbMe6eMzVGW3Hs7
73 lines
2.8 KiB
PHP
73 lines
2.8 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
namespace LIT\MCP\Tests\Unit\Integrations\Divi\Schema;
|
|
|
|
use Brain\Monkey\Functions;
|
|
use LIT\MCP\Integrations\Divi\Schema\DiviCatalogAbility;
|
|
use LIT\MCP\Integrations\Divi\Schema\DiviModules;
|
|
use LIT\MCP\Tests\Unit\TestCase;
|
|
use Mockery;
|
|
|
|
final class DiviCatalogAbilityTest extends TestCase
|
|
{
|
|
private function ability(): DiviCatalogAbility
|
|
{
|
|
$modules = Mockery::mock(DiviModules::class);
|
|
$modules->allows('catalog')->andReturn(ModuleCatalogTest::sampleCatalog());
|
|
|
|
return new DiviCatalogAbility($modules);
|
|
}
|
|
|
|
public function testListsModulesWithShortformFlag(): void
|
|
{
|
|
$result = $this->ability()->execute([]);
|
|
|
|
$button = array_values(array_filter($result['modules'], static fn (array $m): bool => $m['name'] === 'divi/button'));
|
|
self::assertSame(
|
|
[['name' => 'divi/button', 'title' => 'Button', 'category' => 'module', 'children' => [], 'shortform' => true]],
|
|
$button
|
|
);
|
|
$header = array_values(array_filter(
|
|
$result['modules'],
|
|
static fn (array $m): bool => $m['name'] === 'divi/fullwidth-header'
|
|
));
|
|
self::assertFalse($header[0]['shortform']);
|
|
self::assertSame(DiviCatalogAbility::CODE_NOTE, $result['notes'][0]);
|
|
}
|
|
|
|
public function testDetailOfOneModule(): void
|
|
{
|
|
$result = $this->ability()->execute(['module' => 'Accordion']);
|
|
|
|
self::assertSame('divi/accordion', $result['module']['name']);
|
|
self::assertSame(['divi/accordion-item'], $result['module']['children']);
|
|
self::assertSame('accordion-item', $result['module']['item_type']);
|
|
self::assertContains('title.decoration.font.font', $result['module']['paths']);
|
|
|
|
$button = $this->ability()->execute(['module' => 'divi/button'])['module'];
|
|
self::assertSame('linkUrl', $button['shortform']['url']['sub']);
|
|
}
|
|
|
|
public function testDetailExposesTheAttributePathKindsForSanitizationRouting(): void
|
|
{
|
|
$button = $this->ability()->execute(['module' => 'divi/button'])['module'];
|
|
|
|
self::assertSame('text', $button['path_kinds']['module.meta.adminLabel']);
|
|
self::assertArrayNotHasKey('no.such.path', $button['path_kinds']);
|
|
// Composite ("group") paths are left out rather than guessing a single kind.
|
|
self::assertArrayNotHasKey('button.innerContent', $button['path_kinds']);
|
|
}
|
|
|
|
public function testUnknownModuleAndPermission(): void
|
|
{
|
|
self::assertSame('lit_not_found', $this->ability()->execute(['module' => 'slider-pro'])->get_error_code());
|
|
|
|
Functions\when('current_user_can')->justReturn(false);
|
|
self::assertSame('lit_forbidden', $this->ability()->permission([])->get_error_code());
|
|
self::assertTrue($this->ability()->annotations()['readonly']);
|
|
self::assertTrue($this->ability()->isDirect());
|
|
}
|
|
}
|