Task 14 (rulings P17/P18, Q10): - lit/menu-get returns menu_rev (Rev::ofMenu over id, parent, position, title, url, object, object_id); lit/menu-set-items requires it, refuses a stale one with rev_mismatch (hint: lit/menu-get) and returns the new menu_rev. Errors::revMismatch takes an optional message/hint. - GuideRepository: filter lit_mcp_guides adds/overrides topics; invalid topic names and non-string content are ignored, files stay the default. - lit/post-trash names front page, posts page and linking menus in the confirmation and as warnings; lit/menu-assign-location needs confirm to remove an assigned menu and names it; lit/post-schedule warns that a private entry becomes public; Divi hints no longer point to non-existing lit-divi-* tools. - PostGuard::missedSchedule: 60 s publish window, zero GMT date falls back to get_gmt_from_date(post_date); post-schedule refuses dates within that window. - write_failed after a clean rollback that keeps a revision/backup says "Die Aenderung wurde nicht gespeichert (... bleibt erhalten)" via the new state parameter (Errors::writeFailed / WriteFailed rolledBackState). - wp-basis-smoke: menu_rev flow, unassign confirm, trash/menu and private-schedule warnings. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01At3V6SjwbMe6eMzVGW3Hs7
118 lines
5.0 KiB
PHP
118 lines
5.0 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
namespace LIT\MCP\Tests\Unit\Abilities;
|
|
|
|
use LIT\MCP\Abilities\Errors;
|
|
use LIT\MCP\Tests\Unit\TestCase;
|
|
|
|
final class ErrorsTest extends TestCase
|
|
{
|
|
public function testMessageCarriesCodeMessageHintAndFieldsAsJson(): void
|
|
{
|
|
$error = Errors::invalidInput('Titel fehlt.', ['title' => 'Pflichtfeld']);
|
|
|
|
self::assertSame('lit_validation_failed', $error->get_error_code());
|
|
$payload = json_decode($error->get_error_message(), true);
|
|
self::assertSame('validation_failed', $payload['code']);
|
|
self::assertSame('Titel fehlt.', $payload['message']);
|
|
self::assertNotSame('', $payload['hint']);
|
|
self::assertSame(['title' => 'Pflichtfeld'], $payload['fields']);
|
|
self::assertSame(400, $error->get_error_data()['status']);
|
|
self::assertSame($payload['hint'], $error->get_error_data()['hint']);
|
|
}
|
|
|
|
public function testUmlautsStayReadableInTheMessage(): void
|
|
{
|
|
$error = Errors::forbidden('Dein Benutzerkonto ist für LIT MCP nicht freigegeben.');
|
|
|
|
self::assertStringContainsString('für LIT MCP nicht freigegeben', $error->get_error_message());
|
|
}
|
|
|
|
public function testInUseCarriesTheUsages(): void
|
|
{
|
|
$error = Errors::inUse('Bild wird verwendet.', [['post_id' => 7, 'where' => 'featured']]);
|
|
|
|
$payload = json_decode($error->get_error_message(), true);
|
|
self::assertSame('lit_in_use', $error->get_error_code());
|
|
self::assertSame(7, $payload['usages'][0]['post_id']);
|
|
}
|
|
|
|
public function testEveryFactoryUsesLitPrefixAndANonEmptyHint(): void
|
|
{
|
|
$errors = [
|
|
Errors::forbidden('x'),
|
|
Errors::notFound('x'),
|
|
Errors::revMismatch(),
|
|
Errors::confirmRequired('x'),
|
|
Errors::unsupported('x', 'y'),
|
|
Errors::internal(),
|
|
];
|
|
|
|
foreach ($errors as $error) {
|
|
self::assertStringStartsWith('lit_', $error->get_error_code());
|
|
self::assertNotSame('', json_decode($error->get_error_message(), true)['hint']);
|
|
}
|
|
}
|
|
|
|
public function testWriteFailedSaysNothingWasSaved(): void
|
|
{
|
|
$error = Errors::writeFailed('Felder konnten nicht gespeichert werden.');
|
|
|
|
$payload = json_decode($error->get_error_message(), true);
|
|
self::assertSame('lit_write_failed', $error->get_error_code());
|
|
self::assertStringContainsString('Nichts wurde gespeichert.', $payload['message']);
|
|
self::assertStringContainsString('Felder konnten nicht gespeichert werden.', $payload['message']);
|
|
self::assertStringContainsString('erneut', $payload['hint']);
|
|
}
|
|
|
|
public function testWriteFailedCanDescribeWhatWasKept(): void
|
|
{
|
|
$error = Errors::writeFailed(
|
|
'Felder konnten nicht gespeichert werden.',
|
|
[],
|
|
null,
|
|
'Die Änderung wurde nicht gespeichert (Revision 811 bleibt erhalten).'
|
|
);
|
|
|
|
$message = json_decode($error->get_error_message(), true)['message'];
|
|
self::assertStringNotContainsString('Nichts wurde gespeichert', $message);
|
|
self::assertStringEndsWith('Die Änderung wurde nicht gespeichert (Revision 811 bleibt erhalten).', $message);
|
|
}
|
|
|
|
public function testRevMismatchCanNameItsOwnObjectAndReadTool(): void
|
|
{
|
|
$error = Errors::revMismatch('Das Menü wurde geändert.', 'Mit lit/menu-get neu lesen.');
|
|
|
|
self::assertSame('lit_rev_mismatch', $error->get_error_code());
|
|
self::assertSame('Das Menü wurde geändert.', json_decode($error->get_error_message(), true)['message']);
|
|
self::assertSame('Mit lit/menu-get neu lesen.', $error->get_error_data()['hint']);
|
|
self::assertStringContainsString('lit/content-get', Errors::revMismatch()->get_error_data()['hint']);
|
|
}
|
|
|
|
public function testPartialWriteNamesWhatMayHaveBeenSavedAndWarnsAgainstRetrying(): void
|
|
{
|
|
$error = Errors::partialWrite('Felder konnten nicht gespeichert werden.', 5, 811);
|
|
|
|
$payload = json_decode($error->get_error_message(), true);
|
|
self::assertSame('lit_partial_write', $error->get_error_code());
|
|
self::assertStringContainsString('Eintrag 5', $payload['message']);
|
|
self::assertStringContainsString('Revision 811', $payload['message']);
|
|
self::assertStringContainsString('lit-content-get', $payload['hint']);
|
|
self::assertStringContainsString('lit/revisions-list', $payload['hint']);
|
|
self::assertStringContainsString('mcp-adapter-execute-ability', $payload['hint']);
|
|
self::assertStringContainsString('nicht einfach wiederholen', $payload['hint']);
|
|
self::assertSame(5, $payload['post_id']);
|
|
self::assertSame(811, $payload['revision_id']);
|
|
}
|
|
|
|
public function testPartialWriteWithoutIdSaysADraftMayExist(): void
|
|
{
|
|
$payload = json_decode(Errors::partialWrite('Anlegen fehlgeschlagen.')->get_error_message(), true);
|
|
|
|
self::assertStringContainsString('Entwurf', $payload['message']);
|
|
self::assertArrayNotHasKey('post_id', $payload);
|
|
}
|
|
}
|