janniclas.loosenandClaude Opus 5.5
4137882008
Final fix wave for stage 2a, load-bearing for 2b's writers:
- Block::setAttrs()/Container::insertChild()/removeChild() refuse on an opaque
block (undecodable attrs or a global module) instead of silently corrupting it.
- Container::append() is now @internal (Parser only) and refuses on a void
block, so a child can no longer be silently dropped from the serialized output.
- Block::create() validates the block name against namespace/block-name.
- Json::decodeObject() returns null (-> opaque) for a top-level object whose
keys are a plain list ("0","1",...) rather than returning [] and letting the
Serializer re-encode it as a corrupting JSON array.
- AttrMap::set() rejects empty path segments and keeps an existing stdClass
value an object when rewrapping it (no silent object->list flip); AttrMap::get()
is updated in step so it can still read back through such an object.
- Block::copy() deep-clones stdClass attribute values instead of sharing them.
- Json::encode()'s existing JsonException-on-invalid-UTF-8 behaviour is documented.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
70 lines
2.2 KiB
PHP
70 lines
2.2 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
namespace LIT\MCP\Tests\Unit\Integrations\Divi\BlockTree;
|
|
|
|
use InvalidArgumentException;
|
|
use LIT\MCP\Integrations\Divi\BlockTree\Block;
|
|
use LIT\MCP\Integrations\Divi\BlockTree\Parser;
|
|
use LogicException;
|
|
use PHPUnit\Framework\TestCase;
|
|
use stdClass;
|
|
|
|
final class BlockTest extends TestCase
|
|
{
|
|
/** @return array<string, array{string}> */
|
|
public static function invalidNames(): array
|
|
{
|
|
return [
|
|
'no namespace' => ['button'],
|
|
'trailing markup injection' => ['divi/x --><script>'],
|
|
'uppercase' => ['Divi/Button'],
|
|
'empty' => [''],
|
|
];
|
|
}
|
|
|
|
/** @dataProvider invalidNames */
|
|
public function testCreateRejectsInvalidBlockNames(string $name): void
|
|
{
|
|
$this->expectException(InvalidArgumentException::class);
|
|
|
|
Block::create($name);
|
|
}
|
|
|
|
public function testCreateAcceptsAWellFormedName(): void
|
|
{
|
|
self::assertSame('divi/button', Block::create('divi/button')->name());
|
|
}
|
|
|
|
public function testSetAttrsRefusesOnAnOpaqueGlobalModule(): void
|
|
{
|
|
$document = (new Parser())->parse('<!-- wp:divi/section {"globalModule":"x"} --><!-- /wp:divi/section -->');
|
|
$section = $document->children()[0];
|
|
self::assertTrue($section->isOpaque());
|
|
|
|
$this->expectException(LogicException::class);
|
|
$section->setAttrs(['a' => 1]);
|
|
}
|
|
|
|
public function testSetAttrsRefusesOnABlockWithUndecodableAttrs(): void
|
|
{
|
|
$document = (new Parser())->parse('<!-- wp:divi/text {"a":} /-->');
|
|
$block = $document->children()[0];
|
|
self::assertTrue($block->isOpaque());
|
|
|
|
$this->expectException(LogicException::class);
|
|
$block->setAttrs(['a' => 1]);
|
|
}
|
|
|
|
public function testCopyDeepClonesStdClassAttributeValues(): void
|
|
{
|
|
$block = Block::create('divi/text', ['localAttrs' => new stdClass(), 'nested' => ['obj' => new stdClass()]]);
|
|
$copy = $block->copy();
|
|
|
|
self::assertNotSame($block->attrs()['localAttrs'], $copy->attrs()['localAttrs']);
|
|
self::assertEquals($block->attrs()['localAttrs'], $copy->attrs()['localAttrs']);
|
|
self::assertNotSame($block->attrs()['nested']['obj'], $copy->attrs()['nested']['obj']);
|
|
}
|
|
}
|