Files
WP-LIT-MCP/tests/Unit/Abilities/ErrorsTest.php
T
janniclas.loosenandClaude Opus 5.5 8e5ba9eac4 refactor: WriteFailed named constructors, Rollback runner, Errors read-back helpers (H6)
- WriteFailed::rolledBack()/partial() replace the 11-parameter constructor (now
  private); the hint/state of either error are plain $hint/$state.
- Rollback::attempt(...steps) runs every undo step and collects failure messages;
  used by ContentCreate::discard, ContentUpdate::rollBack, MediaUpdate::rollBack and
  DiviSaver::restore.
- Errors::clientMessage/codeOf/fieldsOf replace DiviReplaceTextAbility::reason,
  the JSON digging in MediaUpdateAbility::failure and ContentCreateAbility::fields.
- Errors docblock documents the exception/WP_Error split.
- ContentCreateAbility::discard takes the client reason as a parameter (both callers
  still pass REASON_EXTRAS; changing the Divi text needs a ruling).

Error payloads unchanged.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-09-26 17:40:32 +02:00

138 lines
6.0 KiB
PHP

<?php
declare(strict_types=1);
namespace LIT\MCP\Tests\Unit\Abilities;
use LIT\MCP\Abilities\Errors;
use LIT\MCP\Tests\Unit\TestCase;
final class ErrorsTest extends TestCase
{
public function testMessageCarriesCodeMessageHintAndFieldsAsJson(): void
{
$error = Errors::invalidInput('Titel fehlt.', ['title' => 'Pflichtfeld']);
self::assertSame('lit_validation_failed', $error->get_error_code());
$payload = json_decode($error->get_error_message(), true);
self::assertSame('validation_failed', $payload['code']);
self::assertSame('Titel fehlt.', $payload['message']);
self::assertNotSame('', $payload['hint']);
self::assertSame(['title' => 'Pflichtfeld'], $payload['fields']);
self::assertSame(400, $error->get_error_data()['status']);
self::assertSame($payload['hint'], $error->get_error_data()['hint']);
}
public function testUmlautsStayReadableInTheMessage(): void
{
$error = Errors::forbidden('Dein Benutzerkonto ist für LIT MCP nicht freigegeben.');
self::assertStringContainsString('für LIT MCP nicht freigegeben', $error->get_error_message());
}
public function testInUseCarriesTheUsages(): void
{
$error = Errors::inUse('Bild wird verwendet.', [['post_id' => 7, 'where' => 'featured']]);
$payload = json_decode($error->get_error_message(), true);
self::assertSame('lit_in_use', $error->get_error_code());
self::assertSame(7, $payload['usages'][0]['post_id']);
}
public function testEveryFactoryUsesLitPrefixAndANonEmptyHint(): void
{
$errors = [
Errors::forbidden('x'),
Errors::notFound('x'),
Errors::revMismatch(),
Errors::confirmRequired('x'),
Errors::unsupported('x', 'y'),
Errors::internal(),
];
foreach ($errors as $error) {
self::assertStringStartsWith('lit_', $error->get_error_code());
self::assertNotSame('', json_decode($error->get_error_message(), true)['hint']);
}
}
public function testWriteFailedSaysNothingWasSaved(): void
{
$error = Errors::writeFailed('Felder konnten nicht gespeichert werden.');
$payload = json_decode($error->get_error_message(), true);
self::assertSame('lit_write_failed', $error->get_error_code());
self::assertStringContainsString('Nichts wurde gespeichert.', $payload['message']);
self::assertStringContainsString('Felder konnten nicht gespeichert werden.', $payload['message']);
self::assertStringContainsString('erneut', $payload['hint']);
}
public function testWriteFailedCanDescribeWhatWasKept(): void
{
$error = Errors::writeFailed(
'Felder konnten nicht gespeichert werden.',
[],
null,
'Die Änderung wurde nicht gespeichert (Revision 811 bleibt erhalten).'
);
$message = json_decode($error->get_error_message(), true)['message'];
self::assertStringNotContainsString('Nichts wurde gespeichert', $message);
self::assertStringEndsWith('Die Änderung wurde nicht gespeichert (Revision 811 bleibt erhalten).', $message);
}
public function testRevMismatchCanNameItsOwnObjectAndReadTool(): void
{
$error = Errors::revMismatch('Das Menü wurde geändert.', 'Mit lit/menu-get neu lesen.');
self::assertSame('lit_rev_mismatch', $error->get_error_code());
self::assertSame('Das Menü wurde geändert.', json_decode($error->get_error_message(), true)['message']);
self::assertSame('Mit lit/menu-get neu lesen.', $error->get_error_data()['hint']);
self::assertStringContainsString('lit/content-get', Errors::revMismatch()->get_error_data()['hint']);
}
public function testPartialWriteNamesWhatMayHaveBeenSavedAndWarnsAgainstRetrying(): void
{
$error = Errors::partialWrite('Felder konnten nicht gespeichert werden.', 5, 811);
$payload = json_decode($error->get_error_message(), true);
self::assertSame('lit_partial_write', $error->get_error_code());
self::assertStringContainsString('Eintrag 5', $payload['message']);
self::assertStringContainsString('Revision 811', $payload['message']);
self::assertStringContainsString('lit-content-get', $payload['hint']);
self::assertStringContainsString('lit/revisions-list', $payload['hint']);
self::assertStringContainsString('mcp-adapter-execute-ability', $payload['hint']);
self::assertStringContainsString('nicht einfach wiederholen', $payload['hint']);
self::assertSame(5, $payload['post_id']);
self::assertSame(811, $payload['revision_id']);
}
public function testPartialWriteWithoutIdSaysADraftMayExist(): void
{
$payload = json_decode(Errors::partialWrite('Anlegen fehlgeschlagen.')->get_error_message(), true);
self::assertStringContainsString('Entwurf', $payload['message']);
self::assertArrayNotHasKey('post_id', $payload);
}
public function testClientMessageReadsTheJsonMessageBack(): void
{
self::assertSame('Titel fehlt.', Errors::clientMessage(Errors::invalidInput('Titel fehlt.')));
self::assertSame('WordPress sagt nein', Errors::clientMessage(new \WP_Error('db', 'WordPress sagt nein')));
self::assertSame('{"code":"x"}', Errors::clientMessage(new \WP_Error('db', '{"code":"x"}')));
}
public function testCodeOfDropsTheLitPrefixOnly(): void
{
self::assertSame('validation_failed', Errors::codeOf(Errors::invalidInput('x')));
self::assertSame('db_error', Errors::codeOf(new \WP_Error('db_error', 'x')));
}
public function testFieldsOfReturnsTheFieldsOrNothing(): void
{
self::assertSame(['title' => 'Pflichtfeld'], Errors::fieldsOf(Errors::invalidInput('x', ['title' => 'Pflichtfeld'])));
self::assertSame([], Errors::fieldsOf(Errors::invalidInput('x')));
self::assertSame([], Errors::fieldsOf(new \WP_Error('db', 'x', 'kein Array')));
}
}